Exposed common EuiExpressions to separate components be able to reuse for building new for Alert Types by YulNaumenko · Pull Request #56466 · elastic/kibana

YulNaumenko · 2020-01-31T05:04:34Z

Summary

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2020-01-31T05:04:37Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

…mon-alert-type-expressions # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

…mon-alert-type-expressions # Conflicts: # x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/application/components/builtin_alert_types/threshold/expression.tsx # x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/application/sections/alert_add/alert_add.tsx

gmmorris

Looking good 👍

Just a few typing issue, but overall LGTM.

...ers_actions_ui/np_ready/public/application/components/builtin_alert_types/threshold/index.ts

gmmorris · 2020-02-05T07:10:28Z

...ns_ui/np_ready/public/application/components/builtin_alert_types/threshold/visualization.tsx

        .tz(timezone)
-        .format(getTimeBuckets(alert.params).getScaledDateFormat());
+        .format(getTimeBuckets(alertParams).getScaledDateFormat());
    };


Is it possible to avoid any and the as number[][][] here?

For the any: Looking at the underlying type, it looks like it uses number explicitly, so we shouldn't need to cast this here. 🤔

For the number[][][]: Looks the core issue is the any in getThresholdAlertVisualizationData, so can we perhaps validate the result of the API call in getThresholdAlertVisualizationData and avoid the any there too?

...cy/plugins/triggers_actions_ui/np_ready/public/application/sections/alert_add/alert_form.tsx

x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/common/constants/comparators.ts

x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/types.ts

…mon-alert-type-expressions # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

mikecote

LGTM! Just a few nits / comments.

...gins/triggers_actions_ui/np_ready/public/application/components/builtin_alert_types/types.ts

x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/common/constants/comparators.ts

x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/common/constants/group_by_types.ts

…rops

elasticmachine · 2020-02-06T19:23:46Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 1ad46d5

History

💚 Build #24808 succeeded 73bc017
💔 Build #24786 failed f310132
💔 Build #24756 failed e4e9f4b
💔 Build #24721 failed 293d985
💚 Build #24396 succeeded db7678b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2020-02-06T19:54:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 2bd5bef

Test Failures

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/spaces/server/lib/request_interceptors.onPostAuthInterceptor requests proxied to the legacy platform redirects to the space selector screen when accessing an app within a non-existent space

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 7 times on tracked branches: https://github.com/elastic/kibana/issues/55953

Stack Trace

: Timeout - Async callback was not invoked within the 30000ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 30000ms timeout specified by jest.setTimeout.Error: 
    at new Spec (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/Spec.js:116:22)
    at new Spec (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/setup_jest_globals.js:80:9)
    at specFactory (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:575:24)
    at Env.it (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:644:24)
    at Env.it (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:132:23)
    at it (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:93:21)
    at Suite.describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/spaces/server/lib/request_interceptors/on_post_auth_interceptor.test.ts:233:5)
    at addSpecsToSuite (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:496:51)
    at Env.describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:466:11)
    at describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:81:18)
    at Suite.Object.<anonymous>.describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/spaces/server/lib/request_interceptors/on_post_auth_interceptor.test.ts:232:3)
    at addSpecsToSuite (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:496:51)
    at Env.describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:466:11)
    at describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:81:18)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/spaces/server/lib/request_interceptors/on_post_auth_interceptor.test.ts:33:1)
    at Runtime._execModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:867:68)
    at Runtime._loadModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:577:12)
    at Runtime.requireModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:433:10)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/index.js:202:13
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/index.js:27:24)
    at _next (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/index.js:47:9)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/index.js:52:7
    at new Promise (<anonymous>)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/index.js:44:12
    at jasmine2 (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/index.js:60:19)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:385:24
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:161:24)
    at _next (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:181:9)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/spaces/server/lib/request_interceptors.onPostAuthInterceptor requests proxied to the legacy platform when accessing the kibana app it always allows the request to continue

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 7 times on tracked branches: https://github.com/elastic/kibana/issues/55954

Stack Trace

Error: Http server is not setup up yet
    at HttpServer.start (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/core/server/http/http_server.ts:142:13)
    at HttpService.start (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/core/server/http/http_service.ts:134:29)

History

💚 Build #24994 succeeded 1ad46d5
💚 Build #24808 succeeded 73bc017
💔 Build #24786 failed f310132
💔 Build #24756 failed e4e9f4b
💔 Build #24721 failed 293d985

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…mon-alert-type-expressions # Conflicts: # x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/application/components/builtin_alert_types/threshold/constants/aggregation_types.ts # x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/application/components/builtin_alert_types/threshold/constants/comparators.ts # x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/application/components/builtin_alert_types/threshold/constants/index.ts # x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/application/components/builtin_alert_types/threshold/types.ts # x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/application/lib/get_time_options.test.ts # x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/application/lib/get_time_options.ts # x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/application/lib/get_time_unit_label.ts # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/constants/aggregation_types.ts # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/constants/comparators.ts # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/constants/index.ts # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/types.ts # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/visualization.tsx # x-pack/plugins/triggers_actions_ui/public/application/lib/get_time_options.test.ts # x-pack/plugins/triggers_actions_ui/public/application/lib/get_time_options.ts # x-pack/plugins/triggers_actions_ui/public/application/lib/get_time_unit_label.ts # x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/action_connector_form.test.tsx # x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/action_type_menu.test.tsx # x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/connector_add_modal.test.tsx # x-pack/plugins/triggers_actions_ui/public/common/constants/index.ts # x-pack/plugins/triggers_actions_ui/public/common/expression_items/index.ts # x-pack/plugins/triggers_actions_ui/public/common/index.ts # x-pack/plugins/triggers_actions_ui/public/common/lib/get_time_options.test.ts # x-pack/plugins/triggers_actions_ui/public/common/lib/get_time_options.ts # x-pack/plugins/triggers_actions_ui/public/common/lib/get_time_unit_label.ts # x-pack/plugins/triggers_actions_ui/public/common/types.ts

elasticmachine · 2020-02-06T20:56:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b8a18f4

History

💔 Build #25010 failed 2bd5bef
💚 Build #24994 succeeded 1ad46d5
💚 Build #24808 succeeded 73bc017
💔 Build #24786 failed f310132
💔 Build #24756 failed e4e9f4b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2020-02-06T22:03:46Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 2fcd805

History

💚 Build #25035 succeeded b8a18f4
💔 Build #25010 failed 2bd5bef
💚 Build #24994 succeeded 1ad46d5
💚 Build #24808 succeeded 73bc017
💔 Build #24786 failed f310132

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2020-02-07T01:36:56Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f8438c9

History

💚 Build #25065 succeeded 2fcd805
💚 Build #25035 succeeded b8a18f4
💔 Build #25010 failed 2bd5bef
💚 Build #24994 succeeded 1ad46d5
💚 Build #24808 succeeded 73bc017

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2020-02-07T02:20:20Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: c7485d5

History

💚 Build #25129 succeeded f8438c9
💚 Build #25065 succeeded 2fcd805
💚 Build #25035 succeeded b8a18f4
💔 Build #25010 failed 2bd5bef
💚 Build #24994 succeeded 1ad46d5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…b.com:jloleysens/kibana into console/feature/text-objects-in-saved-objects * 'console/feature/text-objects-in-saved-objects' of github.com:jloleysens/kibana: (103 commits) fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998) TS of esKuery\node_types (elastic#56857) Kibana app migration: Move static code dependencies into kibana_legacy plugin, part 1 (elastic#56408) Retry ES API calls that fail with 410/Gone (elastic#56950) [APM] Show missing permissions message to the user on the Services overview (elastic#56374) Fixing flaky CI tests for custom appRoutes (elastic#55763) [State Management][Docs] State syncing utils docs (elastic#56479) [Index management] Remove index mapper setting in tests (elastic#57066) Exposed common EuiExpressions to separate components be able to reuse for building new for Alert Types (elastic#56466) [SIEM] update url state between page if date is relative (elastic#56813) fix for chart_types test (elastic#57056) chore(NA): remove compress from dll minimizer (elastic#57023) [File upload] Migrate routing to NP & add route validation (elastic#52313) Adding docs for grouped nav advanced setting (elastic#57013) Use i18n titles for field formatters, human names for numeral locales (elastic#56348) [Maps] Remove EMS catalogue url from docs (elastic#57020) [Endpoint] ERT-82 ERT-83 ERT-84: Alert list API with pagination (elastic#56538) [DOCS] Adds Apple notarization info to install doc (elastic#57042) [ML] New Platform server shim: update results service routes to use new platform router (elastic#56886) Fix typo on detection engine rule (elastic#56993) ...

… for building new for Alert Types (elastic#56466) * Exposed common Expression to separate components be able to reuse * Expressions with unit tests * Fixed type check * Fixed merge issues * Fixed due to review * Cleaned up some not used params and added position popover definition * fixed type check * Unbinded alerting reusable components from application context * Added consumer and alertTypeId with enable change alert type button props * Fixed case for default alert type id was set * Fixed chart visualization issues * Exposed registry in triggers and actions ui * Fixed alert_list to enable charts * Fixed due to comments and simplified props

… reuse for building new for Alert Types (#56466) (#57224) * Exposed common EuiExpressions to separate components be able to reuse for building new for Alert Types (#56466) * Exposed common Expression to separate components be able to reuse * Expressions with unit tests * Fixed type check * Fixed merge issues * Fixed due to review * Cleaned up some not used params and added position popover definition * fixed type check * Unbinded alerting reusable components from application context * Added consumer and alertTypeId with enable change alert type button props * Fixed case for default alert type id was set * Fixed chart visualization issues * Exposed registry in triggers and actions ui * Fixed alert_list to enable charts * Fixed due to comments and simplified props * Fixed type check issue * type check error

Exposed common Expression to separate components be able to reuse

8c7ed23

YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// labels Jan 31, 2020

YulNaumenko self-assigned this Jan 31, 2020

YulNaumenko added 2 commits January 31, 2020 17:37

Expressions with unit tests

b54cdd6

YulNaumenko requested review from gmmorris and mikecote February 3, 2020 04:34

YulNaumenko added 4 commits February 3, 2020 10:06

Fixed type check

7c5031c

Fixed merge issues

db7678b

gmmorris approved these changes Feb 5, 2020

View reviewed changes

YulNaumenko added 4 commits February 5, 2020 12:25

Fixed due to review

293d985

Cleaned up some not used params and added position popover definition

e4e9f4b

fixed type check

73bc017

mikecote approved these changes Feb 6, 2020

View reviewed changes

YulNaumenko added 2 commits February 6, 2020 09:48

Unbinded alerting reusable components from application context

1ad46d5

Added consumer and alertTypeId with enable change alert type button p…

2bd5bef

…rops

elastic deleted a comment from kibanamachine Feb 6, 2020

Fixed case for default alert type id was set

b8a18f4

YulNaumenko requested a review from a team as a code owner February 6, 2020 19:32

Fixed chart visualization issues

2fcd805

YulNaumenko added 3 commits February 6, 2020 16:15

Exposed registry in triggers and actions ui

e414ef7

Fixed alert_list to enable charts

f8438c9

Fixed due to comments and simplified props

c7485d5

YulNaumenko merged commit 2e0d09b into elastic:master Feb 7, 2020

YulNaumenko mentioned this pull request Feb 10, 2020

[7.x] Exposed common EuiExpressions to separate components be able to reuse for building new for Alert Types (#56466) #57224

Merged

YulNaumenko added the backported label Feb 18, 2020

Comments

Conversation

YulNaumenko commented Jan 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Jan 31, 2020

Uh oh!

gmmorris left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gmmorris Feb 5, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mikecote left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Feb 6, 2020

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Feb 6, 2020

💔 Build Failed

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

History

Uh oh!

elasticmachine commented Feb 6, 2020

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Feb 6, 2020

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Feb 7, 2020

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Feb 7, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

YulNaumenko commented Jan 31, 2020 •

edited

Loading