Upgrade EUI to v17.3.1 #53655

thompsongl · 2019-12-19T22:42:39Z

Summary

[email protected] ⏩ [email protected]

More form components are now in TypeScript and will be more opinionated about accepted values
EuiDataGrid performance boosts 🚀
a11y improvements and fixes

`17.3.1`

Bug fixes

Fixed TS types and exports for EuiTextArea and EuiFieldNumber (#2703)

`17.3.0`

Converted EuiFieldNumber to Typescript (#2685)
Converted EuiFieldPassword to Typescript (#2683)
Converted EuiHighlight to Typescript (#2681)
Added data-test-subj property to the EuiCodeEditor component (#2689)
Converted EuiTextArea to Typescript (#2695)
Converted EuiPage and related child components to TypeScript (#2669)
Added annotation glyph (#2691)
Added initialWidth and isResizable configurations to EuiDataGrid's columns (#2696)

Bug fixes

Reverted removal of toggleOpen method from EuiNavDrawer (#2682)
Improved EuiDataGrid update performance (#2676)
Fixed EuiDatagrid header top border when configured to have no toolbar (#2619)

`17.2.1`

[...]

Bug fixes

Removed TypeScript definitions in *.test.tsx? files from eui.d.ts (#2673)

`17.2.0`

Improved a11y of EuiNavDrawer lock button state via aria-pressed (#2643)
Added new stylesheets for the EUI Amsterdam theme (#2633)
Added exports for available types related to EuiDataGrid (#2640)

Bug fixes

Improved EuiDataGrid update performance (#2638)
Fixed EuiDroppable not accepting multiple children when using TypeScript (#2634)
Fixed EuiComboBox from submitting parent form element when selecting options via Enter key (#2642)
Fixed EuiNavDrawer expand button from losing focus after click (#2643)
Fixed instances of potentially duplicate EuiPopover id attributes (#2667)

thompsongl · 2019-12-20T16:59:43Z

@elasticmachine merge upstream

…o eui/17.3.1

legrego

Security/Spaces changes LGTM. Tested locally.

legrego · 2019-12-20T18:34:36Z

...ment/edit_role/components/privileges/kibana/space_aware_privilege_section/space_selector.tsx

-  // @ts-ignore
-  EuiHighlight,
-} from '@elastic/eui';
+import { EuiComboBox, EuiComboBoxOptionProps, EuiHealth, EuiHighlight } from '@elastic/eui';


myasonik

Approving because this is still better than what it used to be but I am still worried we're potentially masking some bugs and pretending they're data...

myasonik · 2019-12-20T21:36:05Z

x-pack/legacy/plugins/lens/public/indexpattern_plugin/operations/definitions/date_histogram.tsx

                      data-test-subj="lensDateHistogramValue"
-                      value={interval.value}
+                      value={
+                        typeof interval.value === 'number' || interval.value === ''


Not super problematic but seems odd that EUI accepts a number or an empty string... (Am I reading that right?)

I'd expect a type signature more like number | undefined maybe?

Also, does this need a NaN check?

myasonik · 2019-12-20T21:38:18Z

x-pack/legacy/plugins/lens/public/indexpattern_plugin/operations/definitions/date_histogram.tsx

+                      value={
+                        typeof interval.value === 'number' || interval.value === ''
+                          ? interval.value
+                          : parseInt(interval.value, 10)


Maybe not for an EUI update PR but is this really a good spot to do this?

If a non-number has gotten to this point, would it be better to throw an error rather the furthering the rabbit hole of chasing down bad data? Basically, this could lead to subtle bugs that cause people to make mistakes assuming the data is correct.

So the options here are to cast value as EuiFieldNumberProps['value'] or attempt to resolve any errors (like so).

Earlier in the script, parseInterval has already transformed interval.value into number | '' like we want. Elsewhere in this file, though, interval.value is expected to be a string.

myasonik · 2019-12-20T21:38:49Z

...eady/application/sections/watch_edit/components/json_watch_edit/json_watch_edit_simulate.tsx

              <EuiFlexItem>
                <EuiFieldNumber
-                  value={scheduledTimeValue}
+                  value={


Same discussion questions as above for all of these

thompsongl · 2019-12-20T22:23:31Z

Approving because this is still better than what it used to be but I am still worried we're potentially masking some bugs and pretending they're data...

Agreed, @myasonik. This maintains parity, but does highlight some places where data types should be evaluated

streamich

App Arch code changes LGTM.

thompsongl · 2019-12-23T14:24:27Z

@elasticmachine merge upstream

kibanamachine · 2019-12-23T15:41:39Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 513d2d1

History

💚 Build #16985 succeeded 0d1265b
💚 Build #16950 succeeded a197c0e
💔 Build #16817 failed c60943a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* eui to 17.3.0 * eui to 17.3.1 * TS updates * snapshot updates * update data-test-subj Co-authored-by: Elastic Machine <[email protected]>

* eui to 17.3.0 * eui to 17.3.1 * TS updates * snapshot updates * update data-test-subj Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

…le-saved-objects * 'master' of github.com:elastic/kibana: (250 commits) Allow chromeless applications to render via non-/app routes (elastic#51527) Add server rendering service to enable standalone route rendering (elastic#52161) Possibility to filter when testing scripted fields (elastic#35379) (elastic#44220) Update maps telemetry mappings to account for recent updates (elastic#53803) [Maps] Only show legend when layer is visible (elastic#53781) remove use of experimental fs.promises api (elastic#53346) [APM] Add log statements for flaky test (elastic#53775) [APM] Transaction page throws unhandled exception if transactions doesn't have `http.request` (elastic#53760) Licensing plugin functional tests (elastic#53580) [Lens] Disable saving visualization until there are no changes to the document (elastic#52982) [Monitoring] Added safeguard for some EUI components (elastic#53318) [Vega] Shim new platform - cleanup vega_visualization dependencies (elastic#53605) Display changed field formats without requiring hard page refresh. (elastic#53746) Upgrade EUI to v17.3.1 (elastic#53655) [APM] Fix missing apm indicies (elastic#53541) Disable inspector for timelion (elastic#53747) Clean up search servie (elastic#53701) [Dashboard] Grid: removing double handler (elastic#53707) Remove SavedObjectRegistryProvider from codebase (elastic#53455) Move ui/courier into data shim plugin (elastic#52359) ...

* eui to 17.3.0 * eui to 17.3.1 * TS updates * snapshot updates * update data-test-subj Co-authored-by: Elastic Machine <[email protected]>

thompsongl added 4 commits December 19, 2019 13:50

eui to 17.3.0

2be8e6b

eui to 17.3.1

45d7317

TS updates

9768d70

snapshot updates

c60943a

thompsongl added EUI release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0 labels Dec 19, 2019

thompsongl added 3 commits December 20, 2019 09:34

Merge branch 'master' into eui/17.3.1

fcd7c87

update data-test-subj

95d2221

Merge branch 'master' into eui/17.3.1

21c7547

elasticmachine and others added 2 commits December 20, 2019 08:59

Merge branch 'master' into eui/17.3.1

a197c0e

Merge branch 'eui/17.3.1' of https://github.com/thompsongl/kibana int…

230cf5f

…o eui/17.3.1

thompsongl marked this pull request as ready for review December 20, 2019 18:27

thompsongl requested a review from a team as a code owner December 20, 2019 18:27

thompsongl requested a review from a team December 20, 2019 18:27

thompsongl requested review from a team as code owners December 20, 2019 18:27

Merge branch 'master' into eui/17.3.1

0d1265b

legrego self-requested a review December 20, 2019 18:36

legrego approved these changes Dec 20, 2019

View reviewed changes

myasonik approved these changes Dec 20, 2019

View reviewed changes

streamich approved these changes Dec 23, 2019

View reviewed changes

mshustov approved these changes Dec 23, 2019

View reviewed changes

Merge branch 'master' into eui/17.3.1

513d2d1

elastic deleted a comment from elasticmachine Dec 23, 2019

thompsongl merged commit e707692 into elastic:master Dec 23, 2019

thompsongl mentioned this pull request Dec 23, 2019

[7.x] Upgrade EUI to v17.3.1 (#53655) #53769

Merged

thompsongl added a commit to thompsongl/kibana that referenced this pull request Dec 23, 2019

Upgrade EUI to v17.3.1 (elastic#53655)

0e68557

* eui to 17.3.0 * eui to 17.3.1 * TS updates * snapshot updates * update data-test-subj Co-authored-by: Elastic Machine <[email protected]>

jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 8, 2020

Upgrade EUI to v17.3.1 (elastic#53655)

bebc441

* eui to 17.3.0 * eui to 17.3.1 * TS updates * snapshot updates * update data-test-subj Co-authored-by: Elastic Machine <[email protected]>

Upgrade EUI to v17.3.1 #53655

Upgrade EUI to v17.3.1 #53655

Uh oh!

Conversation

thompsongl commented Dec 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

thompsongl commented Dec 20, 2019

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

myasonik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Dec 20, 2019

Uh oh!

streamich left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Dec 23, 2019

Uh oh!

kibanamachine commented Dec 23, 2019

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

thompsongl commented Dec 19, 2019 •

edited

Loading