Skip to content

Conversation

@thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Dec 12, 2019

Summary

Chipping away at #2252

  • On clicking the expand/collapse button, focus management is lost and is returned to the body. (It should stay on the button.)

  • The dock/undock button should have aria-pressed=true|false defined to communicate state. This can replace the role=switch and aria-checked=true|false

  • Some clean up to remove an unused method and an outdated comment

Checklist

- [ ] Checked in dark mode
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox

  • Props have proper autodocs

- [ ] Added documentation examples
- [ ] Added or updated jest tests
- [ ] Checked for breaking changes and labeled appropriately

  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@thompsongl thompsongl requested review from myasonik and snide December 12, 2019 20:30
@myasonik myasonik mentioned this pull request Dec 12, 2019
11 tasks
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a CL, otherwise looks good.

@thompsongl thompsongl merged commit fbe66d5 into elastic:master Dec 13, 2019
@snide snide mentioned this pull request Jan 11, 2020
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants