[Dashboard] Grid: removing double handler #53707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majagrubic
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
majagrubic
added
v7.6.0
v8.0.0
Feature:Dashboard
cchaos
approved these changes
Dec 20, 2019
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
LGTM, Thanks! Consider adding a comment explaining that this overrides the library's visual indicator.
Contributor
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 30, 2019
…le-saved-objects * 'master' of github.com:elastic/kibana: (250 commits) Allow chromeless applications to render via non-/app routes (elastic#51527) Add server rendering service to enable standalone route rendering (elastic#52161) Possibility to filter when testing scripted fields (elastic#35379) (elastic#44220) Update maps telemetry mappings to account for recent updates (elastic#53803) [Maps] Only show legend when layer is visible (elastic#53781) remove use of experimental fs.promises api (elastic#53346) [APM] Add log statements for flaky test (elastic#53775) [APM] Transaction page throws unhandled exception if transactions doesn't have `http.request` (elastic#53760) Licensing plugin functional tests (elastic#53580) [Lens] Disable saving visualization until there are no changes to the document (elastic#52982) [Monitoring] Added safeguard for some EUI components (elastic#53318) [Vega] Shim new platform - cleanup vega_visualization dependencies (elastic#53605) Display changed field formats without requiring hard page refresh. (elastic#53746) Upgrade EUI to v17.3.1 (elastic#53655) [APM] Fix missing apm indicies (elastic#53541) Disable inspector for timelion (elastic#53747) Clean up search servie (elastic#53701) [Dashboard] Grid: removing double handler (elastic#53707) Remove SavedObjectRegistryProvider from codebase (elastic#53455) Move ui/courier into data shim plugin (elastic#52359) ...
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Jan 5, 2020
* Fixing double handler * Adding a comment Co-authored-by: Elastic Machine <[email protected]>
majagrubic
pushed a commit
that referenced
this pull request
Jan 5, 2020
* Fixing double handler * Adding a comment Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 8, 2020
* Fixing double handler * Adding a comment Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for #53699.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers