Move ui/courier into data shim plugin #52359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeelmers
added
Feature:Search
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
This comment has been minimized.
This comment has been minimized.
lukasolson
reviewed
Dec 6, 2019
src/legacy/core_plugins/data/public/search/fetch/handle_response.test.ts
Outdated
Show resolved
Hide resolved
lukasolson
reviewed
Dec 6, 2019
src/legacy/core_plugins/data/public/search/search_source/mocks.ts
Outdated
Show resolved
Hide resolved
lukasolson
reviewed
Dec 6, 2019
Contributor
lukasolson
left a comment
lukasolson
left a comment
There was a problem hiding this comment.
Code is LGTM. I haven't tested it yet but I'll give it a spin when tests are passing and you're getting ready to merge it.
lukeelmers
force-pushed
the
courier/move
branch
2 times, most recently
from
8f86fef to
ae7e2a1
Compare
lukeelmers
changed the title
cchaos
approved these changes
Dec 10, 2019
Contributor
There was a problem hiding this comment.
👍 So long as this path is correct
wylieconlon
reviewed
Dec 10, 2019
Contributor
wylieconlon
left a comment
wylieconlon
left a comment
There was a problem hiding this comment.
I don't want this Lens change to get in your way, but I would like to understand.
...egacy/plugins/lens/public/indexpattern_plugin/operations/definitions/date_histogram.test.tsx
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
lukeelmers
force-pushed
the
courier/move
branch
from
76904b6 to
1d25c43
Compare
wylieconlon
approved these changes
Dec 12, 2019
Contributor
wylieconlon
left a comment
wylieconlon
left a comment
There was a problem hiding this comment.
Lens change LGTM, but did not look anywhere else
...egacy/plugins/lens/public/indexpattern_plugin/operations/definitions/date_histogram.test.tsx
Outdated
Show resolved
Hide resolved
lukeelmers
force-pushed
the
courier/move
branch
from
3996e1f to
256670c
Compare
lukasolson
approved these changes
Dec 19, 2019
Contributor
lukasolson
left a comment
lukasolson
left a comment
There was a problem hiding this comment.
LGTM! Left a couple of minor notes. Pulled down and tested as well, and everything (including rollups & cancellation) seems to be working.
lukeelmers
force-pushed
the
courier/move
branch
from
e688738 to
71eb5ce
Compare
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
lukeelmers
added a commit
that referenced
this pull request
Dec 23, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 30, 2019
…le-saved-objects * 'master' of github.com:elastic/kibana: (250 commits) Allow chromeless applications to render via non-/app routes (elastic#51527) Add server rendering service to enable standalone route rendering (elastic#52161) Possibility to filter when testing scripted fields (elastic#35379) (elastic#44220) Update maps telemetry mappings to account for recent updates (elastic#53803) [Maps] Only show legend when layer is visible (elastic#53781) remove use of experimental fs.promises api (elastic#53346) [APM] Add log statements for flaky test (elastic#53775) [APM] Transaction page throws unhandled exception if transactions doesn't have `http.request` (elastic#53760) Licensing plugin functional tests (elastic#53580) [Lens] Disable saving visualization until there are no changes to the document (elastic#52982) [Monitoring] Added safeguard for some EUI components (elastic#53318) [Vega] Shim new platform - cleanup vega_visualization dependencies (elastic#53605) Display changed field formats without requiring hard page refresh. (elastic#53746) Upgrade EUI to v17.3.1 (elastic#53655) [APM] Fix missing apm indicies (elastic#53541) Disable inspector for timelion (elastic#53747) Clean up search servie (elastic#53701) [Dashboard] Grid: removing double handler (elastic#53707) Remove SavedObjectRegistryProvider from codebase (elastic#53455) Move ui/courier into data shim plugin (elastic#52359) ...
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #42639
This does the initial work of moving
ui/courierintosrc/legacy/core_plugins/data. Contracts have been re-exported to preserve backwards compatibility for plugins that are still importing fromui/courier.The only change made here was renaming
SearchSourceContracttoISearchSourcefor consistency with some of our other interfaces. Otherwise no changes have been made; we are just re-locating everything in the legacydataplugin so that it is easier to refactor everything to be fully NP-ready.For the time being I've just preserved the folder structure from
ui/courierinside ofcore_plugins/data/public/search. It will probably make sense to rearrange the internal structure eventually, but for the sake of keeping this PR simple, I think it would be better to wait on that until some of the other refactoring has been done.QA
This should introduce no functional changes: it is simply moving code around.
Detailed dev docs will be added to #43511 once changes are made to the interfaces exported from the
ui/public/courierdirectory.