Conversation
thompsongl
added
chore
v8.0.0
release_note:skip
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; package.json, TypeScript & snapshot changes are as expected from the EUI changelog
| aria-label={ | ||
| checked ? `${record.feature.name} visible` : `${record.feature.name} disabled` | ||
| } | ||
| label="" |
There was a problem hiding this comment.
question It seems like we're using EuiSwitch incorrectly now. It looks like we'll be creating an empty label tag next to the switch now.
If we're ok using switches without a label (like our use case here), should we instead be creating the markup without the <label> tag, and making the label prop optional?
There was a problem hiding this comment.
Thanks, @legrego , I meant to call this out specifically.
Accessibility is the reason for the change (cc @myasonik), and I was going to run through the app and find the places with empty labels.
@snide, this seems like a design v. a11y situation, because now that I see it in use, the bare switch seems reasonable.
There was a problem hiding this comment.
@legrego We're going to roll back the changes to EuiSwitch. Not just because of your concerns, but also some more sticky upgrade migration things we've run into too close to FF.
I'll be closing this PR in favor of one with an altered scope and version.
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
Closing this in favor of a forthcoming upgrade PR with an altered scope |
5 participants
eui@13.3.0 ⏩ eui@13.4.1
Conversion of
EuiSwitchto TypeScript and to use abuttonis the reason for most of the churn13.4.1EuiSwitchto TypeScript (#2243)Bug fixes
viewBoxattribute to Docker, Kubernetes, and Redis logos (#2240)13.4.0EuiFacetButtonto TypeScript (#2226)onClearprop to the theEuiDatePickercomponent (#2235)onClickandhrefprops onEuiListGroupItemand converted to TypeScript (#1933)Bug fixes
EuiSwitchsemantics to align with aria roles (#2193)onChangeTS defs for EuiRange (#2211)EuiBadgetext cursor to default pointer (#2234)EuiPageContentclassName prop to allow the passed-in className to take cascade precedence over classes generated by the component (#2237)