Skip to content

Fix cascade issue with adding className to EuiPageContent#2237

Merged
Zacqary merged 2 commits intoelastic:masterfrom
Zacqary:2232-pagecontent-classname-reorder
Aug 19, 2019
Merged

Fix cascade issue with adding className to EuiPageContent#2237
Zacqary merged 2 commits intoelastic:masterfrom
Zacqary:2232-pagecontent-classname-reorder

Conversation

@Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Aug 16, 2019

Summary

Fixes #2232

Reorders the insertion of className into <EuiPageContent> so that you can use class names to override properties otherwise specified by .euiPageContent--verticalCenter or .euiPageContent--horizontalCenter without using !important. The passed in className will now take precedence.

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just needs a changelog entry. https://github.com/elastic/eui/blob/master/CHANGELOG.md

You can drop it under bugfix. Please used past tense.

@Zacqary Zacqary merged commit 2c01b2c into elastic:master Aug 19, 2019
@Zacqary Zacqary deleted the 2232-pagecontent-classname-reorder branch August 19, 2019 20:22
thompsongl pushed a commit to thompsongl/eui that referenced this pull request Sep 10, 2019
* Fix cascade issue with adding className to EuiPageContent

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EuiPageContent's max-width not stylable when using a class name

3 participants