Fix cascade issue with adding className to EuiPageContent#2237
Merged
Zacqary merged 2 commits intoelastic:masterfrom Aug 19, 2019
Merged
Fix cascade issue with adding className to EuiPageContent#2237Zacqary merged 2 commits intoelastic:masterfrom
Zacqary merged 2 commits intoelastic:masterfrom
Conversation
snide
reviewed
Aug 16, 2019
Contributor
snide
left a comment
There was a problem hiding this comment.
This just needs a changelog entry. https://github.com/elastic/eui/blob/master/CHANGELOG.md
You can drop it under bugfix. Please used past tense.
thompsongl
approved these changes
Aug 19, 2019
This was referenced Aug 21, 2019
thompsongl
pushed a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
* Fix cascade issue with adding className to EuiPageContent * Add changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2232
Reorders the insertion of
classNameinto<EuiPageContent>so that you can use class names to override properties otherwise specified by.euiPageContent--verticalCenteror.euiPageContent--horizontalCenterwithout using!important. The passed inclassNamewill now take precedence.Checklist