Adds onClear prop to EuiDatePicker to make it "clearable"#2235
Merged
jasonrhodes merged 3 commits intoelastic:masterfrom Aug 16, 2019
Merged
Adds onClear prop to EuiDatePicker to make it "clearable"#2235jasonrhodes merged 3 commits intoelastic:masterfrom
jasonrhodes merged 3 commits intoelastic:masterfrom
Conversation
thompsongl
suggested changes
Aug 16, 2019
7 tasks
Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com>
snide
approved these changes
Aug 16, 2019
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
TY for adding to the docs. Checked for keyboard accessibility and reviewed the code. LGTM.
Member
Author
EUI docs are some of the best around, I'll be damned if I'll be the one to screw that up. Thanks!!! |
This was referenced Aug 21, 2019
thompsongl
added a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
* Adds onClear prop to EuiDatePicker to make it "clearable" * Adds changelog entry * Update CHANGELOG.md Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
onCloseprop to the theEuiDatePickercomponent. When present, it's passed to theEuiFormControlLayoutthat already wraps the date picker component, as itsonClickmethod, so that the standard EUI close icon is applied.Checklist