Convert EuiFacetButton to TS#2226
Merged
thompsongl merged 4 commits intoelastic:masterfrom Aug 14, 2019
Merged
Conversation
cchaos
approved these changes
Aug 14, 2019
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
LGTM, I just had one unrelated ask.
jfsiii
reviewed
Aug 14, 2019
jfsiii
reviewed
Aug 14, 2019
jfsiii
reviewed
Aug 14, 2019
jfsiii
left a comment
jfsiii
left a comment
There was a problem hiding this comment.
I added two suggestions for alternatives to importing/exporting EuiFacetButtonProps.
Perhaps I misunderstood the intent, but I believe they'll behave the same and avoid the renaming
Contributor
Author
|
@jfsiii Right idea, but apparently exporting members like that inside of a declaration block doesn't work. |
|
Ah, I missed that this was inside |
This was referenced Aug 21, 2019
thompsongl
added a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
* convert euifacetbutton to ts * concat className * CL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2216 and converts
EuiFacetButtonto TypeScript.Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes