Merged
Conversation
Contributor
|
Pinging @elastic/apm-ui |
vigneshshanmugam
approved these changes
Aug 8, 2019
Member
vigneshshanmugam
left a comment
vigneshshanmugam
left a comment
There was a problem hiding this comment.
Thanks @sqren looks good from RUM agent side :)
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
This was referenced Aug 9, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 9, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (306 commits) [ML] Adding job overrides to the module setup endpoint (elastic#42946) [APM] Fix missing RUM url (elastic#42940) close socket timeouts without message (elastic#42456) Upgrade elastic/charts to 8.1.6 (elastic#42518) [ML] Delete old AngularJS data visualizer and refactor folders (elastic#42962) Add custom formatting for Date Nanos Format (elastic#42445) [Vega] Shim new platform - vega_fn.js -> vega_fn.js , use ExpressionFunction (elastic#42582) add socket.getPeerCertificate to KibanaRequest (elastic#42929) [Automation] ISTANBUL PRESET PATH is not working fine with constructor(private foo) (elastic#42683) [ML] Data frames: Updated stats structure. (elastic#42923) [Code] fixed the issue that the repository can not be deleted in some cases. (elastic#42841) [kbn-es] Support for passing regex value to ES (elastic#42651) Connect to Elasticsearch via SSL when starting kibana with `--ssl` (elastic#42840) Add Elasticsearch SSL support for integration tests (elastic#41765) Fix duplicate fetch in Visualize (elastic#41204) [DOCS] TSVB and Timelion clean up (elastic#42953) [Maps] [File upload] Fix maps geojson upload hanging on index step (elastic#42623) [APM] Use rounded bucket sizes for transaction distribution (elastic#42830) [yarn.lock] consistent resolve domain (elastic#42969) [Uptime] [Test] Repurpose unit test assertions to avoid flakiness (elastic#40650) ...
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Aug 14, 2019
* [APM] Fix missing RUM url * Reduce to single conditional branch * Fix test * Add tests for `url.full` and `error.page.url` # Conflicts: # x-pack/legacy/plugins/apm/public/components/app/ErrorGroupDetails/DetailView/StickyErrorProperties.test.tsx # x-pack/legacy/plugins/apm/public/components/app/ErrorGroupDetails/DetailView/StickyErrorProperties.tsx
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Aug 14, 2019
* [APM] Fix missing RUM url * Reduce to single conditional branch * Fix test * Add tests for `url.full` and `error.page.url` # Conflicts: # x-pack/legacy/plugins/apm/public/components/app/ErrorGroupDetails/DetailView/StickyErrorProperties.test.tsx # x-pack/legacy/plugins/apm/public/components/app/ErrorGroupDetails/DetailView/StickyErrorProperties.tsx
sorenlouv
added a commit
that referenced
this pull request
Aug 14, 2019
* [APM] Fix missing RUM url (#42940) * [APM] Fix missing RUM url * Reduce to single conditional branch * Fix test * Add tests for `url.full` and `error.page.url` # Conflicts: # x-pack/legacy/plugins/apm/public/components/app/ErrorGroupDetails/DetailView/StickyErrorProperties.test.tsx # x-pack/legacy/plugins/apm/public/components/app/ErrorGroupDetails/DetailView/StickyErrorProperties.tsx * Fix missing import and `isHandled`
sorenlouv
added a commit
that referenced
this pull request
Aug 14, 2019
* [APM] Fix missing RUM url (#42940) * [APM] Fix missing RUM url * Reduce to single conditional branch * Fix test * Add tests for `url.full` and `error.page.url` # Conflicts: # x-pack/legacy/plugins/apm/public/components/app/ErrorGroupDetails/DetailView/StickyErrorProperties.test.tsx # x-pack/legacy/plugins/apm/public/components/app/ErrorGroupDetails/DetailView/StickyErrorProperties.tsx * Fix missing import and `isHandled` * Fix TransactionLink
Contributor
|
Verified that URL is shown for RUM agents and all others in the trace summary, the transaction properties flyout, and the error summary. For all agents but RUM it also shows in the error summary metadata. 7.3 doesn't show it for RUM either though, so it's not a 7.4 specific regression. @sqren is the fact that it's missing on the metadata tab a bug? |
Member
Author
|
@dgieselaar Thanks for testing this!
No, I don't think so and as you say it's not a regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42930
RUM agent:
Other agents:
