Upgrade elastic/charts to 8.1.6#42518
Merged
markov00 merged 5 commits intoelastic:masterfrom Aug 9, 2019
Merged
Conversation
markov00
added
release_note:skip
markov00
requested review from
angorayc,
cjcenizal,
jgowdyelastic,
justinkambic and
simianhacker
Contributor
💔 Build Failed |
cjcenizal
requested review from
alisonelizabeth
and removed request for
cjcenizal
markov00
changed the title
alisonelizabeth
approved these changes
Aug 5, 2019
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
tested the chart in watcher and did not find any regressions
Contributor
💚 Build Succeeded |
angorayc
approved these changes
Aug 7, 2019
Contributor
angorayc
left a comment
angorayc
left a comment
There was a problem hiding this comment.
Thank you so much for upgrading elastic charts. It works well with SIEM's charts.
simianhacker
approved these changes
Aug 7, 2019
Member
simianhacker
left a comment
simianhacker
left a comment
There was a problem hiding this comment.
_____ _____ _____ _____
/\ \ /\ \ /\ \ /\ \
/::\____\ /::\ \ /::\ \ /::\____\
/:::/ / /::::\ \ \:::\ \ /::::| |
/:::/ / /::::::\ \ \:::\ \ /:::::| |
/:::/ / /:::/\:::\ \ \:::\ \ /::::::| |
/:::/ / /:::/ \:::\ \ \:::\ \ /:::/|::| |
/:::/ / /:::/ \:::\ \ /::::\ \ /:::/ |::| |
/:::/ / /:::/ / \:::\ \ /::::::\ \ /:::/ |::|___|______
/:::/ / /:::/ / \:::\ ___\ /:::/\:::\ \ /:::/ |::::::::\ \
/:::/____/ /:::/____/ ___\:::| | /:::/ \:::\____\/:::/ |:::::::::\____\
\:::\ \ \:::\ \ /\ /:::|____| /:::/ \::/ /\::/ / ~~~~~/:::/ /
\:::\ \ \:::\ /::\ \::/ / /:::/ / \/____/ \/____/ /:::/ /
\:::\ \ \:::\ \:::\ \/____/ /:::/ / /:::/ /
\:::\ \ \:::\ \:::\____\ /:::/ / /:::/ /
\:::\ \ \:::\ /:::/ / \::/ / /:::/ /
\:::\ \ \:::\/:::/ / \/____/ /:::/ /
\:::\ \ \::::::/ / /:::/ /
\:::\____\ \::::/ / /:::/ /
\::/ / \::/____/ \::/ /
\/____/ \/____/
Contributor
💚 Build Succeeded |
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Aug 9, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 9, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (306 commits) [ML] Adding job overrides to the module setup endpoint (elastic#42946) [APM] Fix missing RUM url (elastic#42940) close socket timeouts without message (elastic#42456) Upgrade elastic/charts to 8.1.6 (elastic#42518) [ML] Delete old AngularJS data visualizer and refactor folders (elastic#42962) Add custom formatting for Date Nanos Format (elastic#42445) [Vega] Shim new platform - vega_fn.js -> vega_fn.js , use ExpressionFunction (elastic#42582) add socket.getPeerCertificate to KibanaRequest (elastic#42929) [Automation] ISTANBUL PRESET PATH is not working fine with constructor(private foo) (elastic#42683) [ML] Data frames: Updated stats structure. (elastic#42923) [Code] fixed the issue that the repository can not be deleted in some cases. (elastic#42841) [kbn-es] Support for passing regex value to ES (elastic#42651) Connect to Elasticsearch via SSL when starting kibana with `--ssl` (elastic#42840) Add Elasticsearch SSL support for integration tests (elastic#41765) Fix duplicate fetch in Visualize (elastic#41204) [DOCS] TSVB and Timelion clean up (elastic#42953) [Maps] [File upload] Fix maps geojson upload hanging on index step (elastic#42623) [APM] Use rounded bucket sizes for transaction distribution (elastic#42830) [yarn.lock] consistent resolve domain (elastic#42969) [Uptime] [Test] Repurpose unit test assertions to avoid flakiness (elastic#40650) ...
markov00
added a commit
that referenced
this pull request
Aug 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrade
@elastic/chartsdependency to 8.1.6The breaking change between v7 and v8 is the following from elastic/elastic-charts@99c5e9f:
LineStyle,AreaStyleandBarSeriesStyletypes differs on the optional values. Usingstrokeandfillon the series style now override the computed series color.I've removed the
borderstyle: it is no more available in line/area.I've also removed all the
strokeandfillstyles as this color is already enforced by thecustomSeriesColorprop.If you use the predefined computed colors or if you issue a custom series color, it's better to avoid overriding the style
strokeandfill. If you specify a string for one of these two property it will be used to color that series. If set to a non valid color, like an empty string (as in one case on this PR), that property will be colored with a default color (not sure if it's a black or white).@jgowdyelastic @angorayc @simianhacker @justinkambic @cjcenizal please check if the newly updated chart library change anything in the style of your current charts.
In a near future, I'd also like to add some visual regression tests on every app that use
@elastic/charts. I don't think we have some extensive functional tests for SIEM, uptime, Infra and watcher, so be aware that I will ask you to add some small test there.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately