Fix duplicate fetch in Visualize by lukasolson · Pull Request #41204 · elastic/kibana

lukasolson · 2019-07-15T21:54:08Z

Summary

Fixes the behavior in Visualize that refreshing causes multiple search requests.

Prior to this PR, navigating to Visualize and creating a visualization, then hitting refresh (or modifying the query in some manner) would cause multiple requests to be fired off. This PR fixes it by only firing off a fetch request manually when nothing has changed, and otherwise relying on the behavior of visualizations to cause fetches in response to changes within their state.

Here's a GIF showing the behavior beforehand:

elasticmachine · 2019-07-15T21:54:10Z

Pinging @elastic/kibana-app-arch

elasticmachine · 2019-07-15T23:16:08Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-15T23:48:42Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

lukeelmers · 2019-07-18T22:41:19Z

This overlaps some with this PR from Joe: #41144
// cc @flash1293

Maybe it would be good to combine these efforts since they are solving different parts of the same problem

flash1293 · 2019-07-19T08:47:19Z

@lukeelmers Suggestion: I will exclude the editor from my changes and we solve the disabled filters thing in the editor as a part of this PR.

lukeelmers · 2019-07-19T15:15:59Z

@flash1293 That makes sense to me if it makes sense to @lukasolson :)

lukasolson · 2019-07-23T17:14:01Z

@lukeelmers @flash1293 Sounds good, I'll update this PR.

lukasolson · 2019-07-24T22:50:36Z

This is ready for another review.

elasticmachine · 2019-07-24T23:48:49Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

src/legacy/core_plugins/kibana/public/visualize/editor/editor.js

lukasolson · 2019-07-25T23:55:39Z

After talking with @lizozom, I have a couple of fixes to make on this PR, so hold off on review.

lukasolson · 2019-07-29T23:36:19Z

@lizozom Could you take another look at this PR?

elasticmachine · 2019-07-30T00:34:05Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

src/legacy/core_plugins/kibana/public/visualize/editor/editor.js

lizozom · 2019-07-30T08:14:40Z

src/legacy/core_plugins/kibana/public/visualize/editor/visualization_editor.js

-        $scope.$watchGroup(['timeRange', 'filters'], debounce(() => {
-          $scope.renderFunction();
-        }, 100));
+        $scope.$watch('timeRange', debounce($scope.renderFunction, 100));


Yay.
But will anything else call renderFunction now?

…tches

elasticmachine · 2019-08-03T00:42:02Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ppisljar · 2019-08-05T08:14:16Z

src/legacy/core_plugins/kibana/public/visualize/editor/editor.js

+      (dateRange && !_.isEqual(dateRange, $scope.timeRange))
+    );
+
+    if (query && !_.isEqual(query, $state.query)) $state.query = query;


do we still need this checks here if w have the checks in embedded_visualize_handler ?

We still need to check if nothing has changed in order to manually trigger a fetch, but you're right, we don't need to check before we set them. Fixed in cc10e25.

…o noDuplicateFetches

elasticmachine · 2019-08-05T18:38:19Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-05T22:56:52Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

ppisljar

LGTM, tested in chrome linux

…tches

elasticmachine · 2019-08-08T19:39:53Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

Resolved

* Fix duplicate fetch in Visualize * Don't refetch when disabled filters change * Use query filter fetches observable * Add back in watch on filters * Revert change completely * Update test to include non-disabled filter * Remove unnecessary checks

lukasolson · 2019-08-08T21:27:08Z

7.x (7.4.0): 59c1eb9

…p-metrics-selectall * 'master' of github.com:elastic/kibana: (306 commits) [ML] Adding job overrides to the module setup endpoint (elastic#42946) [APM] Fix missing RUM url (elastic#42940) close socket timeouts without message (elastic#42456) Upgrade elastic/charts to 8.1.6 (elastic#42518) [ML] Delete old AngularJS data visualizer and refactor folders (elastic#42962) Add custom formatting for Date Nanos Format (elastic#42445) [Vega] Shim new platform - vega_fn.js -> vega_fn.js , use ExpressionFunction (elastic#42582) add socket.getPeerCertificate to KibanaRequest (elastic#42929) [Automation] ISTANBUL PRESET PATH is not working fine with constructor(private foo) (elastic#42683) [ML] Data frames: Updated stats structure. (elastic#42923) [Code] fixed the issue that the repository can not be deleted in some cases. (elastic#42841) [kbn-es] Support for passing regex value to ES (elastic#42651) Connect to Elasticsearch via SSL when starting kibana with `--ssl` (elastic#42840) Add Elasticsearch SSL support for integration tests (elastic#41765) Fix duplicate fetch in Visualize (elastic#41204) [DOCS] TSVB and Timelion clean up (elastic#42953) [Maps] [File upload] Fix maps geojson upload hanging on index step (elastic#42623) [APM] Use rounded bucket sizes for transaction distribution (elastic#42830) [yarn.lock] consistent resolve domain (elastic#42969) [Uptime] [Test] Repurpose unit test assertions to avoid flakiness (elastic#40650) ...

lukasolson added release_note:fix v8.0.0 Team:AppArch v7.3.0 v7.4.0 labels Jul 15, 2019

lukasolson requested review from lizozom and ppisljar July 15, 2019 21:54

lukasolson self-assigned this Jul 15, 2019

lukasolson force-pushed the noDuplicateFetches branch from 57cfa68 to dcd2662 Compare July 24, 2019 22:46

lizozom previously requested changes Jul 25, 2019

View reviewed changes

src/legacy/core_plugins/kibana/public/visualize/editor/editor.js Outdated Show resolved Hide resolved

lizozom mentioned this pull request Jul 25, 2019

Filter manager improvements \ bug fixes #41999

Merged

7 tasks

lukasolson removed the v7.3.0 label Jul 25, 2019

lukasolson added 2 commits July 29, 2019 12:17

Fix duplicate fetch in Visualize

11480fb

Don't refetch when disabled filters change

a618a3e

lukasolson force-pushed the noDuplicateFetches branch from dcd2662 to a618a3e Compare July 29, 2019 23:33

Use query filter fetches observable

e48cbee

lukasolson requested a review from lizozom July 29, 2019 23:36

lizozom reviewed Jul 30, 2019

View reviewed changes

lukasolson added 3 commits August 2, 2019 16:36

Add back in watch on filters

5b2f087

Revert change completely

4518608

Merge branch 'master' of github.com:elastic/kibana into noDuplicateFe…

714bebd

…tches

lukasolson requested a review from lizozom August 2, 2019 23:49

ppisljar reviewed Aug 5, 2019

View reviewed changes

lukasolson added 2 commits August 5, 2019 10:08

Update test to include non-disabled filter

1354120

Merge branch 'noDuplicateFetches' of github.com:lukasolson/kibana int…

ec50365

…o noDuplicateFetches

lukasolson added 2 commits August 5, 2019 14:30

Merge branch 'master' into noDuplicateFetches

6659289

Remove unnecessary checks

cc10e25

ppisljar approved these changes Aug 7, 2019

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into noDuplicateFe…

27753c2

…tches

lukasolson merged commit fc1ea0b into elastic:master Aug 8, 2019

lukasolson mentioned this pull request Sep 22, 2019

Inflight _msearch requests are retried if visualizations are resized on dashboard #27478

Closed

lukasolson deleted the noDuplicateFetches branch December 2, 2019 22:35

Conversation

lukasolson commented Jul 15, 2019

Summary

Uh oh!

elasticmachine commented Jul 15, 2019

Uh oh!

elasticmachine commented Jul 15, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 15, 2019

💔 Build Failed

Uh oh!

lukeelmers commented Jul 18, 2019

Uh oh!

flash1293 commented Jul 19, 2019

Uh oh!

lukeelmers commented Jul 19, 2019

Uh oh!

lukasolson commented Jul 23, 2019

Uh oh!

lukasolson commented Jul 24, 2019

Uh oh!

elasticmachine commented Jul 24, 2019

💔 Build Failed

Uh oh!

Uh oh!

lukasolson commented Jul 25, 2019

Uh oh!

lukasolson commented Jul 29, 2019

Uh oh!

elasticmachine commented Jul 30, 2019

💔 Build Failed

Uh oh!

Uh oh!

lizozom Jul 30, 2019

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Aug 3, 2019

💔 Build Failed

Uh oh!

ppisljar Aug 5, 2019

Choose a reason for hiding this comment

Uh oh!

lukasolson Aug 5, 2019

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Aug 5, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Aug 5, 2019

💚 Build Succeeded

Uh oh!

ppisljar left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Aug 8, 2019

💚 Build Succeeded

Uh oh!

lukasolson commented Aug 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants