[Automation] ISTANBUL PRESET PATH is not working fine with constructor(private foo)#42683
Merged
alexwizp merged 3 commits intoelastic:masterfrom Aug 9, 2019
Merged
Conversation
Contributor
Author
|
@dmlemeshko could you please confirm that with these changes tests work fine |
Contributor
|
I can confirm that the fix helps dashboard functional tests to pass in #40512 |
Contributor
💚 Build Succeeded |
dmlemeshko
approved these changes
Aug 6, 2019
Contributor
dmlemeshko
left a comment
dmlemeshko
left a comment
There was a problem hiding this comment.
Thank you for the help!
alexwizp
added
Feature:Embedding
Contributor
|
Pinging @elastic/kibana-app-arch |
lukeelmers
requested changes
Aug 6, 2019
Contributor
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
Looks like this one wasn't updated to remove this:
return (
this.visTypes.byName[JSON.parse(savedObject.attributes.visState).type].icon ||
'visualizeApp'
);
alexwizp
force-pushed
the
origin/functional-code-coverage-fix
branch
from
d5144ff to
c7bc512
Compare
Contributor
💚 Build Succeeded |
…onal-code-coverage-fix
Contributor
💚 Build Succeeded |
…onal-code-coverage-fix
Contributor
💚 Build Succeeded |
lukeelmers
approved these changes
Aug 8, 2019
Contributor
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
The code changes here LGTM, but I don't know anything about how this fixes issues with istanbul, so I'll defer to @spalger on that.
This also feels like the type of thing that would be good to enforce via linter rules, if the issue is simply how the constructor is written.
Contributor
I also was thinking about it. @spalger what do you think? |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Aug 9, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 9, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (306 commits) [ML] Adding job overrides to the module setup endpoint (elastic#42946) [APM] Fix missing RUM url (elastic#42940) close socket timeouts without message (elastic#42456) Upgrade elastic/charts to 8.1.6 (elastic#42518) [ML] Delete old AngularJS data visualizer and refactor folders (elastic#42962) Add custom formatting for Date Nanos Format (elastic#42445) [Vega] Shim new platform - vega_fn.js -> vega_fn.js , use ExpressionFunction (elastic#42582) add socket.getPeerCertificate to KibanaRequest (elastic#42929) [Automation] ISTANBUL PRESET PATH is not working fine with constructor(private foo) (elastic#42683) [ML] Data frames: Updated stats structure. (elastic#42923) [Code] fixed the issue that the repository can not be deleted in some cases. (elastic#42841) [kbn-es] Support for passing regex value to ES (elastic#42651) Connect to Elasticsearch via SSL when starting kibana with `--ssl` (elastic#42840) Add Elasticsearch SSL support for integration tests (elastic#41765) Fix duplicate fetch in Visualize (elastic#41204) [DOCS] TSVB and Timelion clean up (elastic#42953) [Maps] [File upload] Fix maps geojson upload hanging on index step (elastic#42623) [APM] Use rounded bucket sizes for transaction distribution (elastic#42830) [yarn.lock] consistent resolve domain (elastic#42969) [Uptime] [Test] Repurpose unit test assertions to avoid flakiness (elastic#40650) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Automation] ISTANBUL PRESET PATH is not working fine with constructor(private foo)
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers