[ui:karma] Add New Platform mocks for data plugin#42261
Merged
alexwizp merged 1 commit intoelastic:masterfrom Jul 31, 2019
Merged
[ui:karma] Add New Platform mocks for data plugin#42261alexwizp merged 1 commit intoelastic:masterfrom
alexwizp merged 1 commit intoelastic:masterfrom
Conversation
7 tasks
alexwizp
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-app-arch |
alexwizp
force-pushed
the
mock-new-platform
branch
from
bbbb8ec to
36e6234
Compare
alexwizp
changed the title
Contributor
💚 Build Succeeded |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
lukeelmers
approved these changes
Jul 30, 2019
Contributor
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
Code LGTM. I've opened #42302 to add details about this to the migration guide; please take a look and comment there if I'm missing anything. :)
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jul 31, 2019
alexwizp
added a commit
that referenced
this pull request
Jul 31, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 31, 2019
…-or-edit-existing-rollup-job * 'master' of github.com:elastic/kibana: (114 commits) [ML] Fixing empty index pattern list (elastic#42299) [Markdown] Shim new platform - cleanup plugin (elastic#41760) [Code] Enable hierarchicalDocumentSymbolSupport for java language server (elastic#42233) Add New Platform mocks for data plugin (elastic#42261) Http server route handler implementation (elastic#41894) [SR] Allow custom index pattern to be used instead of selectable list when choosing indices to restore (elastic#41534) [Code] distributed Code abstraction (elastic#41374) [SIEM] Sets page titles to the current page you are on (elastic#42157) Saved Objects export API stable type order (elastic#42310) cancellation of interpreter execution (elastic#40238) [SIEM] Fixes a crash when Machine Learning influencers is an undefined value (elastic#42198) Changed the job to work with a dedicated index (elastic#42297) FTR: fix testSubjects.missingOrFail (elastic#42290) Increase retry timeout to prevent flaky tests (elastic#42291) Spaces - make space a hidden saved object type (elastic#41688) Allow applications to register feature privileges which are excluded from the base privileges (elastic#41300) Disable flaky log column reorder test (elastic#42285) Fixing add element in element reducer (elastic#42276) Fix infinite loop (elastic#42228) [Maps][File upload] Remove geojson deep clone logic, handle on maps side (elastic#41835) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev docs
Summary
Exception during execution of HeadlessChrome tests based on karma. -> adding mocks for the data plugin
After migration some of our visualizations to the new platform we faced with an issue in these types of tests. Karma tests before starting execute all registered 'hacks' methods. It happens from the following place: legacy\ui\public\test_harness\test_harness.js
Shimming our legacy visualization to the new platform require to use the 'hacks' function for initializing. It means that all nested dependencies should be mocked like e.g. data plugin.
Related PR:
#42261
#41760