[skip-ci] Add note about karma mocks for new platform services.#42302
Merged
lukeelmers merged 2 commits intoelastic:masterfrom Aug 5, 2019
Merged
[skip-ci] Add note about karma mocks for new platform services.#42302lukeelmers merged 2 commits intoelastic:masterfrom
lukeelmers merged 2 commits intoelastic:masterfrom
Conversation
lukeelmers
added
review
Team:Core
Contributor
|
Pinging @elastic/kibana-platform |
Contributor
|
Pinging @elastic/kibana-app-arch |
streamich
approved these changes
Jul 31, 2019
lizozom
reviewed
Jul 31, 2019
joshdover
approved these changes
Aug 1, 2019
lukeelmers
force-pushed
the
docs/migration-tests
branch
from
eb28409 to
5dfcc3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #42261 we are adding some mocks to
ui/new_platformfor karma tests. This PR updates theMIGRATION.mdsection on mocking services in the new platform to include details about this, as well as adding missing info aboutjest.mock('ui/new_platform');