Increase alerting tests retry timeout to prevent flakiness#42291
Merged
mikecote merged 1 commit intoelastic:masterfrom Jul 30, 2019
Merged
Increase alerting tests retry timeout to prevent flakiness#42291mikecote merged 1 commit intoelastic:masterfrom
mikecote merged 1 commit intoelastic:masterfrom
Conversation
mikecote
added
review
Feature:Alerting
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/kibana-stack-services |
mikecote
changed the title
pmuellr
approved these changes
Jul 30, 2019
Contributor
pmuellr
left a comment
pmuellr
left a comment
There was a problem hiding this comment.
LGTM
Not worth changing now, but probably having these as a constant at the top of the file, or some testing constants module, would be a useful way to deal with these.
Contributor
💚 Build Succeeded |
Contributor
Author
|
Backport will be done with #42255. |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Jul 30, 2019
mikecote
added a commit
that referenced
this pull request
Jul 30, 2019
… (#42255) * Implement wanted error handling for alerting and actions (#41917) * Implement wanted error handling * Cleanup * Add retry logic to actions * Leverage startedAt from task manager * Fix broken jest tests * Add missing unit test * Add unit tests for getRetry * Add test for rate limit * Remove fake timers * Don't retry errors by default for actions unless the proper result format is returned with status: error * Don't retry unless attribute specified * Fix tests * Increase retry timeout to prevent flaky tests (#42291)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 31, 2019
…-or-edit-existing-rollup-job * 'master' of github.com:elastic/kibana: (114 commits) [ML] Fixing empty index pattern list (elastic#42299) [Markdown] Shim new platform - cleanup plugin (elastic#41760) [Code] Enable hierarchicalDocumentSymbolSupport for java language server (elastic#42233) Add New Platform mocks for data plugin (elastic#42261) Http server route handler implementation (elastic#41894) [SR] Allow custom index pattern to be used instead of selectable list when choosing indices to restore (elastic#41534) [Code] distributed Code abstraction (elastic#41374) [SIEM] Sets page titles to the current page you are on (elastic#42157) Saved Objects export API stable type order (elastic#42310) cancellation of interpreter execution (elastic#40238) [SIEM] Fixes a crash when Machine Learning influencers is an undefined value (elastic#42198) Changed the job to work with a dedicated index (elastic#42297) FTR: fix testSubjects.missingOrFail (elastic#42290) Increase retry timeout to prevent flaky tests (elastic#42291) Spaces - make space a hidden saved object type (elastic#41688) Allow applications to register feature privileges which are excluded from the base privileges (elastic#41300) Disable flaky log column reorder test (elastic#42285) Fixing add element in element reducer (elastic#42276) Fix infinite loop (elastic#42228) [Maps][File upload] Remove geojson deep clone logic, handle on maps side (elastic#41835) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42263.
The
retry.retryForTimewas set too short for tests using task manager in alerting causing tests to sometimes fail. This PR increases the timeout to ensure they have enough time to finish.