You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@thompsongl@chandlerprall Set this up so that I could fix the K6 theming issues I knew we'd need to fix. Looks like some changes will need to be done to the Jest tests due to the accordion changes. Left this in draft mode for now.
For outside review pings. This is an EUI upgrade and comes with the usual snapshot updates. This is a major version change for EUI, but the only change was the removal of the EuiSeriesCharts components which are no longer in use in Kibana so there's nothing to review there. I made some small changes to some of the consuming apps that were still calling the k6 theme json, which we also removed. We also updated the tests where appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates to the latest EUI, which required changes to Kibana mostly around removal of the K6 themes.
13.0.0EuiSuggestItemcomponent (#2090)EuiSearchBar(#2140)transitionutility services to help create timeouts that account for CSS transition durations and delays (#2136)EuiFlexGroupdependency fromEuiAccordion(#2143)prettyDurationandcommonDurationRangesfor pretty printing date ranges outsideEuiSuperDatePicker(#2132)Bug fixes
EuiComboBox's padding on the right (#2135)EuiAccordionto correctly account for changing computed height of child elements (#2136)EuiFlyoutsizing (#2125)Breaking changes
EuiSeriesChartand related components. Please look to Elastic Charts for a replacement. (#2135)eui_k6_themerelated Sass and JSON files (#2135)EuiForm,EuiCallOut, andEuiRangecomponents (#2135)Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This includes a feature addition or change that requires a release note and was labeled appropriately