Expose prettyDuration and commonDurationRanges#2132
Merged
chandlerprall merged 12 commits intoelastic:masterfrom Jul 18, 2019
Merged
Expose prettyDuration and commonDurationRanges#2132chandlerprall merged 12 commits intoelastic:masterfrom
chandlerprall merged 12 commits intoelastic:masterfrom
Conversation
nreese
approved these changes
Jul 17, 2019
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
lgtm
code review, reviewed EUI doc changes in chrome
| quickRanges: [], | ||
| dateFormat: 'MMMM Do YYYY, HH:mm:ss.SSS', | ||
| }, | ||
| { |
Contributor
There was a problem hiding this comment.
Same example as above. Can remove this copy
Contributor
Author
There was a problem hiding this comment.
The dateFormat is altered slightly in the second example.
thompsongl
suggested changes
Jul 17, 2019
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Just the one update. Looks good otherwise
snide
reviewed
Jul 17, 2019
Co-Authored-By: dave.snider@gmail.com <dave.snider@gmail.com>
cchaos
suggested changes
Jul 17, 2019
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
There are several console errors that need fixing
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
Contributor
Author
|
Thanks @cchaos! Took your suggestions and cleaned up the console warnings. |
cchaos
approved these changes
Jul 17, 2019
thompsongl
approved these changes
Jul 17, 2019
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
LGTM
The CI failure is just a lint error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2118. Exports
prettyDurationandcommonDurationRangesfor use outside the super date picker. I wanted to pull the functionality fromsuper_date_pickerand intoservices, but it's so connected I decided to leave it in place.Added documentation for prettyDuration.
Checklist
This was checked in mobileThis was checked in IE11This was checked in dark modeAny props added have proper autodocsThis was checked for breaking changes and labeled appropriatelyJest tests were updated or added to match the most common scenariosThis was checked against keyboard-only and screenreader scenariosThis required updates to Framer X components