Allow nested EuiAccordions#2136
Merged
thompsongl merged 10 commits intoelastic:masterfrom Jul 19, 2019
Merged
Conversation
chandlerprall
suggested changes
Jul 18, 2019
Co-Authored-By: Chandler Prall <chandler.prall@gmail.com>
Contributor
Author
|
As far as I can tell, jsdom doesn't allow for setting the full gamut of style properties. |
chandlerprall
approved these changes
Jul 19, 2019
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Played with some testing ideas, it would be far more work than worth it to test for a regression here.
LGTM; pulled & tested locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2129, in which an
EuiAccordionwith anEuiAccordionas a child element does not account for height change when the nested accordion opens.More generally,
EuiAccordionwill now account for more than just nested instances, but anystylemutation on children elements.The solution involves abstracting a transition delay/duration service out of
EuiPopover. These services work withMutationObserverto sum transition timings and run a callback usingrequestAnimationFrameChecklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] This was checked for breaking changes and labeled appropriately- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components