[DEPRECATIONS] Remove EUI Charts, Sass deprecations#2108
[DEPRECATIONS] Remove EUI Charts, Sass deprecations#2108snide merged 9 commits intoelastic:masterfrom
Conversation
|
Maybe we should also merge this on a fresh master (after a release) so it doesn't get mixed up with other bug fixes etc.. |
I think I'll have to keep this up to date with rebases for a week or so. We can't merge till @simianhacker is done in kibana. I just wanted to get it going to provide more imminent awareness of its arrival :) In fact, we should let @elastic/cloud-ui know and make sure they're not using the charts either.
Yep. I'll take care of it. |
|
Yep, we're not using any charts from EUI |
|
I know this is still in draft, but we'll want to make sure to run |
Yep, purposely didn't run it in the draft since I can better watch when i need to rebase (yarn.lock changes a bunch / will always conflict) I'll add some todos as a reminder though. |
|
Will these charts be replaced with any new ones, or are we removing the concept of EUI charts entirely? |
|
@cristina-eleonora The EUI charts are being deprecated in favor of using elastic-charts which we will be adding a few examples and documentation to EUI as well. |
|
Awesome, thanks @cchaos ! |
|
Thanks to @simianhacker and elastic/kibana#41262 we're ready to merge this into EUI. I updated the This is ready for review. |
pugnascotia
left a comment
There was a problem hiding this comment.
Looks fine to me. I can explicitly test it against Cloud if you like, though I don't believe we're using anything that the PR is removing.
thompsongl
left a comment
There was a problem hiding this comment.
Local build and docs looks good.
Will have to wait to test it in Kibana, but I agree with @chandlerprall that this is a breaking change.
|
@chandlerprall @thompsongl. Good point. Updated. |
Summary
Following our deprecation schedule #1469 this removes the Eui Charts set of components and docs. I did the following
experimentalfolders and code (since we don't use it anymore)react-visfrom our depsk6theme and dist outputWe can't merge this till @simianhacker removes
EuiSeriesChartusage in the infra-ui, but he's promised soonish there. Until that's ready I'll leave this in draft mode.Checklist
This was checked in mobileThis was checked in IE11Any props added have proper autodocsDocumentation examples were addedThis was checked against keyboard-only and screenreader scenariosThis required updates to Framer X components