Replace tsc compilation with transpile with babel on kbn plugin helpers for typescript#36769
Conversation
|
Pinging @elastic/kibana-operations |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
…ils. chore(NA): change globs definitions to match the overall convention.
|
That would fail until #36815 get merged |
This comment has been minimized.
This comment has been minimized.
|
jenkins test this |
💚 Build Succeeded |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
…rs for typescript (elastic#36769) * chore(NA): add transpile with babel the typescript files on xpack when build. * chore(NA): fix the globs for public folders inside server paths * docs(NA): add comments to explain globs. * chore(NA): use pipeline instead of async pipeline promise from dev utils. chore(NA): change globs definitions to match the overall convention. * chore(NA): apply documented way to use stream pipeline. * chore(NA): exclude test files from the build transpilation. * chore(NA): add ignore for eslint complexity warning * chore(na): fix bad added type files. * fix(NA): unused type exports
|
7.x: 60f852b |
…rs for typescript (#36769) (#37642) * chore(NA): add transpile with babel the typescript files on xpack when build. * chore(NA): fix the globs for public folders inside server paths * docs(NA): add comments to explain globs. * chore(NA): use pipeline instead of async pipeline promise from dev utils. chore(NA): change globs definitions to match the overall convention. * chore(NA): apply documented way to use stream pipeline. * chore(NA): exclude test files from the build transpilation. * chore(NA): add ignore for eslint complexity warning * chore(na): fix bad added type files. * fix(NA): unused type exports
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "@babel/core": "^7.4.4", | ||
| "@kbn/babel-preset": "1.0.0", |
There was a problem hiding this comment.
note: with this change on the latest master I'm getting error Couldn't find package "@kbn/babel-preset@1.0.0" required by "@kbn/plugin-helpers@link:../../kibana/packages/kbn-plugin-helpers" on the "npm" registry. on yarn kbn bootstrap (right after yarn kbn clean). Am I doing something wrong? :)
There was a problem hiding this comment.
That package is still at 1.0.0 locally, and it works for me, but we've been doing a fair amount of upgrades lately and I've had to wipe out my node_modules directory more frequently than desired because yarn isn't able to properly patch the directory correctly.
There was a problem hiding this comment.
That's weird, yarn kbn clean should remove node_modules, but that still doesn't help. Anyway, if it becomes annoying, I'll try to investigate and give you folks more details :)
4 participants
Closes #35373
It replaces the call to the typescript compiler with a transpile with babel function (split by client and server code) everytime we found a tsconfig file in a kbn plugin helpers build.