allow x-pack plugins to import core service mocks in tests#36771
Merged
mshustov merged 1 commit intoelastic:masterfrom May 21, 2019
Merged
allow x-pack plugins to import core service mocks in tests#36771mshustov merged 1 commit intoelastic:masterfrom
mshustov merged 1 commit intoelastic:masterfrom
Conversation
using relative imports from x-pack to kibana core doesn't work atm. although we cannot use absolute imports, because jest cannot match them internally.
Contributor
|
Pinging @elastic/kibana-operations |
Contributor
💚 Build Succeeded |
jbudz
approved these changes
May 21, 2019
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
May 21, 2019
using relative imports from x-pack to kibana core doesn't work atm. although we cannot use absolute imports, because jest cannot match them internally.
mshustov
added a commit
that referenced
this pull request
May 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
using relative imports from x-pack to kibana core doesn't work until #36769 merged
although we cannot use absolute imports in tests, because jest cannot match them internally.
logs https://kibana-ci.elastic.co/job/elastic+kibana+pull-request/14105/JOB=x-pack-intake,node=immutable/console
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately