Switching from public/private to external/internal APIs#36815
Merged
kobelb merged 2 commits intoelastic:masterfrom May 22, 2019
Merged
Switching from public/private to external/internal APIs#36815kobelb merged 2 commits intoelastic:masterfrom
kobelb merged 2 commits intoelastic:masterfrom
Conversation
We use the public folder a lot of other places to denote files which should be exposed client-side. Using folders names public was causing issues with some of the operations team's tooling, so we're renaming these.
kobelb
added
the
Team:Security
Contributor
|
Pinging @elastic/kibana-security |
kobelb
added
chore
release_note:skip
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
May 22, 2019
* Switching from public/private to external/internal APIs We use the public folder a lot of other places to denote files which should be exposed client-side. Using folders names public was causing issues with some of the operations team's tooling, so we're renaming these. * Fixing forgotten import in test
kobelb
added a commit
that referenced
this pull request
May 24, 2019
) * Switching from public/private to external/internal APIs We use the public folder a lot of other places to denote files which should be exposed client-side. Using folders names public was causing issues with some of the operations team's tooling, so we're renaming these. * Fixing forgotten import in test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the public folder a lot of other places to denote files which
should be exposed client-side. Using folders named public was causing
issues with some of the operations team's tooling, so we're renaming
these.