Remove ts typecheck from build#37190
Conversation
|
Pinging @elastic/kibana-operations |
💚 Build Succeeded |
|
I personally don’t think there’s any benefit to type checking in the build and as an independent task in CI, and I personally like that they’re separate tasks. |
|
So are you just in favor on removing it from the build distributable tasks? By my side I support that decision! |
|
@spalger as discussed I've removed the typecheck from the build process itself |
💔 Build Failed |
|
the build would fail until #36769 is merged |
|
@elastic/kibana-platform do any of you think this is a bad idea? I didn't realize that we were even doing it, and I'm personally a fan of avoiding duplicate work if we can avoid it. (we run the type_check script in the intake job, no reason to run it on every build) |
|
Just to give more context, in the first place we were building typescript into this task. When moving from tsc to babel7 instead of deleting that task I've refactoring it to apply a typecheck. But revisiting it right now it makes more sense to me to just remove it. |
mistic
added
release_note:skip
💚 Build Succeeded |
|
7.x: e481029 |
* chore(NA): add typecheck for x-pack * chore(NA): remove typescript typecheck task from build
3 participants
Currently we are not typechecking x-pack typescript code when building, and that PR fixes it.
However one thing that occurred to me was that during our CI we will run a typecheck anyway. While I think it could be a good idea keep checking it in both places (CI + build) I'm also okay with removing it from our build. What are your ideas here @spalger ? Let's keep that PR to fix the typecheck and run it in both places or update the PR to remove the typecheck step from the build?