[9.4] [EDR Workflows] Unify artifacts empty state buttons (#264389)#264931
Merged
Conversation
## Summary As now we're adding a new secondary button for artifact _Import_ to the empty state pages of Artifact page and Policy details page, this PR aims to unify the UI a bit. - [x] 'Add artifact' button and 'Import artifacts' empty button are now vertically aligned on **Artifacts** page's empty state <img width="600" alt="artifacts" src="https://github.com/user-attachments/assets/ccd94868-8521-4ffa-81f8-d2fb8016d4cb" /> - [x] Same vertical alignment on **Policy details** page's artifact tabs <img width="600" alt="policy details" src="https://github.com/user-attachments/assets/e605b047-d889-46e6-82bf-b336d7273cda" /> - [x] When arriving to **Artifacts** page from **Policy details** page, the (now) 3rd button is changed to a simple link <img width="600" alt="bakc" src="https://github.com/user-attachments/assets/a6fe0f98-5088-4e76-a111-485261c87da1" /> - [x] On **Policy details** page's 'artifacts exist, but they are not assigned' empty state the old 'Manage artifacts' link is changed to an empty button to harmonize with the new Import button <img width="600" alt="manage" src="https://github.com/user-attachments/assets/8d20e532-ca97-41dd-b201-57624457df91" /> ## Testing To see the Import button, enable the following feature flag: ``` xpack.securitySolution.enableExperimental: - endpointExceptionsMovedUnderManagement ``` (cherry picked from commit c5cbc5f)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.4:Questions ?
Please refer to the Backport tool documentation