[Streams] Move helpers and format_size_unit to utils folder#262550
Merged
SoniaSanzV merged 4 commits intoelastic:mainfrom Apr 14, 2026
Merged
[Streams] Move helpers and format_size_unit to utils folder#262550SoniaSanzV merged 4 commits intoelastic:mainfrom
SoniaSanzV merged 4 commits intoelastic:mainfrom
Conversation
SoniaSanzV
added
Team:Kibana Management
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
damian-polewski
approved these changes
Apr 13, 2026
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
History
cc @SoniaSanzV |
thomheymann
approved these changes
Apr 14, 2026
tonyghiani
approved these changes
Apr 14, 2026
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Apr 14, 2026
* commit '11ed3645c5ededae2a6e29f2a79b31f52208b441': (157 commits) remove sync register uiAction methods (elastic#254590) [performance] Apply minimal auth to the search route (elastic#257497) [ES|QL] Reports correctly the controls server side errors (elastic#263020) [SecuritySolution][Navigation] Enable classic nav updates (elastic#262358) [Inference] Use pretty name and logo on feature settings page (elastic#262531) [Security Solution] fix AT-AB cypress test (elastic#262991) [SigEvents] Seed sigevents env script (elastic#261172) Adjust conditions for validating no refetch for expanded row (elastic#262978) [Agent Builder] update copy for the announcement modal (elastic#263034) [Search] Hide index management links for users without privileges (elastic#262627) Simplify OAS schema for GET `/api/spaces/space` query params (elastic#260831) Fix fleet output OAS regressions: SSL type explosion and Kafka union wrappers (elastic#260842) [Dashboards in chat] fix agent confusing the axes in a horizontal chat (elastic#263064) [One Workflow] Add alert state checkbox UI for workflow connector (elastic#259770) [One Workflow] Deprecate legacy Cases step types in workflow authoring (elastic#262070) skip failing test suite (elastic#248090) fix flaky test: MonitorDetails filter apply button not enabled (elastic#260788) fix: propagate AbortSignal to executeAsReasoningAgent for task cancellation (elastic#262811) [Security Solution][Alert KPI] Fix white space bug in alert KPIs (elastic#260803) [Streams] Move helpers and format_size_unit to utils folder (elastic#262550) ... # Conflicts: # x-pack/platform/plugins/shared/dashboard_agent/public/attachment_types/canvas_integration/dashboard_canvas_content.test.tsx # x-pack/platform/plugins/shared/dashboard_agent/public/attachment_types/canvas_integration/dashboard_canvas_content.tsx # x-pack/platform/plugins/shared/dashboard_agent/public/attachment_types/canvas_integration/use_register_canvas_action_buttons.ts # x-pack/platform/plugins/shared/dashboard_agent/public/attachment_types/index.test.tsx # x-pack/platform/plugins/shared/dashboard_agent/public/attachment_types/index.tsx
SoniaSanzV
added a commit
that referenced
this pull request
Apr 20, 2026
## Summary - Transfer ownership of Streams_app retention-related to Kibana Management via CODEOWNERS (`data_management/stream_detail_lifecycle` folder). Shared methods already moved in #262550 - Transfer ownership (review routing) of Streams retention-related backend areas to Kibana Management via CODEOWNERS: internal failure-store routes and library, internal ILM lifecycle routes, and `ilm_policies` / `ilm_phases` (+ tests). - Isolate failure-store route support code in `server/lib/streams/failure_store/` so that surface is easier to own and move later without dragging unrelated `stream_crud` code. - No intentional change to product behavior or public APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stream_detail_lifecycle/helpers). That coupling makes it harder to treat retention-tab code as owned by one surface and to migrate that tab toward Kibana Stack Management later.x-pack/platform/plugins/shared/streams_app/public/util/: duration parsing (parse_duration.ts), ILM phase helpers (ilm_policy_phases.ts), and time/size labeling (format_size_units.ts). The old generichelpers.tsname was replaced with module names that match what they export.util/instead of lifecycle-local helpers, so retention-tab code can be isolated and transferred without dragging unrelated paths.Test plan
util/parse_duration,util/ilm_policy_phases, andutil/format_size_units(existing coverage moved/split with the files).