Skip to content

Adjust conditions for validating no refetch for expanded row#262978

Merged
eokoneyo merged 2 commits intoelastic:mainfrom
eokoneyo:chore/resolve-260953
Apr 14, 2026
Merged

Adjust conditions for validating no refetch for expanded row#262978
eokoneyo merged 2 commits intoelastic:mainfrom
eokoneyo:chore/resolve-260953

Conversation

@eokoneyo
Copy link
Copy Markdown
Contributor

@eokoneyo eokoneyo commented Apr 14, 2026 •
edited
Loading

Summary

Closes #260953

Makes adjustment to our test in a bid to make test outcomes much more predictable.

@eokoneyo eokoneyo self-assigned this Apr 14, 2026
@eokoneyo eokoneyo added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Apr 14, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 14, 2026

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#11590

[✅] src/platform/test/functional/apps/discover/cascade_layout/config.ts: 25/25 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 14, 2026

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#11594

[✅] src/platform/test/functional/apps/discover/cascade_layout/config.ts: 50/50 tests passed.

see run history

@eokoneyo eokoneyo marked this pull request as ready for review April 14, 2026 11:14
@eokoneyo eokoneyo requested a review from a team as a code owner April 14, 2026 11:14
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 14, 2026

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@eokoneyo eokoneyo added the backport:skip This PR does not require backporting label Apr 14, 2026
@eokoneyo
Copy link
Copy Markdown
Contributor Author

eokoneyo commented Apr 14, 2026

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 14, 2026

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @eokoneyo

@eokoneyo eokoneyo merged commit 2c68bc7 into elastic:main Apr 14, 2026
17 checks passed
@eokoneyo eokoneyo deleted the chore/resolve-260953 branch April 14, 2026 14:20
@eokoneyo eokoneyo mentioned this pull request Apr 14, 2026
Closed
mbondyra added a commit to mbondyra/kibana that referenced this pull request Apr 14, 2026
@mbondyra
Merge commit '11ed3645c5ededae2a6e29f2a79b31f52208b441' into pr/262450
bfea6d9 
* commit '11ed3645c5ededae2a6e29f2a79b31f52208b441': (157 commits)
  remove sync register uiAction methods (elastic#254590)
  [performance] Apply minimal auth to the search route (elastic#257497)
  [ES|QL] Reports correctly the controls server side errors (elastic#263020)
  [SecuritySolution][Navigation] Enable classic nav updates (elastic#262358)
  [Inference] Use pretty name and logo on feature settings page (elastic#262531)
  [Security Solution] fix AT-AB cypress test (elastic#262991)
  [SigEvents] Seed sigevents env script (elastic#261172)
  Adjust conditions for validating no refetch for expanded row (elastic#262978)
  [Agent Builder] update copy for the announcement modal (elastic#263034)
  [Search] Hide index management links for users without privileges (elastic#262627)
  Simplify OAS schema for GET `/api/spaces/space` query params (elastic#260831)
  Fix fleet output OAS regressions: SSL type explosion and Kafka union wrappers (elastic#260842)
  [Dashboards in chat] fix agent confusing the axes in a horizontal chat (elastic#263064)
  [One Workflow] Add alert state checkbox UI for workflow connector (elastic#259770)
  [One Workflow] Deprecate legacy Cases step types in workflow authoring (elastic#262070)
  skip failing test suite (elastic#248090)
  fix flaky test: MonitorDetails filter apply button not enabled (elastic#260788)
  fix: propagate AbortSignal to executeAsReasoningAgent for task cancellation (elastic#262811)
  [Security Solution][Alert KPI] Fix white space bug in alert KPIs (elastic#260803)
  [Streams] Move helpers and format_size_unit to utils folder (elastic#262550)
  ...

# Conflicts:
#	x-pack/platform/plugins/shared/dashboard_agent/public/attachment_types/canvas_integration/dashboard_canvas_content.test.tsx
#	x-pack/platform/plugins/shared/dashboard_agent/public/attachment_types/canvas_integration/dashboard_canvas_content.tsx
#	x-pack/platform/plugins/shared/dashboard_agent/public/attachment_types/canvas_integration/use_register_canvas_action_buttons.ts
#	x-pack/platform/plugins/shared/dashboard_agent/public/attachment_types/index.test.tsx
#	x-pack/platform/plugins/shared/dashboard_agent/public/attachment_types/index.tsx
@kertal
Copy link
Copy Markdown
Member

kertal commented Apr 17, 2026

@eokoneyo I think you should backport this, thx

@eokoneyo eokoneyo mentioned this pull request Apr 20, 2026
Merged
@eokoneyo
Copy link
Copy Markdown
Contributor Author

eokoneyo commented Apr 20, 2026

💚 All backports created successfully

Status Branch Result
✅ 9.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@eokoneyo
Copy link
Copy Markdown
Contributor Author

eokoneyo commented Apr 20, 2026

@eokoneyo I think you should backport this, thx

Resolved here #264483

eokoneyo added a commit that referenced this pull request Apr 21, 2026
@eokoneyo @elasticmachine
[9.4] Adjust conditions for validating no refetch for expanded row (#…
54790b8 
…262978) (#264483)

# Backport

This will backport the following commits from `main` to `9.4`:
- [Adjust conditions for validating no refetch for expanded row
(#262978)](#262978)

<!--- Backport version: 11.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Eyo O.
Eyo","email":"7893459+eokoneyo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-04-14T14:20:20Z","message":"Adjust
conditions for validating no refetch for expanded row (#262978)\n\n##
Summary\n\nCloses
https://github.com/elastic/kibana/issues/260953\n\nMakes adjustment to
our test in a bid to make test outcomes much
more\npredictable.\n\n\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"2c68bc7d9428db925548fcf2dafa08f378ce6a06","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:DataDiscovery","v9.5.0"],"title":"Adjust
conditions for validating no refetch for expanded
row","number":262978,"url":"https://github.com/elastic/kibana/pull/262978","mergeCommit":{"message":"Adjust
conditions for validating no refetch for expanded row (#262978)\n\n##
Summary\n\nCloses
https://github.com/elastic/kibana/issues/260953\n\nMakes adjustment to
our test in a bid to make test outcomes much
more\npredictable.\n\n\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"2c68bc7d9428db925548fcf2dafa08f378ce6a06"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/262978","number":262978,"mergeCommit":{"message":"Adjust
conditions for validating no refetch for expanded row (#262978)\n\n##
Summary\n\nCloses
https://github.com/elastic/kibana/issues/260953\n\nMakes adjustment to
our test in a bid to make test outcomes much
more\npredictable.\n\n\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"2c68bc7d9428db925548fcf2dafa08f378ce6a06"}}]}]
BACKPORT-->

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexGPlay AlexGPlay AlexGPlay approved these changes

Assignees

@eokoneyo eokoneyo

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.4.0 v9.5.0

Projects

None yet

Milestone

No milestone

5 participants

@eokoneyo @kibanamachine @elasticmachine @kertal @AlexGPlay