remove sync register uiAction methods by nreese · Pull Request #254590 · elastic/kibana

nreese · 2026-02-23T20:18:15Z

#205512 added 'async' registry methods. This PR completes this work and removes 'sync' registry methods and all remaining usages of 'sync ' methods.

async registries

avoid async imports during plugin setup/start
prevent race condition where plugins register items async. Another plugin's start contact could start before async setup is complete.

nreese · 2026-02-23T20:19:50Z

/ci

nreese · 2026-02-24T15:29:25Z

@elasticmachine merge upstream

nreese · 2026-02-24T15:29:41Z

/ci

nreese · 2026-03-13T19:04:27Z

@elasticmachine merge upstream

nreese · 2026-03-13T19:38:07Z

/ci

nreese · 2026-03-13T20:24:25Z

/ci

nreese · 2026-03-13T21:24:21Z

  mapsEms: 6734
  metricsDataAccess: 44950
-  ml: 89000
+  ml: 103469


ML plugin async imports actions registration. This hides the true size of the ML plugin since part of it is hidden behind this async import.

This PR moves actions registration into ML plugin page load bundle size, and thus increases the bundle size to better reflect the actual size.

nreese · 2026-03-13T21:24:32Z

/ci

nreese · 2026-03-24T13:24:51Z

/ci

nreese · 2026-03-24T17:23:34Z

/ci

nreese · 2026-03-24T18:36:04Z

/ci

nreese · 2026-03-24T22:54:54Z

/ci

nreese · 2026-04-08T18:11:54Z

/ci

This reverts commit 2c6a19f.

nreese · 2026-04-09T16:47:42Z

/ci

nreese · 2026-04-09T18:22:21Z

/ci

elasticmachine · 2026-04-09T20:10:54Z

Pinging @elastic/kibana-presentation (Team:Presentation)

PhilippeOberti

Code review only, LGTM for the @elastic/security-threat-hunting-investigations team

tylersmalley · 2026-04-09T21:42:23Z

  mapsEms: 6734
  metricsDataAccess: 44950
-  ml: 89000
+  ml: 102091


Added a skill if you want to give it a try to reduce this. https://github.com/elastic/kibana/blob/main/.agents/skills/optimize-bundle-size/SKILL.md

/optimize-bundle-size pluginId=ml

davismcphee

Code-only review, Data Discovery changes LGTM 👍

jgowdyelastic · 2026-04-13T12:11:08Z


-            const { registerMlUiActions, registerSearchLinks, registerCasesAttachments } =
-              await import('./register_helper');
+            if (fullLicense && mlCapabilities.canGetMlInfo) {


Are the changes in this file necessary?
I can't see any changes in behaviour when reverting them.

The changes in this file move registerMlUiActions from being imported async to being imported sync. This ensures that ui actions are registered sync instead of registered async.

But this is still happening after the license check and the call to getStartServices, so it is still async.

thanks for pointing this out. I had not looked higher in the file and do see that all of these registrations are still inside an async function. At least this change removes one more await, with a network request, before registering actions - so its moving in the right direction. Completely fixing ML plugin registration is out of scope of this PR but it would be great if all registry items could be completed sync to avoid any timing issues.

nreese · 2026-04-13T15:40:45Z

+              registerMlUiActions(pluginsSetup.uiActions, core);
+            }
+
+            const { registerSearchLinks, registerCasesAttachments } = await import(


This await import should be removed since loads an async file in plugin start, but that is out of scope for the PR.

jgowdyelastic

ML changes LGTM

elasticmachine · 2026-04-14T14:45:14Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 17d86de

Failed CI Steps

FTR Configs #157

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`ml`	4267	4268	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	1.9MB	1.9MB	+21.0B
`ml`	5.8MB	5.8MB	+53.6KB
`securitySolution`	11.7MB	11.7MB	+147.0B
total			+53.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`ml`	86.8KB	90.7KB	+3.9KB
`uiActions`	31.6KB	31.2KB	-336.0B
total			+3.6KB

Unknown metric groups

async chunk count

id	before	after	diff
`ml`	112	113	+1

History

💔 Build #425155 failed 24a722b
💔 Build #425084 failed 753d626
💔 Build #425012 failed 345349b
💔 Build #424254 failed 59b22ec
💔 Build #424226 failed 39aa936
💔 Build #415916 failed e1656dc

* commit '11ed3645c5ededae2a6e29f2a79b31f52208b441': (157 commits) remove sync register uiAction methods (elastic#254590) [performance] Apply minimal auth to the search route (elastic#257497) [ES|QL] Reports correctly the controls server side errors (elastic#263020) [SecuritySolution][Navigation] Enable classic nav updates (elastic#262358) [Inference] Use pretty name and logo on feature settings page (elastic#262531) [Security Solution] fix AT-AB cypress test (elastic#262991) [SigEvents] Seed sigevents env script (elastic#261172) Adjust conditions for validating no refetch for expanded row (elastic#262978) [Agent Builder] update copy for the announcement modal (elastic#263034) [Search] Hide index management links for users without privileges (elastic#262627) Simplify OAS schema for GET `/api/spaces/space` query params (elastic#260831) Fix fleet output OAS regressions: SSL type explosion and Kafka union wrappers (elastic#260842) [Dashboards in chat] fix agent confusing the axes in a horizontal chat (elastic#263064) [One Workflow] Add alert state checkbox UI for workflow connector (elastic#259770) [One Workflow] Deprecate legacy Cases step types in workflow authoring (elastic#262070) skip failing test suite (elastic#248090) fix flaky test: MonitorDetails filter apply button not enabled (elastic#260788) fix: propagate AbortSignal to executeAsReasoningAgent for task cancellation (elastic#262811) [Security Solution][Alert KPI] Fix white space bug in alert KPIs (elastic#260803) [Streams] Move helpers and format_size_unit to utils folder (elastic#262550) ... # Conflicts: # x-pack/platform/plugins/shared/dashboard_agent/public/attachment_types/canvas_integration/dashboard_canvas_content.test.tsx # x-pack/platform/plugins/shared/dashboard_agent/public/attachment_types/canvas_integration/dashboard_canvas_content.tsx # x-pack/platform/plugins/shared/dashboard_agent/public/attachment_types/canvas_integration/use_register_canvas_action_buttons.ts # x-pack/platform/plugins/shared/dashboard_agent/public/attachment_types/index.test.tsx # x-pack/platform/plugins/shared/dashboard_agent/public/attachment_types/index.tsx

nreese added 2 commits February 23, 2026 13:17

remove sync register uiAction methods

bf853b7

eslint

98522c9

nreese added 2 commits February 23, 2026 14:49

update usage in use_additional_cell_actions.ts

96b8943

security_solution

5df5b44

Merge branch 'main' into remove_ui_actions_sync

4eee878

elasticmachine and others added 3 commits March 13, 2026 20:04

Merge branch 'main' into remove_ui_actions_sync

5179a62

examples

c0c26f7

tslint

3150bca

Changes from node scripts/eslint_all_files --no-cache --fix

ba6b5f9

update limits

4d7547e

nreese commented Mar 13, 2026

View reviewed changes

nreese and others added 2 commits March 24, 2026 07:16

Merge branch 'main' into remove_ui_actions_sync

4e05898

fix jest test

453e42e

Merge branch 'main' into remove_ui_actions_sync

5044d34

Merge branch 'main' into remove_ui_actions_sync

b4c1a5c

Merge branch 'main' into remove_ui_actions_sync

e1656dc

merge with main

39aa936

limits

59b22ec

nreese added 2 commits April 9, 2026 10:46

Revert "get items"

1c20f02

This reverts commit 2c6a19f.

clean up

345349b

Merge branch 'main' into remove_ui_actions_sync

753d626

Merge branch 'main' into remove_ui_actions_sync

24a722b

nreese marked this pull request as ready for review April 9, 2026 20:10

nreese requested review from a team as code owners April 9, 2026 20:10

nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v9.5.0 labels Apr 9, 2026

PhilippeOberti approved these changes Apr 9, 2026

View reviewed changes

tylersmalley reviewed Apr 9, 2026

View reviewed changes

tylersmalley approved these changes Apr 9, 2026

View reviewed changes

kowalczyk-krzysztof approved these changes Apr 9, 2026

View reviewed changes

Merge branch 'main' into remove_ui_actions_sync

3e9972d

davismcphee approved these changes Apr 13, 2026

View reviewed changes

jgowdyelastic reviewed Apr 13, 2026

View reviewed changes

nreese commented Apr 13, 2026

View reviewed changes

jgowdyelastic approved these changes Apr 14, 2026

View reviewed changes

Merge branch 'main' into remove_ui_actions_sync

17d86de

nreese merged commit 11ed364 into elastic:main Apr 14, 2026
19 checks passed

Conversation

nreese commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nreese commented Feb 23, 2026

Uh oh!

nreese commented Feb 24, 2026

Uh oh!

nreese commented Feb 24, 2026

Uh oh!

nreese commented Mar 13, 2026

Uh oh!

nreese commented Mar 13, 2026

Uh oh!

nreese commented Mar 13, 2026

Uh oh!

nreese Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

nreese commented Mar 13, 2026

Uh oh!

nreese commented Mar 24, 2026

Uh oh!

nreese commented Mar 24, 2026

Uh oh!

nreese commented Mar 24, 2026

Uh oh!

nreese commented Mar 24, 2026

Uh oh!

nreese commented Apr 8, 2026

Uh oh!

nreese commented Apr 9, 2026

Uh oh!

nreese commented Apr 9, 2026

Uh oh!

elasticmachine commented Apr 9, 2026

Uh oh!

PhilippeOberti left a comment

Choose a reason for hiding this comment

Uh oh!

tylersmalley Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davismcphee left a comment

Choose a reason for hiding this comment

Uh oh!

jgowdyelastic Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

nreese Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

jgowdyelastic Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

nreese Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

nreese Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

jgowdyelastic left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 14, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

nreese commented Feb 23, 2026 •

edited

Loading

tylersmalley Apr 9, 2026 •

edited

Loading