Skip to content

[Streams] Transfer retention tab to Kibana Management#263100

Merged
SoniaSanzV merged 4 commits intoelastic:mainfrom
SoniaSanzV:streams/retention_tab_backend_transfering
Apr 20, 2026
Merged

[Streams] Transfer retention tab to Kibana Management#263100
SoniaSanzV merged 4 commits intoelastic:mainfrom
SoniaSanzV:streams/retention_tab_backend_transfering

Conversation

@SoniaSanzV
Copy link
Copy Markdown
Contributor

@SoniaSanzV SoniaSanzV commented Apr 14, 2026

Summary

  • Transfer ownership of Streams_app retention-related to Kibana Management via CODEOWNERS (data_management/stream_detail_lifecycle folder). Shared methods already moved in [Streams] Move helpers and format_size_unit to utils folder #262550
  • Transfer ownership (review routing) of Streams retention-related backend areas to Kibana Management via CODEOWNERS: internal failure-store routes and library, internal ILM lifecycle routes, and ilm_policies / ilm_phases (+ tests).
  • Isolate failure-store route support code in server/lib/streams/failure_store/ so that surface is easier to own and move later without dragging unrelated stream_crud code.
  • No intentional change to product behavior or public APIs.

@SoniaSanzV SoniaSanzV self-assigned this Apr 14, 2026
@SoniaSanzV SoniaSanzV requested review from a team as code owners April 14, 2026 14:36
@SoniaSanzV SoniaSanzV added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:Streams This is the label for the Streams Project labels Apr 14, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@SoniaSanzV SoniaSanzV force-pushed the streams/retention_tab_backend_transfering branch from b33af3e to 30eb482 Compare April 15, 2026 11:25
@SoniaSanzV SoniaSanzV changed the title [Streams] Transfer retention tab backend to Kibana Management [Streams] Transfer retention tab to Kibana Management Apr 15, 2026
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me, but I'm not sure whether it's enough actually. @CoenWarmer you recently did this for the streams vs sigevents code, I think this change will still ping the onboarding team on every change in that area, right?

Approving for now because that's what we discussed and it's a good step, but still.

@SoniaSanzV
Copy link
Copy Markdown
Contributor Author

SoniaSanzV commented Apr 16, 2026

The code changes look good to me, but I'm not sure whether it's enough actually. @CoenWarmer you recently did this for the streams vs sigevents code, I think this change will still ping the onboarding team on every change in that area, right?

Approving for now because that's what we discussed and it's a good step, but still.

As far as I know, CODEOWNERS works on a “last match wins” basis: for any given file, GitHub evaluates all matching patterns and the last matching rule in the file is the one that applies. So if I add a more specific ownership rule below a broader one (e.g., an override for .../stream_detail_lifecycle/** below a general Streams rule), the override should be valid and should take precedence for files under that subtree.

But waiting for @CoenWarmer for confirm in case I missed something

@SoniaSanzV SoniaSanzV enabled auto-merge (squash) April 17, 2026 14:09
@SoniaSanzV SoniaSanzV requested a review from a team as a code owner April 20, 2026 07:30
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #52 / Entity Analytics - Risk Score Maintainer @ess @serverless @serverlessQA Risk Score Maintainer Task Lifecycle with maintainer test logs data @skipInServerlessMKI resumes producing additional scores after stop and restart when triggered

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
streamsApp 1842 1841 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
streams 107 108 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 2.0MB 2.0MB +13.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
streams 13.7KB 13.7KB +56.0B
Unknown metric groups

API count

id before after diff
streams 110 111 +1

History

cc @SoniaSanzV

@SoniaSanzV SoniaSanzV merged commit 681a724 into elastic:main Apr 20, 2026
17 checks passed
@SoniaSanzV SoniaSanzV deleted the streams/retention_tab_backend_transfering branch April 21, 2026 07:21
SoniaSanzV added a commit that referenced this pull request Apr 21, 2026
… plugin (#264600)

## Summary

In #263100 we change the
ownership of this files but we are not being properly assigned as a
owners by Github in recent PRs. Adding leading slash just in case that's
the cause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants