[SigEvents] Add callout with working promote action.#260433
Merged
mykolaharmash merged 9 commits intoelastic:mainfrom Apr 2, 2026
Merged
[SigEvents] Add callout with working promote action.#260433mykolaharmash merged 9 commits intoelastic:mainfrom
mykolaharmash merged 9 commits intoelastic:mainfrom
Conversation
achyutjhunjhunwala
added
release_note:skip
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
...ublic/components/sig_events/stream_detail_significant_events_view/suggested_rules_flyout.tsx
Outdated
Show resolved
Hide resolved
mykolaharmash
force-pushed
the
add-promote-callout-on-streams-se-tab
branch
from
c9ff5d7 to
77973a4
Compare
mykolaharmash
force-pushed
the
add-promote-callout-on-streams-se-tab
branch
from
77973a4 to
37852d3
Compare
Contributor
ApprovabilityVerdict: Needs human review This PR introduces a new feature that allows users to promote queries to rules via a new promotion callout and flyout UI. The changes introduce new user-facing behavior with API mutations that create rules, and the author does not own any of the affected files (all owned by @elastic/obs-sig-events-team). The designated team should review this new capability. You can customize Macroscope's approvability policy. Learn more. |
mykolaharmash
changed the title
Contributor
|
One thing I noticed testing this pull request is that when a rule is deleted, also the query is deleted. This is should not be the case. Likely this is not related to this pull request but we should follow up on that. Also right now, all rules are promoted but we had some discussion, that only high and critical should be promoted by default. This can also happen as a follow up. |
ruflin
approved these changes
Apr 1, 2026
Contributor
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
PR works as expected. See follow up comments for a next PR.
Contributor
mykolaharmash
added
release_note:skip
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Apr 2, 2026
…heck * commit 'af66aadafa7470ca8ba3e3edd3793bde81fa4596': (31 commits) [Scout] Update test config manifests (elastic#260850) [SLO]: register alerts schema embeddable (elastic#256570) [Discover][Flyout] Update overview fields table with new prop headerVisibility set to false (elastic#260692) [AiButton/Security] Migrate ai-related buttons to use custom styles (elastic#259847) [One Workflow] Fix connector step icons falling back to generic plugs in YAML editor (elastic#260785) [Agent Builder] Dashboard skill: Guard against editing non-ESQL based panels (elastic#260714) Security quality gate Cypress cleanup - Periodic Pipeline (elastic#260820) [Search] Deprecate search indices in favour of index management (elastic#260210) Upgrade dependency @elastic/charts to v71.4.0 (elastic#260593) [Security Solution] [HDQ]: integration-based targeting and descriptor versioning (elastic#258418) docs(saved-objects): consolidate docs and document scoped vs system client (elastic#260743) Fix observability UIAM config and add CPS observability variant (elastic#260485) [Security Solution] Add "matched_indices_count" rule execution metric (elastic#259938) [SigEvents] Add callout with working promote action. (elastic#260433) [Alerting V2] Episode table actions (elastic#260195) [Automatic Migration] Add ability to skip Reference Set step in QRadar upload workflow (elastic#259959) [Rules] KQL-to-DSL conversion without data view produces incorrect queries for keyword fields for Metric threshold rule (elastic#260046) Update dependency lightningcss to v1.32.0 (main) (elastic#259017) Update postcss (main) (elastic#255420) Migrate server-side apm.addLabels to OTel dual-write helpers (elastic#259619) ...
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Apr 2, 2026
Closes elastic/streams-program#1071 This is a follow up change after [the unified KIs table](elastic#259553). * Adds a promotion callout for all unbacked queries * Adds flyout to inspect/delete suggested queries * Cleans up a few obsolete files https://github.com/user-attachments/assets/42f622ee-79de-4a2b-82ac-6948592da8c7 --------- Co-authored-by: Mykola Harmash <mykola.harmash@elastic.co> Co-authored-by: Mykola Harmash <mykola.harmash@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/streams-program/issues/1071
This is a follow up change after the unified KIs table.
CleanShot.2026-04-01.at.14.12.36.mp4