[Automatic Migration] Add ability to skip Reference Set step in QRadar upload workflow#259959
Merged
logeekal merged 8 commits intoelastic:mainfrom Apr 2, 2026
Merged
Conversation
Allows users to continue past the Reference Set upload step (Step 2) without uploading all reference sets, so they can proceed to MITRE Mappings (Step 3). - Add optional `onComplete` callback to `MigrationStepProps` - Replace `onAllReferenceSetCreated` with generic `onComplete` in `ReferenceSetDataInput`, decoupling it from step ordering knowledge - Add "Continue without uploading" button to Reference Set step - Parent flyout owns step progression via `onStepComplete` callback Made-with: Cursor
- Add `onComplete` to default test props - Test skip button renders when step is current - Test skip button calls `onComplete` on click - Test skip button does not render when step is not current - Test content does not render when `onComplete` is not provided Made-with: Cursor
- Move Skip button into the header row of the Reference Set step - Rename button label from "Continue" to "Skip" - Add aria-label for accessibility - Add integration test for the full QRadar flyout skip flow Made-with: Cursor
Relocate the Skip button to sit beside the Upload button inside the LookupsFileUpload shared component, gated behind an optional onSkip prop so only the QRadar reference-set flow renders it. Made-with: Cursor
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
...iem_migrations/common/components/migration_steps/lookups/lookups_file_upload/translations.ts
Show resolved
Hide resolved
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
|
angorayc
approved these changes
Apr 1, 2026
logeekal
added
release_note:skip
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Apr 2, 2026
…heck * commit 'af66aadafa7470ca8ba3e3edd3793bde81fa4596': (31 commits) [Scout] Update test config manifests (elastic#260850) [SLO]: register alerts schema embeddable (elastic#256570) [Discover][Flyout] Update overview fields table with new prop headerVisibility set to false (elastic#260692) [AiButton/Security] Migrate ai-related buttons to use custom styles (elastic#259847) [One Workflow] Fix connector step icons falling back to generic plugs in YAML editor (elastic#260785) [Agent Builder] Dashboard skill: Guard against editing non-ESQL based panels (elastic#260714) Security quality gate Cypress cleanup - Periodic Pipeline (elastic#260820) [Search] Deprecate search indices in favour of index management (elastic#260210) Upgrade dependency @elastic/charts to v71.4.0 (elastic#260593) [Security Solution] [HDQ]: integration-based targeting and descriptor versioning (elastic#258418) docs(saved-objects): consolidate docs and document scoped vs system client (elastic#260743) Fix observability UIAM config and add CPS observability variant (elastic#260485) [Security Solution] Add "matched_indices_count" rule execution metric (elastic#259938) [SigEvents] Add callout with working promote action. (elastic#260433) [Alerting V2] Episode table actions (elastic#260195) [Automatic Migration] Add ability to skip Reference Set step in QRadar upload workflow (elastic#259959) [Rules] KQL-to-DSL conversion without data view produces incorrect queries for keyword fields for Metric threshold rule (elastic#260046) Update dependency lightningcss to v1.32.0 (main) (elastic#259017) Update postcss (main) (elastic#255420) Migrate server-side apm.addLabels to OTel dual-write helpers (elastic#259619) ...
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Apr 2, 2026
…r upload workflow (elastic#259959) ## Summary - Handles elastic/security-team#16315 Adds the ability for users to skip the Reference Set upload step (Step 2) in the QRadar rule migration workflow, allowing them to proceed directly to the Enhancements step (Step 3 - MITRE Mappings) without uploading all reference sets. ### Demo https://github.com/user-attachments/assets/a4ce3e18-1020-46f5-9e6f-426ad8f4616b ## Test plan - [ ] Upload QRadar rules with missing reference sets - [ ] Verify "Skip" button appears in the Reference Set step header when step is active - [ ] Click "Skip" and verify Enhancements step becomes active - [ ] Verify uploading all reference sets still advances to Enhancements step automatically - [ ] Re-open the flyout and verify reference set step can still be completed - [ ] Verify Splunk workflow is unaffected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability for users to skip the Reference Set upload step (Step 2) in the QRadar rule migration workflow, allowing them to proceed directly to the Enhancements step (Step 3 - MITRE Mappings) without uploading all reference sets.
Demo
reference_step_skip_demo.mov
Test plan