Skip to content

docs(saved-objects): consolidate docs and document scoped vs system client#260743

Merged
gsoldevila merged 9 commits intoelastic:mainfrom
gsoldevila:claude/quizzical-swirles
Apr 2, 2026
Merged

docs(saved-objects): consolidate docs and document scoped vs system client#260743
gsoldevila merged 9 commits intoelastic:mainfrom
gsoldevila:claude/quizzical-swirles

Conversation

@gsoldevila
Copy link
Copy Markdown
Member

Closes #124280

Summary

  • Moves all content from dev_docs/key_concepts/saved_objects.mdx into the canonical docs/extend/saved-objects/ section. The old page now shows a short redirect note pointing to https://www.elastic.co/docs/extend/kibana/saved-objects.
  • Enriches docs/extend/saved-objects.md (overview) with four conceptual sections missing from the new docs: Security (space awareness, feature controls/RBAC, OLS), Scalability, Searchability, and Saved Objects by value vs by reference.
  • Enriches docs/extend/saved-objects/use.md with guidance on obtaining a scoped vs system client, incorporating Tina's suggestions from [Docs][Saved Objects] Add section explaining scoped vs. system clients #124280 (comment):
    • Callout that getUnsafeInternalClient defaults to the default space and how to use namespaces: ['*'] to query across all spaces.
    • Warning against manually instantiating SavedObjectsClient with a non-default repository, which bypasses security, spaces, and Encrypted Saved Object wrappers.
    • New "Security considerations" section covering aggregation security risks when using find/search.

Test plan

  • Verify the redirect note renders correctly on the dev docs site (dev_docs/key_concepts/saved_objects.mdx).
  • Verify the new sections render correctly on the canonical saved-objects overview page.
  • Verify the new sections in use.md render correctly.
  • Confirm no broken internal links.

…lient

Closes elastic#124280

Moves all content from `dev_docs/key_concepts/saved_objects.mdx` into
the canonical `docs/extend/saved-objects/` section and leaves a short
redirect note with a link to the new location.

Additions to `docs/extend/saved-objects.md` (overview):
- Security: space awareness, feature controls/RBAC, OLS (planned)
- Scalability: per-type dedicated index via `indexPattern`
- Searchability: system-index limitation ("X as data")
- Saved Objects by value vs by reference

Additions to `docs/extend/saved-objects/use.md`:
- Callout explaining that `getUnsafeInternalClient` defaults to the
  `default` space and how to use `namespaces: ['*']` to query across
  all spaces (Tina's suggestion, elastic#124280 (comment))
- Warning against manually instantiating `SavedObjectsClient` with a
  non-default repository, which bypasses security/spaces/ESO wrappers
- New "Security considerations" section covering aggregation security
  risks when using `find`/`search` with aggregations

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@leemthompo
Copy link
Copy Markdown
Member

@gsoldevila docs eng had to some security work to harden the docs build pipelines, and a side effect is that when working from a fork, we now need your profile to be public to verify elastic org membership and then enable automatic docs previews

You can do that simply by flipping to public here: https://github.com/orgs/elastic/people?query=gsoldevila

The alternative is to build locally: https://www.elastic.co/docs/contribute-docs/locally#install-docs-builder

@gsoldevila gsoldevila added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Apr 1, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-core (Team:Core)

Copy link
Copy Markdown
Member

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some small comments, feel free to leave or take!

Comment thread docs/extend/saved-objects/use.md Outdated
Comment thread docs/extend/saved-objects/use.md Outdated
Comment thread docs/extend/saved-objects/use.md Outdated
Comment thread docs/extend/saved-objects.md Outdated
Comment thread docs/extend/saved-objects.md Outdated
gsoldevila and others added 5 commits April 1, 2026 18:01
Co-authored-by: Florent LB <florent.leborgne@elastic.co>
Co-authored-by: Florent LB <florent.leborgne@elastic.co>
Co-authored-by: Florent LB <florent.leborgne@elastic.co>
Co-authored-by: Florent LB <florent.leborgne@elastic.co>
Co-authored-by: Florent LB <florent.leborgne@elastic.co>
Comment thread docs/extend/saved-objects/use.md Outdated
Co-authored-by: Florent LB <florent.leborgne@elastic.co>
@gsoldevila
Copy link
Copy Markdown
Member Author

/sync-ci

@gsoldevila
Copy link
Copy Markdown
Member Author

/ci-sync

@gsoldevila
Copy link
Copy Markdown
Member Author

/ci

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 1, 2026

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #63 / Agent Builder converse Conversation Error Handling "after all" hook for "keeps the previous conversation rounds visible when there is an error"
  • [job] [logs] FTR Configs #63 / Agent Builder converse Conversation Error Handling "after all" hook for "keeps the previous conversation rounds visible when there is an error"
  • [job] [logs] FTR Configs #63 / Agent Builder converse Conversation Error Handling shows error message when there is an error and allows user to retry
  • [job] [logs] FTR Configs #63 / Agent Builder converse Conversation Error Handling shows error message when there is an error and allows user to retry

Metrics [docs]

✅ unchanged

History

@gsoldevila gsoldevila merged commit 9e4835a into elastic:main Apr 2, 2026
16 checks passed
mbondyra added a commit to mbondyra/kibana that referenced this pull request Apr 2, 2026
…heck

* commit 'af66aadafa7470ca8ba3e3edd3793bde81fa4596': (31 commits)
  [Scout] Update test config manifests (elastic#260850)
  [SLO]: register alerts schema embeddable (elastic#256570)
  [Discover][Flyout] Update overview fields table with new prop headerVisibility set to false (elastic#260692)
  [AiButton/Security] Migrate ai-related buttons to use custom styles (elastic#259847)
  [One Workflow] Fix connector step icons falling back to generic plugs in YAML editor (elastic#260785)
  [Agent Builder] Dashboard skill: Guard against editing non-ESQL based panels (elastic#260714)
  Security quality gate Cypress cleanup - Periodic Pipeline (elastic#260820)
  [Search] Deprecate search indices in favour of index management (elastic#260210)
  Upgrade dependency @elastic/charts to v71.4.0 (elastic#260593)
  [Security Solution] [HDQ]: integration-based targeting and descriptor versioning (elastic#258418)
  docs(saved-objects): consolidate docs and document scoped vs system client (elastic#260743)
  Fix observability UIAM config and add CPS observability variant (elastic#260485)
  [Security Solution] Add "matched_indices_count" rule execution metric (elastic#259938)
  [SigEvents] Add callout with working promote action. (elastic#260433)
  [Alerting V2] Episode table actions (elastic#260195)
  [Automatic Migration] Add ability to skip Reference Set step in QRadar upload workflow (elastic#259959)
  [Rules] KQL-to-DSL conversion without data view produces incorrect queries for keyword fields for Metric threshold rule (elastic#260046)
  Update dependency lightningcss to v1.32.0 (main) (elastic#259017)
  Update postcss (main) (elastic#255420)
  Migrate server-side apm.addLabels to OTel dual-write helpers (elastic#259619)
  ...
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Apr 2, 2026
…lient (elastic#260743)

Closes elastic#124280

## Summary

- **Moves** all content from `dev_docs/key_concepts/saved_objects.mdx`
into the canonical `docs/extend/saved-objects/` section. The old page
now shows a short redirect note pointing to
https://www.elastic.co/docs/extend/kibana/saved-objects.
- **Enriches** `docs/extend/saved-objects.md` (overview) with four
conceptual sections missing from the new docs: Security (space
awareness, feature controls/RBAC, OLS), Scalability, Searchability, and
Saved Objects by value vs by reference.
- **Enriches** `docs/extend/saved-objects/use.md` with guidance on
obtaining a scoped vs system client, incorporating Tina's suggestions
from elastic#124280 (comment):
- Callout that `getUnsafeInternalClient` defaults to the `default` space
and how to use `namespaces: ['*']` to query across all spaces.
- Warning against manually instantiating `SavedObjectsClient` with a
non-default repository, which bypasses security, spaces, and Encrypted
Saved Object wrappers.
- New "Security considerations" section covering aggregation security
risks when using `find`/`search`.

## Test plan

- [ ] Verify the redirect note renders correctly on the dev docs site
(`dev_docs/key_concepts/saved_objects.mdx`).
- [ ] Verify the new sections render correctly on the canonical
saved-objects overview page.
- [ ] Verify the new sections in `use.md` render correctly.
- [ ] Confirm no broken internal links.

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Florent LB <florent.leborgne@elastic.co>
reakaleek pushed a commit that referenced this pull request Apr 3, 2026
#261013)

## Summary

PR #260743 introduced docs-builder syntax on docsmobile pages, breaking
the pipeline:

```
Error occurred prerendering page "/kibana-dev-docs/key-concepts/saved-objects-intro". [...]
ReferenceError: note is not defined
```

Removing the `note` declaration should unblock deployments, and puts the
current statement in line with others already present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs][Saved Objects] Add section explaining scoped vs. system clients

5 participants