docs(saved-objects): consolidate docs and document scoped vs system client#260743
Merged
gsoldevila merged 9 commits intoelastic:mainfrom Apr 2, 2026
Merged
docs(saved-objects): consolidate docs and document scoped vs system client#260743gsoldevila merged 9 commits intoelastic:mainfrom
gsoldevila merged 9 commits intoelastic:mainfrom
Conversation
…lient Closes elastic#124280 Moves all content from `dev_docs/key_concepts/saved_objects.mdx` into the canonical `docs/extend/saved-objects/` section and leaves a short redirect note with a link to the new location. Additions to `docs/extend/saved-objects.md` (overview): - Security: space awareness, feature controls/RBAC, OLS (planned) - Scalability: per-type dedicated index via `indexPattern` - Searchability: system-index limitation ("X as data") - Saved Objects by value vs by reference Additions to `docs/extend/saved-objects/use.md`: - Callout explaining that `getUnsafeInternalClient` defaults to the `default` space and how to use `namespaces: ['*']` to query across all spaces (Tina's suggestion, elastic#124280 (comment)) - Warning against manually instantiating `SavedObjectsClient` with a non-default repository, which bypasses security/spaces/ESO wrappers - New "Security considerations" section covering aggregation security risks when using `find`/`search` with aggregations Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
@gsoldevila docs eng had to some security work to harden the docs build pipelines, and a side effect is that when working from a fork, we now need your profile to be public to verify elastic org membership and then enable automatic docs previews You can do that simply by flipping to public here: https://github.com/orgs/elastic/people?query=gsoldevila The alternative is to build locally: https://www.elastic.co/docs/contribute-docs/locally#install-docs-builder |
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
florent-leborgne
approved these changes
Apr 1, 2026
Member
florent-leborgne
left a comment
There was a problem hiding this comment.
LGTM! Some small comments, feel free to leave or take!
Co-authored-by: Florent LB <florent.leborgne@elastic.co>
Co-authored-by: Florent LB <florent.leborgne@elastic.co>
Co-authored-by: Florent LB <florent.leborgne@elastic.co>
Co-authored-by: Florent LB <florent.leborgne@elastic.co>
Co-authored-by: Florent LB <florent.leborgne@elastic.co>
Co-authored-by: Florent LB <florent.leborgne@elastic.co>
Member
Author
|
/sync-ci |
Member
Author
|
/ci-sync |
Member
Author
|
/ci |
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History |
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Apr 2, 2026
…heck * commit 'af66aadafa7470ca8ba3e3edd3793bde81fa4596': (31 commits) [Scout] Update test config manifests (elastic#260850) [SLO]: register alerts schema embeddable (elastic#256570) [Discover][Flyout] Update overview fields table with new prop headerVisibility set to false (elastic#260692) [AiButton/Security] Migrate ai-related buttons to use custom styles (elastic#259847) [One Workflow] Fix connector step icons falling back to generic plugs in YAML editor (elastic#260785) [Agent Builder] Dashboard skill: Guard against editing non-ESQL based panels (elastic#260714) Security quality gate Cypress cleanup - Periodic Pipeline (elastic#260820) [Search] Deprecate search indices in favour of index management (elastic#260210) Upgrade dependency @elastic/charts to v71.4.0 (elastic#260593) [Security Solution] [HDQ]: integration-based targeting and descriptor versioning (elastic#258418) docs(saved-objects): consolidate docs and document scoped vs system client (elastic#260743) Fix observability UIAM config and add CPS observability variant (elastic#260485) [Security Solution] Add "matched_indices_count" rule execution metric (elastic#259938) [SigEvents] Add callout with working promote action. (elastic#260433) [Alerting V2] Episode table actions (elastic#260195) [Automatic Migration] Add ability to skip Reference Set step in QRadar upload workflow (elastic#259959) [Rules] KQL-to-DSL conversion without data view produces incorrect queries for keyword fields for Metric threshold rule (elastic#260046) Update dependency lightningcss to v1.32.0 (main) (elastic#259017) Update postcss (main) (elastic#255420) Migrate server-side apm.addLabels to OTel dual-write helpers (elastic#259619) ...
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Apr 2, 2026
…lient (elastic#260743) Closes elastic#124280 ## Summary - **Moves** all content from `dev_docs/key_concepts/saved_objects.mdx` into the canonical `docs/extend/saved-objects/` section. The old page now shows a short redirect note pointing to https://www.elastic.co/docs/extend/kibana/saved-objects. - **Enriches** `docs/extend/saved-objects.md` (overview) with four conceptual sections missing from the new docs: Security (space awareness, feature controls/RBAC, OLS), Scalability, Searchability, and Saved Objects by value vs by reference. - **Enriches** `docs/extend/saved-objects/use.md` with guidance on obtaining a scoped vs system client, incorporating Tina's suggestions from elastic#124280 (comment): - Callout that `getUnsafeInternalClient` defaults to the `default` space and how to use `namespaces: ['*']` to query across all spaces. - Warning against manually instantiating `SavedObjectsClient` with a non-default repository, which bypasses security, spaces, and Encrypted Saved Object wrappers. - New "Security considerations" section covering aggregation security risks when using `find`/`search`. ## Test plan - [ ] Verify the redirect note renders correctly on the dev docs site (`dev_docs/key_concepts/saved_objects.mdx`). - [ ] Verify the new sections render correctly on the canonical saved-objects overview page. - [ ] Verify the new sections in `use.md` render correctly. - [ ] Confirm no broken internal links. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Florent LB <florent.leborgne@elastic.co>
reakaleek
pushed a commit
that referenced
this pull request
Apr 3, 2026
#261013) ## Summary PR #260743 introduced docs-builder syntax on docsmobile pages, breaking the pipeline: ``` Error occurred prerendering page "/kibana-dev-docs/key-concepts/saved-objects-intro". [...] ReferenceError: note is not defined ``` Removing the `note` declaration should unblock deployments, and puts the current statement in line with others already present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #124280
Summary
dev_docs/key_concepts/saved_objects.mdxinto the canonicaldocs/extend/saved-objects/section. The old page now shows a short redirect note pointing to https://www.elastic.co/docs/extend/kibana/saved-objects.docs/extend/saved-objects.md(overview) with four conceptual sections missing from the new docs: Security (space awareness, feature controls/RBAC, OLS), Scalability, Searchability, and Saved Objects by value vs by reference.docs/extend/saved-objects/use.mdwith guidance on obtaining a scoped vs system client, incorporating Tina's suggestions from [Docs][Saved Objects] Add section explaining scoped vs. system clients #124280 (comment):getUnsafeInternalClientdefaults to thedefaultspace and how to usenamespaces: ['*']to query across all spaces.SavedObjectsClientwith a non-default repository, which bypasses security, spaces, and Encrypted Saved Object wrappers.find/search.Test plan
dev_docs/key_concepts/saved_objects.mdx).use.mdrender correctly.