[Sig Events] Unified KIs table in Stream details UI by mykolaharmash · Pull Request #259553 · elastic/kibana

mykolaharmash · 2026-03-25T11:45:56Z

Closes - https://github.com/elastic/streams-program/issues/1070
This changes replaces the current sig events management UI in the stream details with a unified Knowledge Indicators table that shows both features and queries. Additionally, user can switch into Rules table that focuses on queries that have a backing rule.

Notable changes:

Reworked Stream Details “Significant Events” into a unified Knowledge Indicators + Rules tables with search, filtering and bulk actions.
Introduced a new task orchestration hook useKnowledgeIndicatorsTask() for KI generation. It improves the flow for starting/canceling generation by giving a user an immediate feedback in the UI.
Added reusable details flyout for feature/query KIs. Content of the flyout is intentionally extacted into its own component so it can be reused in other places like feature details flyout and future query promotion flyout sidebar.
Reworked the empty state for the Sig Events screen to also use the new useKnowledgeIndicatorsTask() hook
Refactored system feature flyout to reuse shared KI feature-details content

CleanShot.2026-03-25.at.16.13.48.mp4

…etails-unified-table

...red/streams_app/public/components/sig_events/stream_detail_significant_events_view/index.tsx

...eam_detail_significant_events_view/knowledge_indicators_table/knowledge_indicators_table.tsx

...blic/components/stream_detail_significant_events_view/hooks/use_knowledge_indicators_task.ts

...blic/components/sig_events/stream_detail_significant_events_view/rules_table/rules_table.tsx

…tream-details-unified-table

macroscopeapp · 2026-03-25T12:30:49Z

...blic/components/sig_events/stream_detail_significant_events_view/rules_table/rules_table.tsx

+    },
+  });
+
+  const filteredRules = useMemo(() => {


🟠 High rules_table/rules_table.tsx:57

When searchTerm changes and filteredRules shrinks, pagination.pageIndex is not reset to 0. If a user is on page 5 and searches for something matching only 5 rules, pageIndex stays at 4, causing TableTitle to display incorrect counts like "5-5 of 5 Rules" instead of "1-5 of 5 Rules". Consider resetting pageIndex to 0 whenever filteredRules changes.

No longer relevant as of 07ec962

@mykolaharmash This issue is still relevant. The bot incorrectly says that its no longer relevant. We need fixed

I see you are already handling this for KnowledgeIndicatorTable

We must do the same here

https://github.com/elastic/kibana/pull/259553/changes#diff-7f8434910e26fdeaa4659987d04ef1f7f5b46c2577b715f6cf294448c2e5ebd9R109-R120

...ents/sig_events/stream_detail_significant_events_view/hooks/use_knowledge_indicators_task.ts

…etails-unified-table

…d-table' into sig-events-stream-details-unified-table

x-pack/platform/packages/shared/kbn-streams-schema/src/tasks/types.ts

ruflin · 2026-03-26T08:39:19Z

Started some initial testing.

Error: I get the error below if I just click "Generate"
- The generate button, does it trigger KI features and KI query generation?
Naming / Description: Likely we need to make some adjustments but we can do this as a follow up.
Advanced -> Identify features: I assumes this will go away?

ruflin · 2026-03-26T08:46:06Z

Tested a bit more. This is heading in the right direction. @boriskirov We need to have a discussion around potentially 2 buttons for LLM selection around KI features and KI query generation or somehow make it a selection or similar.

coderabbitai · 2026-03-26T08:54:07Z

📝 Walkthrough

Walkthrough

This pull request restructures the significant events UI layer by replacing the "add/edit significant event flyout" workflow with a new "knowledge indicators and rules" system. The changes remove components for manual and AI-generated event creation (AddSignificantEventFlyout, ManualFlowForm, GeneratedFlowForm, and supporting helpers) and introduce new components for viewing/managing knowledge indicators as features and queries (KnowledgeIndicatorDetailsFlyout, KnowledgeIndicatorsTable, RulesTable). New hooks manage bulk deletion and generation task lifecycle. The main significant events view is rewritten to support filtering by type and status, with generation integrated into an empty state. Minor updates include schema refinements to TaskResult discriminant union shape, API method additions for bulk query deletion, and build manifest dependency expansion.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

🛠️ Update Documentation: Commit on current branch
🛠️ Update Documentation: Create PR

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…etails-unified-table

ruflin · 2026-03-31T08:57:08Z

Did a manual test run and works as expected after setting the global AI settings.

…tream-details-unified-table

…etails-unified-table

ruflin · 2026-04-01T07:03:17Z

@mykolaharmash I resolved the merge conflict on this branch to get another run.

Tested the changes locally, works as expected.

ruflin · 2026-04-01T07:13:02Z

Side note, the url for genai settings changed to http://localhost:5601/app/management/ml/model_settings but we can address this in a follow up PR.

elasticmachine · 2026-04-01T08:16:31Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 4d6d9f7

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #37 / Alerting alerts_as_data alerts as data should write alert docs during rule execution with flapping.enabled: true
[job] [logs] Jest Tests #1 / buildEsqlFetchSubscribe changing a ES|QL query with no transformational commands should not change state when loading and finished if index pattern and columns are the same

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`streamsApp`	1.9MB	1.8MB	-16.4KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`streamsApp`	139	136	-3

Total ESLint disabled count

id	before	after	diff
`streamsApp`	147	144	-3

History

💛 Build #419549 was flaky 486e1d9
💔 Build #418935 failed 29a7fba
💔 Build #418837 failed 5d46be3
💚 Build #418616 succeeded 07ec962
💛 Build #416848 was flaky 0699493
💔 Build #416309 failed b7ef6ec

achyutjhunjhunwala · 2026-04-01T08:36:36Z

...app/public/components/sig_events/stream_detail_significant_events_view/empty_state/index.tsx

+  const genAiConnectors = useGenAIConnectors({
+    streamsRepositoryClient: streams.streamsRepositoryClient,
+    uiSettings: core.uiSettings,
+  });
+
+  const isDefaultAiConnectorMissing =
+    !genAiConnectors.loading && !Boolean(genAiConnectors.defaultConnector);
+  const genAiSettingsUrl = core.application.getUrlForApp('management', {
+    path: GEN_AI_SETTINGS_PATH,
+  });


Calling this hook just to read the default connector is an overhead as it also does API call to fetch our other connectors stored. This can be simplified

Suggested change

const genAiConnectors = useGenAIConnectors({

streamsRepositoryClient: streams.streamsRepositoryClient,

uiSettings: core.uiSettings,

});

const isDefaultAiConnectorMissing =

!genAiConnectors.loading && !Boolean(genAiConnectors.defaultConnector);

const genAiSettingsUrl = core.application.getUrlForApp('management', {

path: GEN_AI_SETTINGS_PATH,

});

const defaultConnector = core.uiSettings.get<string>(GEN_AI_SETTINGS_DEFAULT_AI_CONNECTOR);

const isDefaultAiConnectorMissing = !defaultConnector || defaultConnector === 'NO_DEFAULT_CONNECTOR';

const genAiSettingsUrl = core.application.getUrlForApp('management', {

path: GEN_AI_SETTINGS_PATH,

});

Can we address this in a follow up PR to not have to retrigger the full CI cycle?

Good point, I'll address it in a follow up

@mykolaharmash this would have a slight perf impact (like unnecessary API call).
We can definitely go with this and handle it in next PR, if possible before FF

achyutjhunjhunwala

Great work on the changes, but there are 2 changes which we would need bare minimum to go through

achyutjhunjhunwala · 2026-04-01T09:04:03Z

...blic/components/sig_events/stream_detail_significant_events_view/rules_table/rules_table.tsx

+    },
+  });
+
+  const filteredRules = useMemo(() => {


@mykolaharmash This issue is still relevant. The bot incorrectly says that its no longer relevant. We need fixed

I see you are already handling this for KnowledgeIndicatorTable

We must do the same here

https://github.com/elastic/kibana/pull/259553/changes#diff-7f8434910e26fdeaa4659987d04ef1f7f5b46c2577b715f6cf294448c2e5ebd9R109-R120

…d-table' into sig-events-stream-details-unified-table

…etails-unified-table

achyutjhunjhunwala

LGTM, thanks for the change

Closes - elastic/streams-program#1070 This changes replaces the current sig events management UI in the stream details with a unified Knowledge Indicators table that shows both features and queries. Additionally, user can switch into Rules table that focuses on queries that have a backing rule. Notable changes: - Reworked Stream Details “Significant Events” into a unified Knowledge Indicators + Rules tables with search, filtering and bulk actions. - Introduced a new task orchestration hook `useKnowledgeIndicatorsTask()` for KI generation. It improves the flow for starting/canceling generation by giving a user an immediate feedback in the UI. - Added reusable details flyout for feature/query KIs. Content of the flyout is intentionally extacted into its own component so it can be reused in other places like feature details flyout and future query promotion flyout sidebar. - Reworked the empty state for the Sig Events screen to also use the new `useKnowledgeIndicatorsTask()` hook - Refactored system feature flyout to reuse shared KI feature-details content https://github.com/user-attachments/assets/41e70d86-91c7-4a1e-944e-69116768292c --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nicolas Ruflin <spam@ruflin.com>

Closes elastic/streams-program#1071 This is a follow up change after [the unified KIs table](#259553). * Adds a promotion callout for all unbacked queries * Adds flyout to inspect/delete suggested queries * Cleans up a few obsolete files https://github.com/user-attachments/assets/42f622ee-79de-4a2b-82ac-6948592da8c7 --------- Co-authored-by: Mykola Harmash <mykola.harmash@elastic.co> Co-authored-by: Mykola Harmash <mykola.harmash@gmail.com>

Closes - elastic/streams-program#1070 This changes replaces the current sig events management UI in the stream details with a unified Knowledge Indicators table that shows both features and queries. Additionally, user can switch into Rules table that focuses on queries that have a backing rule. Notable changes: - Reworked Stream Details “Significant Events” into a unified Knowledge Indicators + Rules tables with search, filtering and bulk actions. - Introduced a new task orchestration hook `useKnowledgeIndicatorsTask()` for KI generation. It improves the flow for starting/canceling generation by giving a user an immediate feedback in the UI. - Added reusable details flyout for feature/query KIs. Content of the flyout is intentionally extacted into its own component so it can be reused in other places like feature details flyout and future query promotion flyout sidebar. - Reworked the empty state for the Sig Events screen to also use the new `useKnowledgeIndicatorsTask()` hook - Refactored system feature flyout to reuse shared KI feature-details content https://github.com/user-attachments/assets/41e70d86-91c7-4a1e-944e-69116768292c --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nicolas Ruflin <spam@ruflin.com>

Closes elastic/streams-program#1071 This is a follow up change after [the unified KIs table](elastic#259553). * Adds a promotion callout for all unbacked queries * Adds flyout to inspect/delete suggested queries * Cleans up a few obsolete files https://github.com/user-attachments/assets/42f622ee-79de-4a2b-82ac-6948592da8c7 --------- Co-authored-by: Mykola Harmash <mykola.harmash@elastic.co> Co-authored-by: Mykola Harmash <mykola.harmash@gmail.com>

mykolaharmash added 9 commits March 23, 2026 11:48

[Sig Events] Unified table for KIs and Rules

40d6815

Merge remote-tracking branch 'upstream/main' into sig-events-stream-d…

778562d

…etails-unified-table

Merge remote-tracking branch 'upstream/main' into sig-events-stream-d…

bf65a67

…etails-unified-table

[Sig Events] Unified table for KIs and Rules

a03a934

fixup! [Sig Events] Unified table for KIs and Rules

f9b8cb1

KI generation

89f099e

Row actions

d57d2e9

Flyouts

110a6cf

Merge remote-tracking branch 'upstream/main' into sig-events-stream-d…

bddcdeb

…etails-unified-table

macroscopeapp bot reviewed Mar 25, 2026

View reviewed changes

fixup! Merge remote-tracking branch 'upstream/main' into sig-events-s…

f51eab9

…tream-details-unified-table

macroscopeapp bot reviewed Mar 25, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/main' into sig-events-stream-d…

b7ef6ec

…etails-unified-table

mykolaharmash changed the title ~~Sig events stream details unified table~~ [Sig Events] Unified KIs table in Stream details UI Mar 25, 2026

kibanamachine and others added 4 commits March 25, 2026 13:41

Changes from node scripts/lint_ts_projects --fix

66465dd

Changes from node scripts/regenerate_moon_projects.js --update

73c156a

Empty state

6053ca7

Merge remote-tracking branch 'origin/sig-events-stream-details-unifie…

4e64211

…d-table' into sig-events-stream-details-unified-table

mykolaharmash commented Mar 25, 2026

View reviewed changes

x-pack/platform/packages/shared/kbn-streams-schema/src/tasks/types.ts Show resolved Hide resolved

mykolaharmash marked this pull request as ready for review March 25, 2026 15:31

mykolaharmash requested review from a team as code owners March 25, 2026 15:31

mykolaharmash added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Mar 25, 2026

Clean up unused components

825d01c

ruflin added the Feature:SigEvents Significant events feature, related to streams and rules/alerts (RnA) label Mar 26, 2026

Merge branch 'main' into sig-events-stream-details-unified-table

0699493

mykolaharmash added 6 commits March 30, 2026 15:05

Merge remote-tracking branch 'upstream/main' into sig-events-stream-d…

cf5fb5f

…etails-unified-table

Remove Features section in Stream Advanced tab

30c5bb6

fixup! Remove Features section in Stream Advanced tab

5d46be3

Missing default connector callout

29a7fba

Tests clean up

438cf12

Merge remote-tracking branch 'upstream/main' into sig-events-stream-d…

6cc7f97

…etails-unified-table

achyutjhunjhunwala mentioned this pull request Mar 31, 2026

[SigEvents] Add callout with working promote action. #260433

Merged

mykolaharmash and others added 2 commits March 31, 2026 12:35

fixup! Merge remote-tracking branch 'upstream/main' into sig-events-s…

486e1d9

…tream-details-unified-table

Merge remote-tracking branch 'upstream/main' into sig-events-stream-d…

4d6d9f7

…etails-unified-table

ruflin approved these changes Apr 1, 2026

View reviewed changes

mykolaharmash enabled auto-merge (squash) April 1, 2026 07:44

mykolaharmash disabled auto-merge April 1, 2026 08:13

achyutjhunjhunwala reviewed Apr 1, 2026

View reviewed changes

achyutjhunjhunwala requested changes Apr 1, 2026

View reviewed changes

mykolaharmash added 3 commits April 1, 2026 11:31

Address comments

8d37212

Merge remote-tracking branch 'origin/sig-events-stream-details-unifie…

f89d590

…d-table' into sig-events-stream-details-unified-table

Merge remote-tracking branch 'upstream/main' into sig-events-stream-d…

27d6425

…etails-unified-table

achyutjhunjhunwala approved these changes Apr 1, 2026

View reviewed changes

achyutjhunjhunwala enabled auto-merge (squash) April 1, 2026 10:02

achyutjhunjhunwala merged commit 67ae442 into elastic:main Apr 1, 2026
21 checks passed

kibanamachine added the v9.4.0 label Apr 1, 2026

Conversation

mykolaharmash commented Mar 25, 2026 • edited by achyutjhunjhunwala Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macroscopeapp bot Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

achyutjhunjhunwala Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ruflin commented Mar 26, 2026

Uh oh!

ruflin commented Mar 26, 2026

Uh oh!

coderabbitai bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

ruflin commented Mar 31, 2026

Uh oh!

ruflin commented Apr 1, 2026

Uh oh!

ruflin commented Apr 1, 2026

Uh oh!

elasticmachine commented Apr 1, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

achyutjhunjhunwala Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ruflin Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

mykolaharmash Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

achyutjhunjhunwala Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

achyutjhunjhunwala left a comment

Choose a reason for hiding this comment

Uh oh!

achyutjhunjhunwala Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

achyutjhunjhunwala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mykolaharmash commented Mar 25, 2026 •

edited by achyutjhunjhunwala

Loading

macroscopeapp bot Mar 25, 2026 •

edited

Loading

coderabbitai bot commented Mar 26, 2026 •

edited

Loading

achyutjhunjhunwala Apr 1, 2026 •

edited

Loading