[Console] Only show ESQL suggestions in ESQL query request#240264
Merged
ElenaStoeva merged 6 commits intoelastic:mainfrom Oct 27, 2025
Merged
[Console] Only show ESQL suggestions in ESQL query request#240264ElenaStoeva merged 6 commits intoelastic:mainfrom
ElenaStoeva merged 6 commits intoelastic:mainfrom
Conversation
ElenaStoeva
added
Feature:Console
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
eokoneyo
approved these changes
Oct 23, 2025
Contributor
eokoneyo
left a comment
eokoneyo
left a comment
There was a problem hiding this comment.
Approving to unblock code domain is actually kibana Management
ElenaStoeva
force-pushed
the
console/suggest-esql-in-correct-request
branch
from
b14a8cb to
17f3e56
Compare
SoniaSanzV
approved these changes
Oct 27, 2025
Contributor
SoniaSanzV
left a comment
SoniaSanzV
left a comment
There was a problem hiding this comment.
tested locally, lgtm :)
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @ElenaStoeva |
ElenaStoeva
added a commit
that referenced
this pull request
Nov 3, 2025
Follow-up to #240264 ## Summary This PR fixes a small regression introduced by #240264, where ESQL suggestions are no longer displayed for `_query/async` endpoints and they should be. With this change, ESQL suggesstions should be displayed for the following endpoints: `_query` `/_query` `_query?...` `/_query?...` `_query/async` `/_query/async` `_query/async?...` `/_query/async?...`
This was referenced Feb 26, 2026
ElenaStoeva
added
v8.19.13
v9.2.7
backport:version
Contributor
|
Starting backport for target branches: 8.19, 9.2, 9.3 https://github.com/elastic/kibana/actions/runs/22441183836 |
Contributor
|
Starting backport for target branches: 8.19, 9.2, 9.3 https://github.com/elastic/kibana/actions/runs/22441184798 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 26, 2026
…40264) Closes elastic#225685 ## Summary Previously, ESQL suggestions were shown inside all `query` body params (`"query": "...` or `"query": """...`). However, there are some requests with a `query` body param that don't work with ESLQ (e.g. SQL query). This PR makes sure that ESQL suggestions are only displayed inside `POST _query` request (which is the request for sending ESQL queries). **How to test:** Verify that ESQL suggestions are displayed in `POST _query` requests: ``` POST /_query { "query": "..." } ``` Verify that ESQL suggestions are **not** displayed in any other requests; for example: ``` POST /_sql { "query": "...." } ``` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 7f03a89)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 26, 2026
…40264) Closes elastic#225685 ## Summary Previously, ESQL suggestions were shown inside all `query` body params (`"query": "...` or `"query": """...`). However, there are some requests with a `query` body param that don't work with ESLQ (e.g. SQL query). This PR makes sure that ESQL suggestions are only displayed inside `POST _query` request (which is the request for sending ESQL queries). **How to test:** Verify that ESQL suggestions are displayed in `POST _query` requests: ``` POST /_query { "query": "..." } ``` Verify that ESQL suggestions are **not** displayed in any other requests; for example: ``` POST /_sql { "query": "...." } ``` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 7f03a89)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 26, 2026
…0264) (#255098) # Backport This will backport the following commits from `main` to `9.2`: - [[Console] Only show ESQL suggestions in ESQL query request (#240264)](#240264) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"59341489+ElenaStoeva@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-27T14:48:54Z","message":"[Console] Only show ESQL suggestions in ESQL query request (#240264)\n\nCloses https://github.com/elastic/kibana/issues/225685\n\n## Summary\n\nPreviously, ESQL suggestions were shown inside all `query` body params\n(`\"query\": \"...` or `\"query\": \"\"\"...`). However, there are some requests\nwith a `query` body param that don't work with ESLQ (e.g. SQL query).\nThis PR makes sure that ESQL suggestions are only displayed inside `POST\n_query` request (which is the request for sending ESQL queries).\n\n**How to test:**\n\nVerify that ESQL suggestions are displayed in `POST _query` requests:\n\n```\nPOST /_query\n{\n \"query\": \"...\"\n}\n```\n\nVerify that ESQL suggestions are **not** displayed in any other\nrequests; for example:\n\n```\nPOST /_sql\n{\n \"query\": \"....\"\n}\n```\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7f03a89707f337416f3b898be884f9f81280e837","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","backport:version","v9.3.0","v9.4.0","v8.19.13","v9.2.7"],"title":"[Console] Only show ESQL suggestions in ESQL query request","number":240264,"url":"https://github.com/elastic/kibana/pull/240264","mergeCommit":{"message":"[Console] Only show ESQL suggestions in ESQL query request (#240264)\n\nCloses https://github.com/elastic/kibana/issues/225685\n\n## Summary\n\nPreviously, ESQL suggestions were shown inside all `query` body params\n(`\"query\": \"...` or `\"query\": \"\"\"...`). However, there are some requests\nwith a `query` body param that don't work with ESLQ (e.g. SQL query).\nThis PR makes sure that ESQL suggestions are only displayed inside `POST\n_query` request (which is the request for sending ESQL queries).\n\n**How to test:**\n\nVerify that ESQL suggestions are displayed in `POST _query` requests:\n\n```\nPOST /_query\n{\n \"query\": \"...\"\n}\n```\n\nVerify that ESQL suggestions are **not** displayed in any other\nrequests; for example:\n\n```\nPOST /_sql\n{\n \"query\": \"....\"\n}\n```\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7f03a89707f337416f3b898be884f9f81280e837"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/240264","number":240264,"mergeCommit":{"message":"[Console] Only show ESQL suggestions in ESQL query request (#240264)\n\nCloses https://github.com/elastic/kibana/issues/225685\n\n## Summary\n\nPreviously, ESQL suggestions were shown inside all `query` body params\n(`\"query\": \"...` or `\"query\": \"\"\"...`). However, there are some requests\nwith a `query` body param that don't work with ESLQ (e.g. SQL query).\nThis PR makes sure that ESQL suggestions are only displayed inside `POST\n_query` request (which is the request for sending ESQL queries).\n\n**How to test:**\n\nVerify that ESQL suggestions are displayed in `POST _query` requests:\n\n```\nPOST /_query\n{\n \"query\": \"...\"\n}\n```\n\nVerify that ESQL suggestions are **not** displayed in any other\nrequests; for example:\n\n```\nPOST /_sql\n{\n \"query\": \"....\"\n}\n```\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7f03a89707f337416f3b898be884f9f81280e837"}},{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.13","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>
ElenaStoeva
added
v8.19.13
backport:version
Contributor
|
Starting backport for target branches: 8.19, 9.2, 9.3 https://github.com/elastic/kibana/actions/runs/22449586382 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ElenaStoeva
added a commit
that referenced
this pull request
Feb 27, 2026
…40264) (#255283) # Backport This will backport the following commits from `main` to `8.19`: - [[Console] Only show ESQL suggestions in ESQL query request (#240264)](#240264) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"59341489+ElenaStoeva@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-27T14:48:54Z","message":"[Console] Only show ESQL suggestions in ESQL query request (#240264)\n\nCloses https://github.com/elastic/kibana/issues/225685\n\n## Summary\n\nPreviously, ESQL suggestions were shown inside all `query` body params\n(`\"query\": \"...` or `\"query\": \"\"\"...`). However, there are some requests\nwith a `query` body param that don't work with ESLQ (e.g. SQL query).\nThis PR makes sure that ESQL suggestions are only displayed inside `POST\n_query` request (which is the request for sending ESQL queries).\n\n**How to test:**\n\nVerify that ESQL suggestions are displayed in `POST _query` requests:\n\n```\nPOST /_query\n{\n \"query\": \"...\"\n}\n```\n\nVerify that ESQL suggestions are **not** displayed in any other\nrequests; for example:\n\n```\nPOST /_sql\n{\n \"query\": \"....\"\n}\n```\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7f03a89707f337416f3b898be884f9f81280e837","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","backport:version","v9.3.0","v9.2.6","v8.19.13","v9.2.7"],"title":"[Console] Only show ESQL suggestions in ESQL query request","number":240264,"url":"https://github.com/elastic/kibana/pull/240264","mergeCommit":{"message":"[Console] Only show ESQL suggestions in ESQL query request (#240264)\n\nCloses https://github.com/elastic/kibana/issues/225685\n\n## Summary\n\nPreviously, ESQL suggestions were shown inside all `query` body params\n(`\"query\": \"...` or `\"query\": \"\"\"...`). However, there are some requests\nwith a `query` body param that don't work with ESLQ (e.g. SQL query).\nThis PR makes sure that ESQL suggestions are only displayed inside `POST\n_query` request (which is the request for sending ESQL queries).\n\n**How to test:**\n\nVerify that ESQL suggestions are displayed in `POST _query` requests:\n\n```\nPOST /_query\n{\n \"query\": \"...\"\n}\n```\n\nVerify that ESQL suggestions are **not** displayed in any other\nrequests; for example:\n\n```\nPOST /_sql\n{\n \"query\": \"....\"\n}\n```\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7f03a89707f337416f3b898be884f9f81280e837"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/240264","number":240264,"mergeCommit":{"message":"[Console] Only show ESQL suggestions in ESQL query request (#240264)\n\nCloses https://github.com/elastic/kibana/issues/225685\n\n## Summary\n\nPreviously, ESQL suggestions were shown inside all `query` body params\n(`\"query\": \"...` or `\"query\": \"\"\"...`). However, there are some requests\nwith a `query` body param that don't work with ESLQ (e.g. SQL query).\nThis PR makes sure that ESQL suggestions are only displayed inside `POST\n_query` request (which is the request for sending ESQL queries).\n\n**How to test:**\n\nVerify that ESQL suggestions are displayed in `POST _query` requests:\n\n```\nPOST /_query\n{\n \"query\": \"...\"\n}\n```\n\nVerify that ESQL suggestions are **not** displayed in any other\nrequests; for example:\n\n```\nPOST /_sql\n{\n \"query\": \"....\"\n}\n```\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7f03a89707f337416f3b898be884f9f81280e837"}},{"branch":"9.2","label":"v9.2.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/255098","number":255098,"state":"MERGED","mergeCommit":{"sha":"8d2b19194006d7282b33d8f7225a02bff2a2b649","message":"[9.2] [Console] Only show ESQL suggestions in ESQL query request (#240264) (#255098)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.2`:\n- [[Console] Only show ESQL suggestions in ESQL query request\n(#240264)](https://github.com/elastic/kibana/pull/240264)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>"}},{"branch":"8.19","label":"v8.19.13","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #225685
Summary
Previously, ESQL suggestions were shown inside all
querybody params ("query": "...or"query": """...). However, there are some requests with aquerybody param that don't work with ESLQ (e.g. SQL query). This PR makes sure that ESQL suggestions are only displayed insidePOST _queryrequest (which is the request for sending ESQL queries).How to test:
Verify that ESQL suggestions are displayed in
POST _queryrequests:Verify that ESQL suggestions are not displayed in any other requests; for example: