Skip to content

[Console] Allow ESQL suggestions in _query/async request#241424

Merged
ElenaStoeva merged 2 commits intoelastic:mainfrom
ElenaStoeva:console/esql-in-async-request
Nov 3, 2025
Merged

[Console] Allow ESQL suggestions in _query/async request#241424
ElenaStoeva merged 2 commits intoelastic:mainfrom
ElenaStoeva:console/esql-in-async-request

Conversation

@ElenaStoeva
Copy link
Contributor

Follow-up to #240264

Summary

This PR fixes a small regression introduced by #240264, where ESQL suggestions are no longer displayed for _query/async endpoints and they should be.

With this change, ESQL suggesstions should be displayed for the following endpoints:

_query
/_query
_query?...
/_query?...
_query/async
/_query/async
_query/async?...
/_query/async?...

@ElenaStoeva ElenaStoeva requested a review from a team October 31, 2025 09:51
@ElenaStoeva ElenaStoeva self-assigned this Oct 31, 2025
@ElenaStoeva ElenaStoeva requested a review from a team as a code owner October 31, 2025 09:51
@ElenaStoeva ElenaStoeva added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Oct 31, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

Copy link
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ElenaStoeva! I'm sorry I didn't catch that regression in my review.

ESQL suggestions look good to me in all cases, but I found something that I don't know if it's related to this PR.

For _query request I get suggestions for the body, but not for _query/async

Screenshot 2025-10-31 at 13 54 33 Screenshot 2025-10-31 at 13 53 25

Once I type "query" myself, I get the suggestions as expected:
Screenshot 2025-10-31 at 13 55 28

@ElenaStoeva
Copy link
Contributor Author

Thanks for reviewing @SoniaSanzV! Yeah, I noticed that too but that's not related to the ESQL suggestions - it happens because we don't have specs for the body param autocompletions for this endpoint, while the _query endpoint does - src/platform/plugins/shared/console/server/lib/spec_definitions/json/overrides/esql.query.json.

Copy link
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for clarification @ElenaStoeva! Approving!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 197.8KB 197.8KB +10.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 4.0MB 4.0MB +10.0B

cc @ElenaStoeva

@ElenaStoeva ElenaStoeva merged commit 1f94e25 into elastic:main Nov 3, 2025
12 checks passed
@ElenaStoeva ElenaStoeva deleted the console/esql-in-async-request branch January 31, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants