[Console] Fix autoselecting last request#218001
Merged
ElenaStoeva merged 2 commits intoelastic:mainfrom May 9, 2025
Merged
Conversation
ElenaStoeva
added
Feature:Console
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
sabarasaba
approved these changes
May 9, 2025
Member
sabarasaba
left a comment
sabarasaba
left a comment
There was a problem hiding this comment.
works well, seems like an ok tradeoff for getting this fixed. Nice job!
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @ElenaStoeva |
kdelemme
pushed a commit
to kdelemme/kibana
that referenced
this pull request
May 9, 2025
Fixes elastic#194257 ## Summary This PR fixes the bug in Console where, if there is a request on the last line of the editor, it gets automatically selected when the editor is open. This is because the cursor is initially placed at the last position of the edition, and if this position turn out to be at the end of the request, the request is selected because the editor is on focus. We fix this by not focusing the editor initially (i.e. there is no blinking cursor when you open the editor) - this ensures that there won't be any initial request highlighting as per the logic on the following line: https://github.com/elastic/kibana/blob/5c78ff18484e77b5ec5a4ba2ab341ed65db4f21c/src/platform/plugins/shared/console/public/application/containers/editor/monaco_editor_actions_provider.ts#L73) https://github.com/user-attachments/assets/6f10e59b-92c7-4501-bf01-54987bc2f289
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
Fixes elastic#194257 ## Summary This PR fixes the bug in Console where, if there is a request on the last line of the editor, it gets automatically selected when the editor is open. This is because the cursor is initially placed at the last position of the edition, and if this position turn out to be at the end of the request, the request is selected because the editor is on focus. We fix this by not focusing the editor initially (i.e. there is no blinking cursor when you open the editor) - this ensures that there won't be any initial request highlighting as per the logic on the following line: https://github.com/elastic/kibana/blob/5c78ff18484e77b5ec5a4ba2ab341ed65db4f21c/src/platform/plugins/shared/console/public/application/containers/editor/monaco_editor_actions_provider.ts#L73) https://github.com/user-attachments/assets/6f10e59b-92c7-4501-bf01-54987bc2f289
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
Fixes elastic#194257 ## Summary This PR fixes the bug in Console where, if there is a request on the last line of the editor, it gets automatically selected when the editor is open. This is because the cursor is initially placed at the last position of the edition, and if this position turn out to be at the end of the request, the request is selected because the editor is on focus. We fix this by not focusing the editor initially (i.e. there is no blinking cursor when you open the editor) - this ensures that there won't be any initial request highlighting as per the logic on the following line: https://github.com/elastic/kibana/blob/5c78ff18484e77b5ec5a4ba2ab341ed65db4f21c/src/platform/plugins/shared/console/public/application/containers/editor/monaco_editor_actions_provider.ts#L73) https://github.com/user-attachments/assets/6f10e59b-92c7-4501-bf01-54987bc2f289
This was referenced Jun 18, 2025
ElenaStoeva
added
backport:version
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/22441787987 |
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/22441788135 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 26, 2026
Fixes elastic#194257 ## Summary This PR fixes the bug in Console where, if there is a request on the last line of the editor, it gets automatically selected when the editor is open. This is because the cursor is initially placed at the last position of the edition, and if this position turn out to be at the end of the request, the request is selected because the editor is on focus. We fix this by not focusing the editor initially (i.e. there is no blinking cursor when you open the editor) - this ensures that there won't be any initial request highlighting as per the logic on the following line: https://github.com/elastic/kibana/blob/5c78ff18484e77b5ec5a4ba2ab341ed65db4f21c/src/platform/plugins/shared/console/public/application/containers/editor/monaco_editor_actions_provider.ts#L73) https://github.com/user-attachments/assets/6f10e59b-92c7-4501-bf01-54987bc2f289 (cherry picked from commit 7be65de)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 26, 2026
Fixes elastic#194257 ## Summary This PR fixes the bug in Console where, if there is a request on the last line of the editor, it gets automatically selected when the editor is open. This is because the cursor is initially placed at the last position of the edition, and if this position turn out to be at the end of the request, the request is selected because the editor is on focus. We fix this by not focusing the editor initially (i.e. there is no blinking cursor when you open the editor) - this ensures that there won't be any initial request highlighting as per the logic on the following line: https://github.com/elastic/kibana/blob/5c78ff18484e77b5ec5a4ba2ab341ed65db4f21c/src/platform/plugins/shared/console/public/application/containers/editor/monaco_editor_actions_provider.ts#L73) https://github.com/user-attachments/assets/6f10e59b-92c7-4501-bf01-54987bc2f289 (cherry picked from commit 7be65de)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 26, 2026
# Backport This will backport the following commits from `main` to `8.19`: - [[Console] Fix autoselecting last request (#218001)](#218001) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"59341489+ElenaStoeva@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-09T12:51:30Z","message":"[Console] Fix autoselecting last request (#218001)\n\nFixes https://github.com/elastic/kibana/issues/194257\n\n## Summary\n\n\nThis PR fixes the bug in Console where, if there is a request on the\nlast line of the editor, it gets automatically selected when the editor\nis open. This is because the cursor is initially placed at the last\nposition of the edition, and if this position turn out to be at the end\nof the request, the request is selected because the editor is on focus.\nWe fix this by not focusing the editor initially (i.e. there is no\nblinking cursor when you open the editor) - this ensures that there\nwon't be any initial request highlighting as per the logic on the\nfollowing line:\nhttps://github.com/elastic/kibana/blob/5c78ff18484e77b5ec5a4ba2ab341ed65db4f21c/src/platform/plugins/shared/console/public/application/containers/editor/monaco_editor_actions_provider.ts#L73)\n\n\n\n\nhttps://github.com/user-attachments/assets/6f10e59b-92c7-4501-bf01-54987bc2f289","sha":"7be65de507d828f508348f7f7b7ad5e1476833f5","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","backport:version","v9.1.0","v8.19.0","v9.4.0"],"title":"[Console] Fix autoselecting last request","number":218001,"url":"https://github.com/elastic/kibana/pull/218001","mergeCommit":{"message":"[Console] Fix autoselecting last request (#218001)\n\nFixes https://github.com/elastic/kibana/issues/194257\n\n## Summary\n\n\nThis PR fixes the bug in Console where, if there is a request on the\nlast line of the editor, it gets automatically selected when the editor\nis open. This is because the cursor is initially placed at the last\nposition of the edition, and if this position turn out to be at the end\nof the request, the request is selected because the editor is on focus.\nWe fix this by not focusing the editor initially (i.e. there is no\nblinking cursor when you open the editor) - this ensures that there\nwon't be any initial request highlighting as per the logic on the\nfollowing line:\nhttps://github.com/elastic/kibana/blob/5c78ff18484e77b5ec5a4ba2ab341ed65db4f21c/src/platform/plugins/shared/console/public/application/containers/editor/monaco_editor_actions_provider.ts#L73)\n\n\n\n\nhttps://github.com/user-attachments/assets/6f10e59b-92c7-4501-bf01-54987bc2f289","sha":"7be65de507d828f508348f7f7b7ad5e1476833f5"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218001","number":218001,"mergeCommit":{"message":"[Console] Fix autoselecting last request (#218001)\n\nFixes https://github.com/elastic/kibana/issues/194257\n\n## Summary\n\n\nThis PR fixes the bug in Console where, if there is a request on the\nlast line of the editor, it gets automatically selected when the editor\nis open. This is because the cursor is initially placed at the last\nposition of the edition, and if this position turn out to be at the end\nof the request, the request is selected because the editor is on focus.\nWe fix this by not focusing the editor initially (i.e. there is no\nblinking cursor when you open the editor) - this ensures that there\nwon't be any initial request highlighting as per the logic on the\nfollowing line:\nhttps://github.com/elastic/kibana/blob/5c78ff18484e77b5ec5a4ba2ab341ed65db4f21c/src/platform/plugins/shared/console/public/application/containers/editor/monaco_editor_actions_provider.ts#L73)\n\n\n\n\nhttps://github.com/user-attachments/assets/6f10e59b-92c7-4501-bf01-54987bc2f289","sha":"7be65de507d828f508348f7f7b7ad5e1476833f5"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #194257
Summary
This PR fixes the bug in Console where, if there is a request on the last line of the editor, it gets automatically selected when the editor is open. This is because the cursor is initially placed at the last position of the edition, and if this position turn out to be at the end of the request, the request is selected because the editor is on focus. We fix this by not focusing the editor initially (i.e. there is no blinking cursor when you open the editor) - this ensures that there won't be any initial request highlighting as per the logic on the following line:
kibana/src/platform/plugins/shared/console/public/application/containers/editor/monaco_editor_actions_provider.ts
Line 73 in 5c78ff1
Screen.Recording.2025-04-11.at.16.19.55.mov