[8.19] [Console] Only show ESQL suggestions in ESQL query request (#240264)#255283
Merged
ElenaStoeva merged 2 commits intoelastic:8.19from Feb 27, 2026
Merged
[8.19] [Console] Only show ESQL suggestions in ESQL query request (#240264)#255283ElenaStoeva merged 2 commits intoelastic:8.19from
ElenaStoeva merged 2 commits intoelastic:8.19from
Conversation
…40264) Closes elastic#225685 ## Summary Previously, ESQL suggestions were shown inside all `query` body params (`"query": "...` or `"query": """...`). However, there are some requests with a `query` body param that don't work with ESLQ (e.g. SQL query). This PR makes sure that ESQL suggestions are only displayed inside `POST _query` request (which is the request for sending ESQL queries). **How to test:** Verify that ESQL suggestions are displayed in `POST _query` requests: ``` POST /_query { "query": "..." } ``` Verify that ESQL suggestions are **not** displayed in any other requests; for example: ``` POST /_sql { "query": "...." } ``` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 7f03a89) # Conflicts: # src/platform/packages/shared/kbn-monaco/src/console/index.ts # src/platform/plugins/shared/console/public/application/containers/editor/monaco_editor_actions_provider.ts
kapral18
approved these changes
Feb 27, 2026
Contributor
💚 Build Succeeded
The CI Stats report is too large to be displayed here, check out the CI build annotation for this information. History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation