Skip to content

[OTel] Only load instrumentation-runtime-node when metrics are enabled#231479

Merged
jbudz merged 1 commit intoelastic:deploy-fix@1754931892from
jbudz:monitoring-disable-otel-node
Aug 12, 2025
Merged

[OTel] Only load instrumentation-runtime-node when metrics are enabled#231479
jbudz merged 1 commit intoelastic:deploy-fix@1754931892from
jbudz:monitoring-disable-otel-node

Conversation

@jbudz
Copy link
Contributor

@jbudz jbudz commented Aug 12, 2025

This rolls back when @opentelemetry/instrumentation-runtime-node is loaded to match the behavior prior to #230465 .

Without this rollback we're seeing a significant (2-3x) increase in startup times.

@jbudz jbudz added ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project ci:project-deploy-observability Create an Observability project labels Aug 12, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@pickypg pickypg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 12, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #46 / Search solution tests Search Home page Solution Nav - Search search home page with existing indices "before each" hook for "displays the feedbacks link"

Metrics [docs]

✅ unchanged

History

@jbudz
Copy link
Contributor Author

jbudz commented Aug 12, 2025

/oblt-deploy

@kobelb kobelb marked this pull request as ready for review August 12, 2025 17:32
@kobelb kobelb requested review from a team as code owners August 12, 2025 17:32
@jbudz jbudz merged commit f1386c7 into elastic:deploy-fix@1754931892 Aug 12, 2025
18 checks passed
jbudz added a commit to jbudz/kibana that referenced this pull request Aug 12, 2025
elastic#231479)

This rolls back when `@opentelemetry/instrumentation-runtime-node` is
loaded to match the behavior prior to [elastic#230465
](https://github.com/elastic/kibana/pull/230465/files#diff-09903975f886a43375599fff16ecf98582125a6705bccdb12ad667da3ba746acL56).

Without this rollback we're seeing a significant (2-3x) increase in
startup times.
jbudz added a commit that referenced this pull request Aug 14, 2025
#231552)

Forward port of #231479

This rolls back when `@opentelemetry/instrumentation-runtime-node` is
loaded to match the behavior prior to
[#230465](https://github.com/elastic/kibana/pull/230465/files#diff-09903975f886a43375599fff16ecf98582125a6705bccdb12ad667da3ba746acL56).

Without this rollback we're seeing a significant (2-3x) increase in
startup times.
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
elastic#231552)

Forward port of elastic#231479

This rolls back when `@opentelemetry/instrumentation-runtime-node` is
loaded to match the behavior prior to
[elastic#230465](https://github.com/elastic/kibana/pull/230465/files#diff-09903975f886a43375599fff16ecf98582125a6705bccdb12ad667da3ba746acL56).

Without this rollback we're seeing a significant (2-3x) increase in
startup times.
qn895 pushed a commit to qn895/kibana that referenced this pull request Aug 26, 2025
elastic#231552)

Forward port of elastic#231479

This rolls back when `@opentelemetry/instrumentation-runtime-node` is
loaded to match the behavior prior to
[elastic#230465](https://github.com/elastic/kibana/pull/230465/files#diff-09903975f886a43375599fff16ecf98582125a6705bccdb12ad667da3ba746acL56).

Without this rollback we're seeing a significant (2-3x) increase in
startup times.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project ci:project-deploy-observability Create an Observability project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants