Skip to content

[OTel] Only load instrumentation-runtime-node when metrics are enabled #231479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbudz merged 1 commit into from
Aug 12, 2025
Merged

[OTel] Only load instrumentation-runtime-node when metrics are enabled #231479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/platform/packages/shared/kbn-telemetry/src/init_telemetry.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ describe('initTelemetry', () => {
telemetry: { enabled: true, tracing: { enabled: false }, metrics: { enabled: false } },
monitoring_collection: { enabled: true },
},
['@opentelemetry/instrumentation-runtime-node'],
[],
],
[
'telemetry metrics and monitoring collection metrics are enabled',
Expand Down
8 changes: 5 additions & 3 deletions src/platform/packages/shared/kbn-telemetry/src/init_telemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,18 @@ export const initTelemetry = (
if (telemetryConfig.metrics.enabled || monitoringCollectionConfig.enabled) {
initMetrics({ resource, metricsConfig: telemetryConfig.metrics, monitoringCollectionConfig });

// Provides metrics about the Event Loop, GC Collector, and Heap stats.
desiredInstrumentations.add('@opentelemetry/instrumentation-runtime-node');

// Uncomment the ones below when we clarify the performance impact of having them enabled
// // HTTP Server and Client durations
// desiredInstrumentations.add('@opentelemetry/instrumentation-http');
// // Undici client's request duration
// desiredInstrumentations.add('@opentelemetry/instrumentation-undici');
}

if (telemetryConfig.metrics.enabled) {
// Provides metrics about the Event Loop, GC Collector, and Heap stats.
desiredInstrumentations.add('@opentelemetry/instrumentation-runtime-node');
}

if (desiredInstrumentations.size > 0) {
// register opted-in EDOT auto-instrumentations (node-runtime, http, hapi, and more)
// https://www.elastic.co/docs/reference/opentelemetry/edot-sdks/nodejs/supported-technologies#instrumentations
Expand Down