Skip to content

[OTel] Only load instrumentation-runtime-node when metrics are enabled#231552

Merged
jbudz merged 1 commit intoelastic:mainfrom
jbudz:forwardport/231479/main
Aug 14, 2025
Merged

[OTel] Only load instrumentation-runtime-node when metrics are enabled#231552
jbudz merged 1 commit intoelastic:mainfrom
jbudz:forwardport/231479/main

Conversation

@jbudz
Copy link
Contributor

@jbudz jbudz commented Aug 12, 2025

Forward port of #231479

This rolls back when @opentelemetry/instrumentation-runtime-node is loaded to match the behavior prior to #230465.

Without this rollback we're seeing a significant (2-3x) increase in startup times.

elastic#231479)

This rolls back when `@opentelemetry/instrumentation-runtime-node` is
loaded to match the behavior prior to [elastic#230465
](https://github.com/elastic/kibana/pull/230465/files#diff-09903975f886a43375599fff16ecf98582125a6705bccdb12ad667da3ba746acL56).

Without this rollback we're seeing a significant (2-3x) increase in
startup times.
@jbudz jbudz added the release_note:skip Skip the PR/issue when compiling release notes label Aug 12, 2025
@jbudz jbudz requested a review from a team as a code owner August 12, 2025 22:05
@jbudz jbudz added the backport:skip This PR does not require backporting label Aug 12, 2025
@jbudz jbudz requested a review from a team as a code owner August 12, 2025 22:05
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

@jbudz jbudz merged commit 5d82874 into elastic:main Aug 14, 2025
19 checks passed
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
elastic#231552)

Forward port of elastic#231479

This rolls back when `@opentelemetry/instrumentation-runtime-node` is
loaded to match the behavior prior to
[elastic#230465](https://github.com/elastic/kibana/pull/230465/files#diff-09903975f886a43375599fff16ecf98582125a6705bccdb12ad667da3ba746acL56).

Without this rollback we're seeing a significant (2-3x) increase in
startup times.
qn895 pushed a commit to qn895/kibana that referenced this pull request Aug 26, 2025
elastic#231552)

Forward port of elastic#231479

This rolls back when `@opentelemetry/instrumentation-runtime-node` is
loaded to match the behavior prior to
[elastic#230465](https://github.com/elastic/kibana/pull/230465/files#diff-09903975f886a43375599fff16ecf98582125a6705bccdb12ad667da3ba746acL56).

Without this rollback we're seeing a significant (2-3x) increase in
startup times.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants