[OTel Metrics] Add compatibility with monitoring_collection #230465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Team:Core
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
pickypg
approved these changes
Aug 4, 2025
Member
pickypg
left a comment
pickypg
left a comment
There was a problem hiding this comment.
LGTM with a comment about the singleton teardown.
x-pack/platform/plugins/private/monitoring_collection/server/plugin.ts
Outdated
Show resolved
Hide resolved
…ithub.com:afharo/kibana into otel/add-compatibility-with-monitoring-collection
…ibility-with-monitoring-collection
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
History
cc @afharo |
gergoabraham
pushed a commit
to gergoabraham/kibana
that referenced
this pull request
Aug 7, 2025
…230465) ## Summary Resolves elastic#230184 Moves the set up of the metric readers defined in the plugin `monitoringCollection` to the `@kbn/metrics` package. This way, both features are supported and can run alongside. I added @elastic/stack-monitoring as a co-owner of the `@kbn/metrics` package to make sure that we don't break their features 😇 ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
3 tasks
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Aug 12, 2025
…lastic#230465)" This reverts commit b943ab9.
jbudz
added a commit
that referenced
this pull request
Aug 12, 2025
#231479) This rolls back when `@opentelemetry/instrumentation-runtime-node` is loaded to match the behavior prior to [#230465 ](https://github.com/elastic/kibana/pull/230465/files#diff-09903975f886a43375599fff16ecf98582125a6705bccdb12ad667da3ba746acL56). Without this rollback we're seeing a significant (2-3x) increase in startup times.
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Aug 12, 2025
elastic#231479) This rolls back when `@opentelemetry/instrumentation-runtime-node` is loaded to match the behavior prior to [elastic#230465 ](https://github.com/elastic/kibana/pull/230465/files#diff-09903975f886a43375599fff16ecf98582125a6705bccdb12ad667da3ba746acL56). Without this rollback we're seeing a significant (2-3x) increase in startup times.
jbudz
added a commit
that referenced
this pull request
Aug 14, 2025
#231552) Forward port of #231479 This rolls back when `@opentelemetry/instrumentation-runtime-node` is loaded to match the behavior prior to [#230465](https://github.com/elastic/kibana/pull/230465/files#diff-09903975f886a43375599fff16ecf98582125a6705bccdb12ad667da3ba746acL56). Without this rollback we're seeing a significant (2-3x) increase in startup times.
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
…230465) ## Summary Resolves elastic#230184 Moves the set up of the metric readers defined in the plugin `monitoringCollection` to the `@kbn/metrics` package. This way, both features are supported and can run alongside. I added @elastic/stack-monitoring as a co-owner of the `@kbn/metrics` package to make sure that we don't break their features 😇 ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
elastic#231552) Forward port of elastic#231479 This rolls back when `@opentelemetry/instrumentation-runtime-node` is loaded to match the behavior prior to [elastic#230465](https://github.com/elastic/kibana/pull/230465/files#diff-09903975f886a43375599fff16ecf98582125a6705bccdb12ad667da3ba746acL56). Without this rollback we're seeing a significant (2-3x) increase in startup times.
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Aug 26, 2025
elastic#231552) Forward port of elastic#231479 This rolls back when `@opentelemetry/instrumentation-runtime-node` is loaded to match the behavior prior to [elastic#230465](https://github.com/elastic/kibana/pull/230465/files#diff-09903975f886a43375599fff16ecf98582125a6705bccdb12ad667da3ba746acL56). Without this rollback we're seeing a significant (2-3x) increase in startup times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #230184
Moves the set up of the metric readers defined in the plugin
monitoringCollectionto the@kbn/metricspackage.This way, both features are supported and can run alongside.
I added @elastic/stack-monitoring as a co-owner of the
@kbn/metricspackage to make sure that we don't break their features 😇Checklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.