[Dataset Quality] Missing logs privilege blocks user flow #229947

mohamedhamed-ahmed · 2025-07-30T11:34:45Z

Summary

The Dataset Quality page was initially introduced with only logs signal type. Later on we introduced the ability to select more types, ex: metrics & traces.

Problem is that some places in the code were not updated to accommodate for this change and were kept under the assumption that the user will always have access to logs.

This led to a blocked user flow whenever the user has access to for example metrics but not logs and this PR fixes this.

💡 Solution

A new initial state machine state initializing has been introduced to lookup all privileges for the known signal types.
This state triggers either:
1. emptyState --> when the user has no authorized signal types
2. main --> old normal flow if the user has at least one authorized type

The Types drop down is hidden if the user has only 1 authorized type

The header message is updated to reflect the authorized signal types

The user ends on an empty state page when no authorized types are available (Warning message udpated to be generic and not only about logs)

🎥 Demo

Screen.Recording.2025-07-30.at.14.09.18.mov

…e-blocks-user-flow

yngrdyn · 2025-07-30T14:25:42Z

x-pack/platform/plugins/shared/dataset_quality/public/hooks/use_empty_state.ts

yngrdyn · 2025-07-31T08:42:33Z

...plugins/shared/dataset_quality/public/components/dataset_quality/empty_state/empty_state.tsx

+  const { canUserMonitorAnyDataset, statsLoading } = useDatasetQualityState();

-  if (!canReadDataset) {
+  if (!statsLoading && !canUserMonitorAnyDataset) {


❤️ Thanks! this avoids the flickering

yngrdyn · 2025-07-31T08:44:40Z

...tform/plugins/shared/dataset_quality/public/components/dataset_quality/warnings/warnings.tsx

        </EuiFlexItem>
      )}
-      {!statsLoading && !canUserReadFailureStore && (
+      {!statsLoading && !canUserReadFailureStore && !noDatasetsAccess && (


[nit] the double negation here makes everything more complex to grasp

yngrdyn · 2025-07-31T09:22:04Z

I skimmed quickly through the code, it looks good in general my only comment would be maybe to hide the alerts creation button when the user doesn't have any privileges over the data set types. wdyt?

mohamedhamed-ahmed · 2025-07-31T10:38:24Z

I skimmed quickly through the code, it looks good in general my only comment would be maybe to hide the alerts creation button when the user doesn't have any privileges over the data set types. wdyt?

I think this makes sense since its useless for a use with no privileges at all 👍

…e-blocks-user-flow

elasticmachine · 2025-07-31T12:39:14Z

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

…e-blocks-user-flow

…er-flow' of https://github.com/mohamedhamed-ahmed/kibana into 229939-dataset-quality-missing-logs-privilege-blocks-user-flow

yngrdyn · 2025-08-01T10:18:27Z

What do you think about adding some e2e tests for this PR?
It'd be nice if we could test the changes that trigger the errors initially, e.g a user without access to logs but with access to metrics

…e-blocks-user-flow

mohamedhamed-ahmed · 2025-08-01T11:00:42Z

What do you think about adding some e2e tests for this PR? It'd be nice if we could test the changes that trigger the errors initially, e.g a user without access to logs but with access to metrics

Was already working on few tests as you put the comment :)

yngrdyn

Great work 🚀
Thanks for addressing this issue

…e-blocks-user-flow

elasticmachine · 2025-08-04T00:21:07Z

💚 Build Succeeded

Buildkite Build
Commit: b9b252c

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`datasetQuality`	819	818	-1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`datasetQuality`	31	33	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`datasetQuality`	418.9KB	421.2KB	+2.3KB

Unknown metric groups

API count

id	before	after	diff
`datasetQuality`	31	33	+2

History

💛 Build #325133 was flaky 55585aa
💔 Build #325106 failed 853d3a3
💔 Build #324807 failed dcb092f
💔 Build #324775 failed 34f9798
💔 Build #324729 failed bba57fe

kibanamachine · 2025-08-04T08:54:32Z

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16718590361

kibanamachine · 2025-08-04T09:01:19Z

💔 All backports failed

Status	Branch	Result
❌	8.19	Backport failed because of merge conflicts You might need to backport the following PRs to 8.19: - [ska] relocate dataset quality api-integration tests (#227826)
❌	9.1	Backport failed because of merge conflicts You might need to backport the following PRs to 9.1: - [Core] Unzyme `src/core/packages/notifications` (#230255) - [Obs AI Assistant] knowledge base UI works offline (#229874) - Update dependency @launchdarkly/node-server-sdk to ^9.10.1 (main) (#230028) - [ML] Remove annotations after Typescript upgrade `5.4.5` (#230181) - [EDR Workflows] Initialize argument selector value (#227463) - [Security Solution] Enable debug logging for Rule Management integration tests (#229185)

Manual backport

To create the backport manually run:

node scripts/backport --pr 229947

Questions ?

Please refer to the Backport tool documentation

…9947) Fixes elastic#229939 ## Summary The Dataset Quality page was initially introduced with only logs signal type. Later on we introduced the ability to select more types, ex: metrics & traces. Problem is that some places in the code were not updated to accommodate for this change and were kept under the assumption that the user will always have access to logs. This led to a blocked user flow whenever the user has access to for example metrics but not logs and this PR fixes this. ## 💡 Solution - **A new initial state machine state `initializing` has been introduced to lookup all privileges for the known signal types**. - **This state triggers either**: 1. `emptyState` --> when the user has no authorized signal types 2. `main` --> old normal flow if the user has at least one authorized type <img width="1239" height="527" alt="Screenshot 2025-07-30 at 12 20 37" src="https://github.com/user-attachments/assets/75f96cc4-bbe2-4295-9ff6-6ab85b85e9ba" /> --- - **The `Types` drop down is hidden if the user has only 1 authorized type** <img width="747" height="111" alt="Screenshot 2025-07-30 at 13 24 22" src="https://github.com/user-attachments/assets/a6107275-57d7-44f6-ac88-069800c3e58d" /> --- - **The header message is updated to reflect the authorized signal types** <img width="839" height="126" alt="Screenshot 2025-07-30 at 13 25 00" src="https://github.com/user-attachments/assets/a56bdb76-6c5e-4bf7-8467-07f77c9b6362" /> --- - **The user ends on an empty state page when no authorized types are available (Warning message udpated to be generic and not only about logs)** <img width="1721" height="836" alt="Screenshot 2025-07-30 at 12 21 03" src="https://github.com/user-attachments/assets/62d3ed5f-3527-4f11-9436-46815f7303e6" /> ## 🎥 Demo https://github.com/user-attachments/assets/05db6626-b4d9-4903-b398-a674562dc6de (cherry picked from commit 96fd2e5) # Conflicts: # x-pack/platform/plugins/private/translations/translations/de-DE.json

mohamedhamed-ahmed · 2025-08-04T11:25:00Z

💚 All backports created successfully

Status	Branch	Result
✅	9.1
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…9947) Fixes elastic#229939 ## Summary The Dataset Quality page was initially introduced with only logs signal type. Later on we introduced the ability to select more types, ex: metrics & traces. Problem is that some places in the code were not updated to accommodate for this change and were kept under the assumption that the user will always have access to logs. This led to a blocked user flow whenever the user has access to for example metrics but not logs and this PR fixes this. ## 💡 Solution - **A new initial state machine state `initializing` has been introduced to lookup all privileges for the known signal types**. - **This state triggers either**: 1. `emptyState` --> when the user has no authorized signal types 2. `main` --> old normal flow if the user has at least one authorized type <img width="1239" height="527" alt="Screenshot 2025-07-30 at 12 20 37" src="https://github.com/user-attachments/assets/75f96cc4-bbe2-4295-9ff6-6ab85b85e9ba" /> --- - **The `Types` drop down is hidden if the user has only 1 authorized type** <img width="747" height="111" alt="Screenshot 2025-07-30 at 13 24 22" src="https://github.com/user-attachments/assets/a6107275-57d7-44f6-ac88-069800c3e58d" /> --- - **The header message is updated to reflect the authorized signal types** <img width="839" height="126" alt="Screenshot 2025-07-30 at 13 25 00" src="https://github.com/user-attachments/assets/a56bdb76-6c5e-4bf7-8467-07f77c9b6362" /> --- - **The user ends on an empty state page when no authorized types are available (Warning message udpated to be generic and not only about logs)** <img width="1721" height="836" alt="Screenshot 2025-07-30 at 12 21 03" src="https://github.com/user-attachments/assets/62d3ed5f-3527-4f11-9436-46815f7303e6" /> ## 🎥 Demo https://github.com/user-attachments/assets/05db6626-b4d9-4903-b398-a674562dc6de (cherry picked from commit 96fd2e5) # Conflicts: # x-pack/platform/plugins/private/translations/translations/de-DE.json # x-pack/platform/plugins/shared/dataset_quality/public/components/dataset_quality/filters/filters.tsx # x-pack/platform/plugins/shared/dataset_quality/public/components/dataset_quality/header.tsx # x-pack/platform/plugins/shared/dataset_quality/public/hooks/use_dataset_quality_filters.ts # x-pack/platform/plugins/shared/dataset_quality/public/state_machines/dataset_quality_controller/src/state_machine.ts # x-pack/solutions/observability/test/functional/page_objects/dataset_quality.ts # x-pack/test/dataset_quality_api_integration/tests/data_streams/stats.spec.ts # x-pack/test/dataset_quality_api_integration/tests/data_streams/types_privileges.spec.ts

…9947) Fixes elastic#229939 ## Summary The Dataset Quality page was initially introduced with only logs signal type. Later on we introduced the ability to select more types, ex: metrics & traces. Problem is that some places in the code were not updated to accommodate for this change and were kept under the assumption that the user will always have access to logs. This led to a blocked user flow whenever the user has access to for example metrics but not logs and this PR fixes this. ## 💡 Solution - **A new initial state machine state `initializing` has been introduced to lookup all privileges for the known signal types**. - **This state triggers either**: 1. `emptyState` --> when the user has no authorized signal types 2. `main` --> old normal flow if the user has at least one authorized type <img width="1239" height="527" alt="Screenshot 2025-07-30 at 12 20 37" src="https://github.com/user-attachments/assets/75f96cc4-bbe2-4295-9ff6-6ab85b85e9ba" /> --- - **The `Types` drop down is hidden if the user has only 1 authorized type** <img width="747" height="111" alt="Screenshot 2025-07-30 at 13 24 22" src="https://github.com/user-attachments/assets/a6107275-57d7-44f6-ac88-069800c3e58d" /> --- - **The header message is updated to reflect the authorized signal types** <img width="839" height="126" alt="Screenshot 2025-07-30 at 13 25 00" src="https://github.com/user-attachments/assets/a56bdb76-6c5e-4bf7-8467-07f77c9b6362" /> --- - **The user ends on an empty state page when no authorized types are available (Warning message udpated to be generic and not only about logs)** <img width="1721" height="836" alt="Screenshot 2025-07-30 at 12 21 03" src="https://github.com/user-attachments/assets/62d3ed5f-3527-4f11-9436-46815f7303e6" /> ## 🎥 Demo https://github.com/user-attachments/assets/05db6626-b4d9-4903-b398-a674562dc6de

…9947) (#230394) # Backport This will backport the following commits from `main` to `8.19`: - [[Dataset Quality] Missing logs privilege blocks user flow (#229947)](#229947)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2025-08-05T09:48:51Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @mohamedhamed-ahmed

) (#230389) # Backport This will backport the following commits from `main` to `9.1`: - [[Dataset Quality] Missing logs privilege blocks user flow (#229947)](#229947)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

…9947) Fixes elastic#229939 ## Summary The Dataset Quality page was initially introduced with only logs signal type. Later on we introduced the ability to select more types, ex: metrics & traces. Problem is that some places in the code were not updated to accommodate for this change and were kept under the assumption that the user will always have access to logs. This led to a blocked user flow whenever the user has access to for example metrics but not logs and this PR fixes this. ## 💡 Solution - **A new initial state machine state `initializing` has been introduced to lookup all privileges for the known signal types**. - **This state triggers either**: 1. `emptyState` --> when the user has no authorized signal types 2. `main` --> old normal flow if the user has at least one authorized type <img width="1239" height="527" alt="Screenshot 2025-07-30 at 12 20 37" src="https://github.com/user-attachments/assets/75f96cc4-bbe2-4295-9ff6-6ab85b85e9ba" /> --- - **The `Types` drop down is hidden if the user has only 1 authorized type** <img width="747" height="111" alt="Screenshot 2025-07-30 at 13 24 22" src="https://github.com/user-attachments/assets/a6107275-57d7-44f6-ac88-069800c3e58d" /> --- - **The header message is updated to reflect the authorized signal types** <img width="839" height="126" alt="Screenshot 2025-07-30 at 13 25 00" src="https://github.com/user-attachments/assets/a56bdb76-6c5e-4bf7-8467-07f77c9b6362" /> --- - **The user ends on an empty state page when no authorized types are available (Warning message udpated to be generic and not only about logs)** <img width="1721" height="836" alt="Screenshot 2025-07-30 at 12 21 03" src="https://github.com/user-attachments/assets/62d3ed5f-3527-4f11-9436-46815f7303e6" /> ## 🎥 Demo https://github.com/user-attachments/assets/05db6626-b4d9-4903-b398-a674562dc6de

[Dataset Quality] Missing logs privilege blocks user flow

bba57fe

mohamedhamed-ahmed added 3 commits July 30, 2025 15:23

Fix Types

5b73932

Merge branch 'main' into 229939-dataset-quality-missing-logs-privileg…

34f9798

…e-blocks-user-flow

Fix Types

dcb092f

yngrdyn reviewed Jul 30, 2025

View reviewed changes

x-pack/platform/plugins/shared/dataset_quality/public/hooks/use_empty_state.ts

Copy link

Contributor

yngrdyn Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

yngrdyn reviewed Jul 31, 2025

View reviewed changes

mohamedhamed-ahmed added 3 commits July 31, 2025 12:38

Merge branch 'main' into 229939-dataset-quality-missing-logs-privileg…

f2ec4c2

…e-blocks-user-flow

Fix Comments

853d3a3

Fix Tests

2da5c5a

mohamedhamed-ahmed marked this pull request as ready for review July 31, 2025 12:39

mohamedhamed-ahmed requested a review from a team as a code owner July 31, 2025 12:39

mohamedhamed-ahmed added 2 commits July 31, 2025 15:26

Merge branch 'main' into 229939-dataset-quality-missing-logs-privileg…

542d901

…e-blocks-user-flow

Merge branch '229939-dataset-quality-missing-logs-privilege-blocks-us…

55585aa

…er-flow' of https://github.com/mohamedhamed-ahmed/kibana into 229939-dataset-quality-missing-logs-privilege-blocks-user-flow

mohamedhamed-ahmed removed the v8.18.0 label Jul 31, 2025

mohamedhamed-ahmed added 3 commits August 1, 2025 12:54

Add Tests

91bf751

Merge branch 'main' into 229939-dataset-quality-missing-logs-privileg…

8650589

…e-blocks-user-flow

Add Tests

5f46cc8

mohamedhamed-ahmed requested a review from yngrdyn August 1, 2025 11:01

yngrdyn approved these changes Aug 1, 2025

View reviewed changes

Merge branch 'main' into 229939-dataset-quality-missing-logs-privileg…

b9b252c

…e-blocks-user-flow

mohamedhamed-ahmed merged commit 96fd2e5 into elastic:main Aug 4, 2025
12 checks passed

kibanamachine added the v9.2.0 label Aug 4, 2025

mohamedhamed-ahmed mentioned this pull request Aug 4, 2025

[9.1] [Dataset Quality] Missing logs privilege blocks user flow (#229947) #230389

Merged

mohamedhamed-ahmed mentioned this pull request Aug 4, 2025

[8.19] [Dataset Quality] Missing logs privilege blocks user flow (#229947) #230394

Merged

kibanamachine mentioned this pull request Aug 4, 2025

Fix violations of the @elastic/eui/require-aria-label-for-modals ESLint rule (Step 3) #229616

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 5, 2025

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 5, 2025

wildemat mentioned this pull request Aug 7, 2025

pr 230826 #231022

Closed

10 tasks

mistic added v9.1.2 v8.19.2 and removed v9.1.0 v8.19.0 labels Aug 7, 2025

[Dataset Quality] Missing logs privilege blocks user flow #229947

[Dataset Quality] Missing logs privilege blocks user flow #229947

Uh oh!

Conversation

mohamedhamed-ahmed commented Jul 30, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

💡 Solution

🎥 Demo

Uh oh!

yngrdyn Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

yngrdyn Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

yngrdyn Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

yngrdyn commented Jul 31, 2025

Uh oh!

mohamedhamed-ahmed commented Jul 31, 2025

Uh oh!

elasticmachine commented Jul 31, 2025

Uh oh!

yngrdyn commented Aug 1, 2025

Uh oh!

mohamedhamed-ahmed commented Aug 1, 2025

Uh oh!

yngrdyn left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Aug 4, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

API count

History

Uh oh!

Uh oh!

kibanamachine commented Aug 4, 2025

Uh oh!

kibanamachine commented Aug 4, 2025

💔 All backports failed

Manual backport

Questions ?

Uh oh!

mohamedhamed-ahmed commented Aug 4, 2025

💚 All backports created successfully

Questions ?

Uh oh!

kibanamachine commented Aug 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mohamedhamed-ahmed commented Jul 30, 2025 •

edited by kibanamachine

Loading