Skip to content

[ML] Remove annotations after Typescript upgrade 5.4.5 #230181

Merged
rbrtj merged 1 commit intoelastic:mainfrom
rbrtj:ml-remove-typescript-annotations
Aug 1, 2025
Merged

[ML] Remove annotations after Typescript upgrade 5.4.5 #230181
rbrtj merged 1 commit intoelastic:mainfrom
rbrtj:ml-remove-typescript-annotations

Conversation

@rbrtj
Copy link
Copy Markdown
Contributor

@rbrtj rbrtj commented Aug 1, 2025 •
edited by kibanamachine
Loading

Removes TS annotations after #227746

@rbrtj rbrtj self-assigned this Aug 1, 2025
@rbrtj rbrtj requested a review from a team as a code owner August 1, 2025 10:01
@rbrtj rbrtj added :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) t// backport:version Backport to applied version labels v9.2.0 v9.1.1 v8.19.1 labels Aug 1, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 1, 2025

Pinging @elastic/ml-ui (:ml)

@rbrtj rbrtj mentioned this pull request Aug 1, 2025
Closed
peteharverson
peteharverson approved these changes Aug 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 1, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.3MB 5.3MB -125.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
ml 571 569 -2

Total ESLint disabled count

id before after diff
ml 574 572 -2

cc @rbrtj

@rbrtj rbrtj merged commit 8973166 into elastic:main Aug 1, 2025
28 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 1, 2025

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16675836048

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 1, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- chore(NA): upgrade typescript into v5.4.5 (#227746)
❌ 9.1 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.1:
- chore(NA): upgrade typescript into v5.4.5 (#227746)

Manual backport

To create the backport manually run:

node scripts/backport --pr 230181

Questions ?

Please refer to the Backport tool documentation

This was referenced Aug 4, 2025
Merged
Merged
szaffarano pushed a commit to szaffarano/kibana that referenced this pull request Aug 5, 2025
@rbrtj @szaffarano
[ML] Remove annotations after Typescript upgrade 5.4.5 (elastic#230181
08fd55a 
)

Removes TS annotations after
elastic#227746
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 5, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 5, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 230181 locally
cc: @rbrtj

delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
@rbrtj @delanni
[ML] Remove annotations after Typescript upgrade 5.4.5 (elastic#230181
27a98b8 
)

Removes TS annotations after
elastic#227746
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 6, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 230181 locally
cc: @rbrtj

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 7, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 230181 locally
cc: @rbrtj

@wildemat wildemat mentioned this pull request Aug 7, 2025
Closed
10 tasks
@rbrtj rbrtj added backport:version Backport to applied version labels and removed backport:version Backport to applied version labels labels Aug 8, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 8, 2025

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16830876524

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 8, 2025
@rbrtj
[ML] Remove annotations after Typescript upgrade 5.4.5 (elastic#230181
03433ec 
)

Removes TS annotations after
elastic#227746

(cherry picked from commit 8973166)
@kibanamachine kibanamachine mentioned this pull request Aug 8, 2025
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 8, 2025
@rbrtj
[ML] Remove annotations after Typescript upgrade 5.4.5 (elastic#230181
a16a76a 
)

Removes TS annotations after
elastic#227746

(cherry picked from commit 8973166)
@kibanamachine kibanamachine mentioned this pull request Aug 8, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 8, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19
✅ 9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 8, 2025
@kibanamachine @rbrtj
[9.1] [ML] Remove annotations after Typescript upgrade 5.4.5 (#230181…
cff87d6 
…) (#231148)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[ML] Remove annotations after Typescript upgrade `5.4.5`
(#230181)](#230181)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-08-01T13:05:39Z","message":"[ML]
Remove annotations after Typescript upgrade `5.4.5` (#230181)\n\nRemoves
TS annotations
after\nhttps://github.com//pull/227746","sha":"8973166625c2207fb7b90deda5669d23f9afdbee","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","backport
missing","Team:ML","backport:version","v9.2.0","v9.1.1","v8.19.1"],"title":"[ML]
Remove annotations after Typescript upgrade `5.4.5`
","number":230181,"url":"https://github.com/elastic/kibana/pull/230181","mergeCommit":{"message":"[ML]
Remove annotations after Typescript upgrade `5.4.5` (#230181)\n\nRemoves
TS annotations
after\nhttps://github.com//pull/227746","sha":"8973166625c2207fb7b90deda5669d23f9afdbee"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230181","number":230181,"mergeCommit":{"message":"[ML]
Remove annotations after Typescript upgrade `5.4.5` (#230181)\n\nRemoves
TS annotations
after\nhttps://github.com//pull/227746","sha":"8973166625c2207fb7b90deda5669d23f9afdbee"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Aug 11, 2025
@kibanamachine @rbrtj
[8.19] [ML] Remove annotations after Typescript upgrade 5.4.5 (#230181
832683f 
) (#231147)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[ML] Remove annotations after Typescript upgrade `5.4.5`
(#230181)](#230181)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-08-01T13:05:39Z","message":"[ML]
Remove annotations after Typescript upgrade `5.4.5` (#230181)\n\nRemoves
TS annotations
after\nhttps://github.com//pull/227746","sha":"8973166625c2207fb7b90deda5669d23f9afdbee","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","backport
missing","Team:ML","backport:version","v9.2.0","v9.1.1","v8.19.1"],"title":"[ML]
Remove annotations after Typescript upgrade `5.4.5`
","number":230181,"url":"https://github.com/elastic/kibana/pull/230181","mergeCommit":{"message":"[ML]
Remove annotations after Typescript upgrade `5.4.5` (#230181)\n\nRemoves
TS annotations
after\nhttps://github.com//pull/227746","sha":"8973166625c2207fb7b90deda5669d23f9afdbee"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230181","number":230181,"mergeCommit":{"message":"[ML]
Remove annotations after Typescript upgrade `5.4.5` (#230181)\n\nRemoves
TS annotations
after\nhttps://github.com//pull/227746","sha":"8973166625c2207fb7b90deda5669d23f9afdbee"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
@kibanamachine kibanamachine added v8.19.2 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Aug 11, 2025
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
@rbrtj @NicholasPeretti
[ML] Remove annotations after Typescript upgrade 5.4.5 (elastic#230181
74989dd 
)

Removes TS annotations after
elastic#227746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peteharverson peteharverson peteharverson approved these changes

Assignees

@rbrtj rbrtj

Labels

backport:version Backport to applied version labels :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) t// v8.19.1 v8.19.2 v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rbrtj @elasticmachine @kibanamachine @peteharverson