[8.19] [Dataset Quality] Missing logs privilege blocks user flow (#229947) #230394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9947) Fixes elastic#229939 ## Summary The Dataset Quality page was initially introduced with only logs signal type. Later on we introduced the ability to select more types, ex: metrics & traces. Problem is that some places in the code were not updated to accommodate for this change and were kept under the assumption that the user will always have access to logs. This led to a blocked user flow whenever the user has access to for example metrics but not logs and this PR fixes this. ## 💡 Solution - **A new initial state machine state `initializing` has been introduced to lookup all privileges for the known signal types**. - **This state triggers either**: 1. `emptyState` --> when the user has no authorized signal types 2. `main` --> old normal flow if the user has at least one authorized type <img width="1239" height="527" alt="Screenshot 2025-07-30 at 12 20 37" src="https://github.com/user-attachments/assets/75f96cc4-bbe2-4295-9ff6-6ab85b85e9ba" /> --- - **The `Types` drop down is hidden if the user has only 1 authorized type** <img width="747" height="111" alt="Screenshot 2025-07-30 at 13 24 22" src="https://github.com/user-attachments/assets/a6107275-57d7-44f6-ac88-069800c3e58d" /> --- - **The header message is updated to reflect the authorized signal types** <img width="839" height="126" alt="Screenshot 2025-07-30 at 13 25 00" src="https://github.com/user-attachments/assets/a56bdb76-6c5e-4bf7-8467-07f77c9b6362" /> --- - **The user ends on an empty state page when no authorized types are available (Warning message udpated to be generic and not only about logs)** <img width="1721" height="836" alt="Screenshot 2025-07-30 at 12 21 03" src="https://github.com/user-attachments/assets/62d3ed5f-3527-4f11-9436-46815f7303e6" /> ## 🎥 Demo https://github.com/user-attachments/assets/05db6626-b4d9-4903-b398-a674562dc6de (cherry picked from commit 96fd2e5) # Conflicts: # x-pack/platform/plugins/private/translations/translations/de-DE.json # x-pack/platform/plugins/shared/dataset_quality/public/components/dataset_quality/filters/filters.tsx # x-pack/platform/plugins/shared/dataset_quality/public/components/dataset_quality/header.tsx # x-pack/platform/plugins/shared/dataset_quality/public/hooks/use_dataset_quality_filters.ts # x-pack/platform/plugins/shared/dataset_quality/public/state_machines/dataset_quality_controller/src/state_machine.ts # x-pack/solutions/observability/test/functional/page_objects/dataset_quality.ts # x-pack/test/dataset_quality_api_integration/tests/data_streams/stats.spec.ts # x-pack/test/dataset_quality_api_integration/tests/data_streams/types_privileges.spec.ts
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
History
|
yngrdyn
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation