Skip to content

[Core] Unzyme src/core/packages/notifications :shipit: #230255

Merged
jesuswr merged 9 commits intoelastic:mainfrom
jesuswr:core-unzyme-224001
Aug 1, 2025
Merged

[Core] Unzyme src/core/packages/notifications :shipit: #230255
jesuswr merged 9 commits intoelastic:mainfrom
jesuswr:core-unzyme-224001

Conversation

@jesuswr
Copy link
Member

@jesuswr jesuswr commented Aug 1, 2025 •
edited by kibanamachine
Loading

Summary

Resolves #224001

@jesuswr jesuswr self-assigned this Aug 1, 2025
@jesuswr jesuswr marked this pull request as ready for review August 1, 2025 15:05
@jesuswr jesuswr requested a review from a team as a code owner August 1, 2025 15:05
@jesuswr jesuswr changed the title Core unzyme 224001 [Core] Unzyme src/core/packages/notifications Aug 1, 2025
@jesuswr jesuswr changed the title [Core] Unzyme src/core/packages/notifications [Core] Unzyme src/core/packages/notifications :shipit: Aug 1, 2025
@jesuswr jesuswr added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// technical debt Improvement of the software architecture and operational architecture backport:prev-minor labels Aug 1, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 1, 2025

Pinging @elastic/kibana-core (Team:Core)

@jesuswr jesuswr removed the backport:skip This PR does not require backporting label Aug 1, 2025
@jesuswr jesuswr requested a review from dokmic August 1, 2025 16:01
dokmic
dokmic approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@dokmic dokmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job👏 LGTM

@jesuswr jesuswr enabled auto-merge (squash) August 1, 2025 16:51
@jesuswr jesuswr merged commit 929a67b into elastic:main Aug 1, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 1, 2025

Starting backport for target branches: 9.1

https://github.com/elastic/kibana/actions/runs/16681768452

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 1, 2025

💚 Build Succeeded

Metrics [docs]

Count of Enzyme imports

Enzyme is no longer supported, and we should switch to @testing-library/react instead.

id before after diff
@kbn/core-notifications-browser-internal 2 0 -2

cc @jesuswr

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 1, 2025
@jesuswr @kibanamachine
[Core] Unzyme src/core/packages/notifications :shipit: (elastic#230255)
c9b5713 
## Summary

Resolves elastic#224001

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 929a67b)
@kibanamachine kibanamachine mentioned this pull request Aug 1, 2025
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 1, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

This was referenced Aug 4, 2025
Merged
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 4, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 4, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @jesuswr

szaffarano pushed a commit to szaffarano/kibana that referenced this pull request Aug 5, 2025
@jesuswr @kibanamachine @szaffarano
[Core] Unzyme src/core/packages/notifications :shipit: (elastic#230255)
dc71291 
## Summary

Resolves elastic#224001

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Aug 5, 2025
@kibanamachine @jesuswr
[9.1] [Core] Unzyme src/core/packages/notifications :shipit: (#230255) (#2…
c9e99f2 
…30291)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Core] Unzyme `src/core/packages/notifications` :shipit:
(#230255)](#230255)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jesus
Wahrman","email":"41008968+jesuswr@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-08-01T17:54:13Z","message":"[Core]
Unzyme `src/core/packages/notifications` :shipit: (#230255)\n\n##
Summary\n\nResolves
https://github.com/elastic/kibana/issues/224001\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"929a67b5f76b6864d71c1e6dce17c15a8077ec98","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","technical
debt","release_note:skip","backport:prev-minor","v9.2.0"],"title":"[Core]
Unzyme `src/core/packages/notifications` :shipit:
","number":230255,"url":"https://github.com/elastic/kibana/pull/230255","mergeCommit":{"message":"[Core]
Unzyme `src/core/packages/notifications` :shipit: (#230255)\n\n##
Summary\n\nResolves
https://github.com/elastic/kibana/issues/224001\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"929a67b5f76b6864d71c1e6dce17c15a8077ec98"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230255","number":230255,"mergeCommit":{"message":"[Core]
Unzyme `src/core/packages/notifications` :shipit: (#230255)\n\n##
Summary\n\nResolves
https://github.com/elastic/kibana/issues/224001\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"929a67b5f76b6864d71c1e6dce17c15a8077ec98"}}]}]
BACKPORT-->

Co-authored-by: Jesus Wahrman <41008968+jesuswr@users.noreply.github.com>
@kibanamachine kibanamachine added v9.1.1 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Aug 5, 2025
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
@jesuswr @kibanamachine @delanni
[Core] Unzyme src/core/packages/notifications :shipit: (elastic#230255)
60ce534 
## Summary

Resolves elastic#224001

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@wildemat wildemat mentioned this pull request Aug 7, 2025
Closed
10 tasks
@mistic mistic added v9.1.2 and removed v9.1.1 labels Aug 7, 2025
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
@jesuswr @kibanamachine @NicholasPeretti
[Core] Unzyme src/core/packages/notifications :shipit: (elastic#230255)
783d0f2 
## Summary

Resolves elastic#224001

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dokmic dokmic dokmic approved these changes

Assignees

@jesuswr jesuswr

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// technical debt Improvement of the software architecture and operational architecture v9.1.2 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Unzyme] src/core/packages/notifications

5 participants

@jesuswr @elasticmachine @kibanamachine @dokmic @mistic