Skip to content

Comments

[8.19] [ska] remove 'test-suites-xpack-observability' imports in x-pack/test (#226174)#226772

Merged
dmlemeshko merged 2 commits intoelastic:8.19from
dmlemeshko:backport/8.19/pr-226174
Jul 7, 2025
Merged

[8.19] [ska] remove 'test-suites-xpack-observability' imports in x-pack/test (#226174)#226772
dmlemeshko merged 2 commits intoelastic:8.19from
dmlemeshko:backport/8.19/pr-226174

Conversation

@dmlemeshko
Copy link
Contributor

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

…elastic#226174)

## Summary

PR is a temporarily workaround to unblock us with SKA test relocation.

In one of my previous PRs to avoid code duplication I updated imports to
use newly created `@kbn/test-suites-xpack-observability` module, sadly
it led to circular dependency issue in test modules. Here I copy some
helpers back to x-pack/test to unblock us, will be removed when we done
with tests relocation.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 9426c26)

# Conflicts:
#	.github/CODEOWNERS
@dmlemeshko dmlemeshko requested a review from kibanamachine as a code owner July 7, 2025 10:56
@dmlemeshko dmlemeshko added the backport This PR is a backport of another PR label Jul 7, 2025
@dmlemeshko dmlemeshko enabled auto-merge (squash) July 7, 2025 10:56
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Jul 7, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@dmlemeshko dmlemeshko requested a review from fake-haris July 7, 2025 10:56
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 7, 2025

💚 Build Succeeded

  • Buildkite Build
  • Commit: 559f2d1
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-226772-559f2d18c12b

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/test-suites-xpack 220 221 +1

Total ESLint disabled count

id before after diff
@kbn/test-suites-xpack 235 236 +1

History

@dmlemeshko dmlemeshko merged commit 4dd1ebb into elastic:8.19 Jul 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants