[ska] remove 'kbn/test-suites-xpack-security' imports from x-pack/serverless#226185
Closed
dmlemeshko wants to merge 2 commits intoelastic:mainfrom
Closed
[ska] remove 'kbn/test-suites-xpack-security' imports from x-pack/serverless#226185dmlemeshko wants to merge 2 commits intoelastic:mainfrom
dmlemeshko wants to merge 2 commits intoelastic:mainfrom
Conversation
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Contributor
💔 Build Failed
Failed CI StepsHistory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It is pretty similar to #226174
Having
@kbn/test-suites-xpack-securityimports inx-pack/test_serverlesscreates circular dependency as soon as we try relocating security solution tests with imports from@kbn/test-suites-xpack-serverless.In oder to proceed with SKA test relocation we have to duplicate some helpers/page objects back to
x-pack/test_serverlessuntil we move all those tests underx-pack/solutions/security/testdir.