update adm-zip dependency to 0.5.16#219079
Merged
klacabane merged 29 commits intoelastic:mainfrom Jul 3, 2025
Merged
Conversation
This reverts commit ab5d63f.
klacabane
commented
Apr 26, 2025
Comment on lines
+12
to
+14
| globals: { | ||
| Uint8Array: Uint8Array, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
See jestjs/jest#4422
Without setting this global this condition fails because Uint8Array types are different, which in turn fails the tests
I've attempted to set once in the root jest config but ended up with a lot of unrelated tests failing, so I opted for setting it on specific configs instead
klacabane
added
release_note:skip
klacabane
changed the title
klacabane
added
backport:skip
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16054939490 |
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16054939481 |
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16054939474 |
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16054939486 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 3, 2025
## Summary Update adm-zip dependency from v0.5.9 to v0.5.16 which brings additional safety mechanism around zip files manipulation **Files using adm-zip** - [x] `x-pack/packages/ai-infra/product-doc-artifact-builder/src/tasks/create_artifact.ts` - @elastic/appex-ai-infra - [x] `x-pack/platform/plugins/shared/automatic_import/server/integration_builder/build_integration.ts` - @elastic/security-scalability - [x] `x-pack/solutions/observability/plugins/synthetics/server/common/unzip_project_code.ts` - @elastic/obs-ux-management-team - [x] `x-pack/solutions/security/plugins/security_solution/server/lib/telemetry/artifact.ts` - @elastic/security-data-analytics - [x] `x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_reindex_to_fix_sparse_vector_support.spec.ts` - @elastic/obs-ai-assistant - [x] `x-pack/platform/plugins/shared/streams/server/lib/content/archive.ts` - @elastic/obs-entities I've requested an explicit approval for the owners of the file mentioned above since I don't know if a failure in the paths using the library would be covered by integration tests --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co> (cherry picked from commit 193eb33)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 3, 2025
## Summary Update adm-zip dependency from v0.5.9 to v0.5.16 which brings additional safety mechanism around zip files manipulation **Files using adm-zip** - [x] `x-pack/packages/ai-infra/product-doc-artifact-builder/src/tasks/create_artifact.ts` - @elastic/appex-ai-infra - [x] `x-pack/platform/plugins/shared/automatic_import/server/integration_builder/build_integration.ts` - @elastic/security-scalability - [x] `x-pack/solutions/observability/plugins/synthetics/server/common/unzip_project_code.ts` - @elastic/obs-ux-management-team - [x] `x-pack/solutions/security/plugins/security_solution/server/lib/telemetry/artifact.ts` - @elastic/security-data-analytics - [x] `x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_reindex_to_fix_sparse_vector_support.spec.ts` - @elastic/obs-ai-assistant - [x] `x-pack/platform/plugins/shared/streams/server/lib/content/archive.ts` - @elastic/obs-entities I've requested an explicit approval for the owners of the file mentioned above since I don't know if a failure in the paths using the library would be covered by integration tests --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co> (cherry picked from commit 193eb33)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 3, 2025
## Summary Update adm-zip dependency from v0.5.9 to v0.5.16 which brings additional safety mechanism around zip files manipulation **Files using adm-zip** - [x] `x-pack/packages/ai-infra/product-doc-artifact-builder/src/tasks/create_artifact.ts` - @elastic/appex-ai-infra - [x] `x-pack/platform/plugins/shared/automatic_import/server/integration_builder/build_integration.ts` - @elastic/security-scalability - [x] `x-pack/solutions/observability/plugins/synthetics/server/common/unzip_project_code.ts` - @elastic/obs-ux-management-team - [x] `x-pack/solutions/security/plugins/security_solution/server/lib/telemetry/artifact.ts` - @elastic/security-data-analytics - [x] `x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_reindex_to_fix_sparse_vector_support.spec.ts` - @elastic/obs-ai-assistant - [x] `x-pack/platform/plugins/shared/streams/server/lib/content/archive.ts` - @elastic/obs-entities I've requested an explicit approval for the owners of the file mentioned above since I don't know if a failure in the paths using the library would be covered by integration tests --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co> (cherry picked from commit 193eb33)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 3, 2025
## Summary Update adm-zip dependency from v0.5.9 to v0.5.16 which brings additional safety mechanism around zip files manipulation **Files using adm-zip** - [x] `x-pack/packages/ai-infra/product-doc-artifact-builder/src/tasks/create_artifact.ts` - @elastic/appex-ai-infra - [x] `x-pack/platform/plugins/shared/automatic_import/server/integration_builder/build_integration.ts` - @elastic/security-scalability - [x] `x-pack/solutions/observability/plugins/synthetics/server/common/unzip_project_code.ts` - @elastic/obs-ux-management-team - [x] `x-pack/solutions/security/plugins/security_solution/server/lib/telemetry/artifact.ts` - @elastic/security-data-analytics - [x] `x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_reindex_to_fix_sparse_vector_support.spec.ts` - @elastic/obs-ai-assistant - [x] `x-pack/platform/plugins/shared/streams/server/lib/content/archive.ts` - @elastic/obs-entities I've requested an explicit approval for the owners of the file mentioned above since I don't know if a failure in the paths using the library would be covered by integration tests --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co> (cherry picked from commit 193eb33)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 3, 2025
## Summary Update adm-zip dependency from v0.5.9 to v0.5.16 which brings additional safety mechanism around zip files manipulation **Files using adm-zip** - [x] `x-pack/packages/ai-infra/product-doc-artifact-builder/src/tasks/create_artifact.ts` - @elastic/appex-ai-infra - [x] `x-pack/platform/plugins/shared/automatic_import/server/integration_builder/build_integration.ts` - @elastic/security-scalability - [x] `x-pack/solutions/observability/plugins/synthetics/server/common/unzip_project_code.ts` - @elastic/obs-ux-management-team - [x] `x-pack/solutions/security/plugins/security_solution/server/lib/telemetry/artifact.ts` - @elastic/security-data-analytics - [x] `x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_reindex_to_fix_sparse_vector_support.spec.ts` - @elastic/obs-ai-assistant - [x] `x-pack/platform/plugins/shared/streams/server/lib/content/archive.ts` - @elastic/obs-entities I've requested an explicit approval for the owners of the file mentioned above since I don't know if a failure in the paths using the library would be covered by integration tests --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co> (cherry picked from commit 193eb33)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 3, 2025
## Summary Update adm-zip dependency from v0.5.9 to v0.5.16 which brings additional safety mechanism around zip files manipulation **Files using adm-zip** - [x] `x-pack/packages/ai-infra/product-doc-artifact-builder/src/tasks/create_artifact.ts` - @elastic/appex-ai-infra - [x] `x-pack/platform/plugins/shared/automatic_import/server/integration_builder/build_integration.ts` - @elastic/security-scalability - [x] `x-pack/solutions/observability/plugins/synthetics/server/common/unzip_project_code.ts` - @elastic/obs-ux-management-team - [x] `x-pack/solutions/security/plugins/security_solution/server/lib/telemetry/artifact.ts` - @elastic/security-data-analytics - [x] `x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_reindex_to_fix_sparse_vector_support.spec.ts` - @elastic/obs-ai-assistant - [x] `x-pack/platform/plugins/shared/streams/server/lib/content/archive.ts` - @elastic/obs-entities I've requested an explicit approval for the owners of the file mentioned above since I don't know if a failure in the paths using the library would be covered by integration tests --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co> (cherry picked from commit 193eb33)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 3, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [update adm-zip dependency to 0.5.16 (#219079)](#219079) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kevin Lacabane","email":"kevin.lacabane@elastic.co"},"sourceCommit":{"committedDate":"2025-07-03T15:41:25Z","message":"update adm-zip dependency to 0.5.16 (#219079)\n\n## Summary\n\nUpdate adm-zip dependency from v0.5.9 to v0.5.16 which brings additional\nsafety mechanism around zip files manipulation\n\n**Files using adm-zip**\n\n- [x]\n`x-pack/packages/ai-infra/product-doc-artifact-builder/src/tasks/create_artifact.ts`\n- @elastic/appex-ai-infra\n- [x]\n`x-pack/platform/plugins/shared/automatic_import/server/integration_builder/build_integration.ts`\n- @elastic/security-scalability\n- [x]\n`x-pack/solutions/observability/plugins/synthetics/server/common/unzip_project_code.ts`\n- @elastic/obs-ux-management-team\n- [x]\n`x-pack/solutions/security/plugins/security_solution/server/lib/telemetry/artifact.ts`\n- @elastic/security-data-analytics\n- [x]\n`x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_reindex_to_fix_sparse_vector_support.spec.ts`\n- @elastic/obs-ai-assistant\n- [x]\n`x-pack/platform/plugins/shared/streams/server/lib/content/archive.ts` -\n@elastic/obs-entities\n\nI've requested an explicit approval for the owners of the file mentioned\nabove since I don't know if a failure in the paths using the library\nwould be covered by integration tests\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>","sha":"193eb33771724a49dee60e8184527602ff8951c6","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-entities","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"update adm-zip dependency to 0.5.16","number":219079,"url":"https://github.com/elastic/kibana/pull/219079","mergeCommit":{"message":"update adm-zip dependency to 0.5.16 (#219079)\n\n## Summary\n\nUpdate adm-zip dependency from v0.5.9 to v0.5.16 which brings additional\nsafety mechanism around zip files manipulation\n\n**Files using adm-zip**\n\n- [x]\n`x-pack/packages/ai-infra/product-doc-artifact-builder/src/tasks/create_artifact.ts`\n- @elastic/appex-ai-infra\n- [x]\n`x-pack/platform/plugins/shared/automatic_import/server/integration_builder/build_integration.ts`\n- @elastic/security-scalability\n- [x]\n`x-pack/solutions/observability/plugins/synthetics/server/common/unzip_project_code.ts`\n- @elastic/obs-ux-management-team\n- [x]\n`x-pack/solutions/security/plugins/security_solution/server/lib/telemetry/artifact.ts`\n- @elastic/security-data-analytics\n- [x]\n`x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_reindex_to_fix_sparse_vector_support.spec.ts`\n- @elastic/obs-ai-assistant\n- [x]\n`x-pack/platform/plugins/shared/streams/server/lib/content/archive.ts` -\n@elastic/obs-entities\n\nI've requested an explicit approval for the owners of the file mentioned\nabove since I don't know if a failure in the paths using the library\nwould be covered by integration tests\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>","sha":"193eb33771724a49dee60e8184527602ff8951c6"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219079","number":219079,"mergeCommit":{"message":"update adm-zip dependency to 0.5.16 (#219079)\n\n## Summary\n\nUpdate adm-zip dependency from v0.5.9 to v0.5.16 which brings additional\nsafety mechanism around zip files manipulation\n\n**Files using adm-zip**\n\n- [x]\n`x-pack/packages/ai-infra/product-doc-artifact-builder/src/tasks/create_artifact.ts`\n- @elastic/appex-ai-infra\n- [x]\n`x-pack/platform/plugins/shared/automatic_import/server/integration_builder/build_integration.ts`\n- @elastic/security-scalability\n- [x]\n`x-pack/solutions/observability/plugins/synthetics/server/common/unzip_project_code.ts`\n- @elastic/obs-ux-management-team\n- [x]\n`x-pack/solutions/security/plugins/security_solution/server/lib/telemetry/artifact.ts`\n- @elastic/security-data-analytics\n- [x]\n`x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_reindex_to_fix_sparse_vector_support.spec.ts`\n- @elastic/obs-ai-assistant\n- [x]\n`x-pack/platform/plugins/shared/streams/server/lib/content/archive.ts` -\n@elastic/obs-entities\n\nI've requested an explicit approval for the owners of the file mentioned\nabove since I don't know if a failure in the paths using the library\nwould be covered by integration tests\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>","sha":"193eb33771724a49dee60e8184527602ff8951c6"}}]}] BACKPORT--> Co-authored-by: Kevin Lacabane <kevin.lacabane@elastic.co> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
This was referenced Jul 4, 2025
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary Update adm-zip dependency from v0.5.9 to v0.5.16 which brings additional safety mechanism around zip files manipulation **Files using adm-zip** - [x] `x-pack/packages/ai-infra/product-doc-artifact-builder/src/tasks/create_artifact.ts` - @elastic/appex-ai-infra - [x] `x-pack/platform/plugins/shared/automatic_import/server/integration_builder/build_integration.ts` - @elastic/security-scalability - [x] `x-pack/solutions/observability/plugins/synthetics/server/common/unzip_project_code.ts` - @elastic/obs-ux-management-team - [x] `x-pack/solutions/security/plugins/security_solution/server/lib/telemetry/artifact.ts` - @elastic/security-data-analytics - [x] `x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_reindex_to_fix_sparse_vector_support.spec.ts` - @elastic/obs-ai-assistant - [x] `x-pack/platform/plugins/shared/streams/server/lib/content/archive.ts` - @elastic/obs-entities I've requested an explicit approval for the owners of the file mentioned above since I don't know if a failure in the paths using the library would be covered by integration tests --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update adm-zip dependency from v0.5.9 to v0.5.16 which brings additional safety mechanism around zip files manipulation
Files using adm-zip
x-pack/packages/ai-infra/product-doc-artifact-builder/src/tasks/create_artifact.ts- @elastic/appex-ai-infrax-pack/platform/plugins/shared/automatic_import/server/integration_builder/build_integration.ts- @elastic/security-scalabilityx-pack/solutions/observability/plugins/synthetics/server/common/unzip_project_code.ts- @elastic/obs-ux-management-teamx-pack/solutions/security/plugins/security_solution/server/lib/telemetry/artifact.ts- @elastic/security-data-analyticsx-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_reindex_to_fix_sparse_vector_support.spec.ts- @elastic/obs-ai-assistantx-pack/platform/plugins/shared/streams/server/lib/content/archive.ts- @elastic/obs-entitiesI've requested an explicit approval for the owners of the file mentioned above since I don't know if a failure in the paths using the library would be covered by integration tests