Skip to content

[Security Solution][Data Quality Dashboard] Remove tour guide#222311

Merged
kapral18 merged 1 commit intoelastic:mainfrom
kapral18:chore/dqd/remove-historical-results-tour-guide
Jun 3, 2025
Merged

[Security Solution][Data Quality Dashboard] Remove tour guide#222311
kapral18 merged 1 commit intoelastic:mainfrom
kapral18:chore/dqd/remove-historical-results-tour-guide

Conversation

@kapral18
Copy link
Copy Markdown
Contributor

@kapral18 kapral18 commented Jun 3, 2025

addresses #222159

  • remove historical results tour guide and related functionality and tests

@kapral18 kapral18 self-assigned this Jun 3, 2025
@kapral18 kapral18 requested a review from a team as a code owner June 3, 2025 08:55
@kapral18 kapral18 added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore labels Jun 3, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@kapral18 kapral18 marked this pull request as draft June 3, 2025 08:58
@kapral18 kapral18 force-pushed the chore/dqd/remove-historical-results-tour-guide branch from b498989 to 77d21ff Compare June 3, 2025 13:04
@kapral18 kapral18 marked this pull request as ready for review June 3, 2025 13:05
addresses elastic#222159

- remove historical results tour guide and related functionality and
  tests
@kapral18 kapral18 force-pushed the chore/dqd/remove-historical-results-tour-guide branch from 77d21ff to dd5638f Compare June 3, 2025 14:24
Copy link
Copy Markdown
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 LGTM!

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 7451 7447 -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.2MB 9.2MB -2.7KB
Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/ecs-data-quality-dashboard 10 9 -1

Total ESLint disabled count

id before after diff
@kbn/ecs-data-quality-dashboard 10 9 -1

History

cc @kapral18

@kapral18 kapral18 merged commit 8440103 into elastic:main Jun 3, 2025
10 checks passed
@kapral18 kapral18 deleted the chore/dqd/remove-historical-results-tour-guide branch June 3, 2025 17:10
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.17, 8.18, 8.19, 9.0

https://github.com/elastic/kibana/actions/runs/15423527212

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.17 Backport failed because of merge conflicts
8.18 An unhandled error occurred. Please see the logs for details
8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- [Discover] Add Actions header to unified data table (#214366) (#220824)
- [Automatic Migration] Introduce Last execution info for a migration (#221635)
- [Cloud Secutity Posture] Add cloud connector support for asset discovery (#221689)
- [Cloud Security] Add Fleet Extensions for Cloud Asset Discovery to Enable Custom Onboarding UI (#219001)
- [Cloud Security] Add Cloud Connectors CSPM Support (#212200)
- [APM] Remove apmTraceExplorerTab setting and feature (#219063)
- [ColorMapping] Store assignments as raw/serialized values (#207957)
9.0 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 222311

Questions ?

Please refer to the Backport tool documentation

kapral18 added a commit to kapral18/kibana that referenced this pull request Jun 3, 2025
…c#222311)

addresses elastic#222159

- remove historical results tour guide and related functionality and
tests

(cherry picked from commit 8440103)

# Conflicts:
#	x-pack/platform/plugins/private/translations/translations/fr-FR.json
#	x-pack/platform/plugins/private/translations/translations/ja-JP.json
#	x-pack/platform/plugins/private/translations/translations/zh-CN.json
#	x-pack/solutions/security/packages/ecs-data-quality-dashboard/impl/data_quality_panel/data_quality_details/indices_details/index.test.tsx
#	x-pack/solutions/security/packages/ecs-data-quality-dashboard/impl/data_quality_panel/data_quality_details/indices_details/pattern/index_check_flyout/index.tsx
kapral18 added a commit to kapral18/kibana that referenced this pull request Jun 3, 2025
…c#222311)

addresses elastic#222159

- remove historical results tour guide and related functionality and
tests

(cherry picked from commit 8440103)

# Conflicts:
#	x-pack/platform/plugins/private/translations/translations/fr-FR.json
#	x-pack/platform/plugins/private/translations/translations/ja-JP.json
#	x-pack/platform/plugins/private/translations/translations/zh-CN.json
kapral18 added a commit to kapral18/kibana that referenced this pull request Jun 3, 2025
…c#222311)

addresses elastic#222159

- remove historical results tour guide and related functionality and
tests

(cherry picked from commit 8440103)

# Conflicts:
#	x-pack/platform/plugins/private/translations/translations/fr-FR.json
#	x-pack/platform/plugins/private/translations/translations/ja-JP.json
#	x-pack/platform/plugins/private/translations/translations/zh-CN.json
#	x-pack/solutions/security/packages/ecs-data-quality-dashboard/impl/data_quality_panel/data_quality_details/indices_details/index.test.tsx
#	x-pack/solutions/security/packages/ecs-data-quality-dashboard/impl/data_quality_panel/data_quality_details/indices_details/pattern/index_check_flyout/index.tsx
@kapral18
Copy link
Copy Markdown
Contributor Author

kapral18 commented Jun 3, 2025

💚 All backports created successfully

Status Branch Result
9.0
8.19
8.18
8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kapral18 added a commit to kapral18/kibana that referenced this pull request Jun 3, 2025
…c#222311)

addresses elastic#222159

- remove historical results tour guide and related functionality and
tests

(cherry picked from commit 8440103)

# Conflicts:
#	x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality_panel/data_quality_details/indices_details/constants.ts
#	x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality_panel/data_quality_details/indices_details/hooks/use_is_historical_results_tour_active/index.tsx
#	x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality_panel/data_quality_details/indices_details/index.test.tsx
#	x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality_panel/data_quality_details/indices_details/index.tsx
#	x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality_panel/data_quality_details/indices_details/pattern/historical_results_tour/index.test.tsx
#	x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality_panel/data_quality_details/indices_details/pattern/historical_results_tour/index.tsx
#	x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality_panel/data_quality_details/indices_details/pattern/historical_results_tour/translations.ts
#	x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality_panel/data_quality_details/indices_details/pattern/index_check_flyout/index.tsx
#	x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality_panel/data_quality_details/indices_details/pattern/summary_table/utils/columns.test.tsx
#	x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality_panel/data_quality_details/indices_details/pattern/summary_table/utils/columns.tsx
#	x-pack/plugins/translations/translations/fr-FR.json
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
kapral18 added a commit that referenced this pull request Jun 4, 2025
…222311) (#222441)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Security Solution][Data Quality Dashboard] Remove tour guide
(#222311)](#222311)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Karen
Grigoryan","email":"karen.grigoryan@elastic.co"},"sourceCommit":{"committedDate":"2025-06-03T17:10:20Z","message":"[Security
Solution][Data Quality Dashboard] Remove tour guide
(#222311)\n\naddresses #222159\n\n- remove historical results tour guide
and related functionality
and\ntests","sha":"8440103b78410f1c0e3050929fbe9b99643e95de","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team:Threat
Hunting:Explore","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Security
Solution][Data Quality Dashboard] Remove tour
guide","number":222311,"url":"https://github.com/elastic/kibana/pull/222311","mergeCommit":{"message":"[Security
Solution][Data Quality Dashboard] Remove tour guide
(#222311)\n\naddresses #222159\n\n- remove historical results tour guide
and related functionality
and\ntests","sha":"8440103b78410f1c0e3050929fbe9b99643e95de"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222311","number":222311,"mergeCommit":{"message":"[Security
Solution][Data Quality Dashboard] Remove tour guide
(#222311)\n\naddresses #222159\n\n- remove historical results tour guide
and related functionality
and\ntests","sha":"8440103b78410f1c0e3050929fbe9b99643e95de"}}]}]
BACKPORT-->
kapral18 added a commit that referenced this pull request Jun 4, 2025
…222311) (#222444)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Security Solution][Data Quality Dashboard] Remove tour guide
(#222311)](#222311)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Karen
Grigoryan","email":"karen.grigoryan@elastic.co"},"sourceCommit":{"committedDate":"2025-06-03T17:10:20Z","message":"[Security
Solution][Data Quality Dashboard] Remove tour guide
(#222311)\n\naddresses #222159\n\n- remove historical results tour guide
and related functionality
and\ntests","sha":"8440103b78410f1c0e3050929fbe9b99643e95de","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team:Threat
Hunting:Explore","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Security
Solution][Data Quality Dashboard] Remove tour
guide","number":222311,"url":"https://github.com/elastic/kibana/pull/222311","mergeCommit":{"message":"[Security
Solution][Data Quality Dashboard] Remove tour guide
(#222311)\n\naddresses #222159\n\n- remove historical results tour guide
and related functionality
and\ntests","sha":"8440103b78410f1c0e3050929fbe9b99643e95de"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222311","number":222311,"mergeCommit":{"message":"[Security
Solution][Data Quality Dashboard] Remove tour guide
(#222311)\n\naddresses #222159\n\n- remove historical results tour guide
and related functionality
and\ntests","sha":"8440103b78410f1c0e3050929fbe9b99643e95de"}}]}]
BACKPORT-->
kapral18 added a commit that referenced this pull request Jun 4, 2025
…222311) (#222447)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Security Solution][Data Quality Dashboard] Remove tour guide
(#222311)](#222311)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Karen
Grigoryan","email":"karen.grigoryan@elastic.co"},"sourceCommit":{"committedDate":"2025-06-03T17:10:20Z","message":"[Security
Solution][Data Quality Dashboard] Remove tour guide
(#222311)\n\naddresses #222159\n\n- remove historical results tour guide
and related functionality
and\ntests","sha":"8440103b78410f1c0e3050929fbe9b99643e95de","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team:Threat
Hunting:Explore","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Security
Solution][Data Quality Dashboard] Remove tour
guide","number":222311,"url":"https://github.com/elastic/kibana/pull/222311","mergeCommit":{"message":"[Security
Solution][Data Quality Dashboard] Remove tour guide
(#222311)\n\naddresses #222159\n\n- remove historical results tour guide
and related functionality
and\ntests","sha":"8440103b78410f1c0e3050929fbe9b99643e95de"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222311","number":222311,"mergeCommit":{"message":"[Security
Solution][Data Quality Dashboard] Remove tour guide
(#222311)\n\naddresses #222159\n\n- remove historical results tour guide
and related functionality
and\ntests","sha":"8440103b78410f1c0e3050929fbe9b99643e95de"}}]}]
BACKPORT-->
kapral18 added a commit that referenced this pull request Jun 4, 2025
…222311) (#222461)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Security Solution][Data Quality Dashboard] Remove tour guide
(#222311)](#222311)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Karen
Grigoryan","email":"karen.grigoryan@elastic.co"},"sourceCommit":{"committedDate":"2025-06-03T17:10:20Z","message":"[Security
Solution][Data Quality Dashboard] Remove tour guide
(#222311)\n\naddresses #222159\n\n- remove historical results tour guide
and related functionality
and\ntests","sha":"8440103b78410f1c0e3050929fbe9b99643e95de","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team:Threat
Hunting:Explore","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Security
Solution][Data Quality Dashboard] Remove tour
guide","number":222311,"url":"https://github.com/elastic/kibana/pull/222311","mergeCommit":{"message":"[Security
Solution][Data Quality Dashboard] Remove tour guide
(#222311)\n\naddresses #222159\n\n- remove historical results tour guide
and related functionality
and\ntests","sha":"8440103b78410f1c0e3050929fbe9b99643e95de"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222311","number":222311,"mergeCommit":{"message":"[Security
Solution][Data Quality Dashboard] Remove tour guide
(#222311)\n\naddresses #222159\n\n- remove historical results tour guide
and related functionality
and\ntests","sha":"8440103b78410f1c0e3050929fbe9b99643e95de"}}]}]
BACKPORT-->
zacharyparikh pushed a commit to zacharyparikh/kibana that referenced this pull request Jun 4, 2025
…c#222311)

addresses elastic#222159

- remove historical results tour guide and related functionality and
tests
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
…c#222311)

addresses elastic#222159

- remove historical results tour guide and related functionality and
tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v8.17.8 v8.18.3 v8.19.0 v9.0.3 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants