Skip to content

[APM] Remove apmTraceExplorerTab setting and feature#219063

Merged
rmyz merged 11 commits intoelastic:mainfrom
rmyz:218501-remove-setting-apmTraceExplorerTab
May 7, 2025
Merged

[APM] Remove apmTraceExplorerTab setting and feature#219063
rmyz merged 11 commits intoelastic:mainfrom
rmyz:218501-remove-setting-apmTraceExplorerTab

Conversation

@rmyz
Copy link
Copy Markdown
Contributor

@rmyz rmyz commented Apr 24, 2025

Summary

Part of #218501

This PR removes the advanced setting observability:apmTraceExplorerTab and the feature.

@rmyz rmyz added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting apm:settings Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Apr 24, 2025
@rmyz rmyz self-assigned this Apr 24, 2025
@rmyz rmyz requested review from a team as code owners April 24, 2025 10:40
@rmyz rmyz requested a review from a team April 24, 2025 10:40
@rmyz rmyz requested review from a team as code owners April 24, 2025 10:40
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot added the Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. label Apr 24, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs-ux-management changes LGTM

@prodsecmachine
Copy link
Copy Markdown
Collaborator

prodsecmachine commented May 2, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@rmyz rmyz requested a review from MiriamAparicio May 2, 2025 07:56
@rmyz rmyz changed the title [APM] Remove apmTraceExplorerTab setting and feature it by default [APM] Remove apmTraceExplorerTab setting and feature May 5, 2025
# Conflicts:
#	src/platform/packages/shared/kbn-management/settings/setting_ids/index.ts
#	src/platform/packages/shared/serverless/settings/observability_project/index.ts
#	src/platform/plugins/private/kibana_usage_collection/server/collectors/management/schema.ts
#	src/platform/plugins/private/kibana_usage_collection/server/collectors/management/types.ts
#	src/platform/plugins/shared/telemetry/schema/oss_platform.json
#	x-pack/platform/plugins/private/translations/translations/fr-FR.json
#	x-pack/platform/plugins/private/translations/translations/ja-JP.json
#	x-pack/platform/plugins/private/translations/translations/zh-CN.json
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1872 1870 -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/management-settings-ids 131 130 -1
observability 682 671 -11
total -12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.5MB 2.5MB -3.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 93.8KB 93.7KB -76.0B
Unknown metric groups

API count

id before after diff
@kbn/management-settings-ids 132 131 -1
observability 689 678 -11
total -12

ESLint disabled line counts

id before after diff
apm 68 67 -1

Total ESLint disabled count

id before after diff
apm 81 80 -1

History

cc @rmyz

@rmyz rmyz enabled auto-merge (squash) May 6, 2025 13:05
Copy link
Copy Markdown
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM 🚀

@rmyz rmyz merged commit 89c9135 into elastic:main May 7, 2025
9 checks passed
@rmyz rmyz deleted the 218501-remove-setting-apmTraceExplorerTab branch May 7, 2025 08:48
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
## Summary

Part of elastic#218501

This PR removes the advanced setting `observability:apmTraceExplorerTab`
and the feature.
rmyz added a commit to rmyz/kibana that referenced this pull request Jun 3, 2025
## Summary

Part of elastic#218501

This PR removes the advanced setting `observability:apmTraceExplorerTab`
and the feature.

(cherry picked from commit 89c9135)

# Conflicts:
#	docs/reference/advanced-settings.md
#	x-pack/solutions/observability/plugins/apm/public/components/app/service_map/cytoscape.tsx
#	x-pack/solutions/observability/plugins/apm/public/components/app/service_map/cytoscape_options.ts
#	x-pack/solutions/observability/plugins/apm/public/components/app/service_map/popover/index.tsx
@rmyz
Copy link
Copy Markdown
Contributor Author

rmyz commented Jun 3, 2025

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

qn895 pushed a commit to qn895/kibana that referenced this pull request Jun 3, 2025
## Summary

Part of elastic#218501

This PR removes the advanced setting `observability:apmTraceExplorerTab`
and the feature.
rmyz added a commit that referenced this pull request Jun 3, 2025
… (#222422)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[APM] Remove `apmTraceExplorerTab` setting and feature
(#219063)](#219063)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-05-07T08:46:56Z","message":"[APM]
Remove `apmTraceExplorerTab` setting and feature (#219063)\n\n##
Summary\n\nPart of #218501\n\nThis PR removes the advanced setting
`observability:apmTraceExplorerTab`\nand the
feature.","sha":"89c91350cc0c7041c58462ef8f2b3fc2a02bd448","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","apm:settings","Team:obs-ux-infra_services","Team:obs-ux-management","v9.1.0"],"title":"[APM]
Remove `apmTraceExplorerTab` setting and
feature","number":219063,"url":"https://github.com/elastic/kibana/pull/219063","mergeCommit":{"message":"[APM]
Remove `apmTraceExplorerTab` setting and feature (#219063)\n\n##
Summary\n\nPart of #218501\n\nThis PR removes the advanced setting
`observability:apmTraceExplorerTab`\nand the
feature.","sha":"89c91350cc0c7041c58462ef8f2b3fc2a02bd448"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219063","number":219063,"mergeCommit":{"message":"[APM]
Remove `apmTraceExplorerTab` setting and feature (#219063)\n\n##
Summary\n\nPart of #218501\n\nThis PR removes the advanced setting
`observability:apmTraceExplorerTab`\nand the
feature.","sha":"89c91350cc0c7041c58462ef8f2b3fc2a02bd448"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
florent-leborgne added a commit to florent-leborgne/kibana that referenced this pull request Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:settings backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants